From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=LZ7pOqzf; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 88D385A0269 for ; Tue, 24 Feb 2026 06:58:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1771912683; bh=LcnxKUemHftR4ah9K6zatOKhp/jOwP6wKcBoyb5Hjzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LZ7pOqzfJvoIbL7BCsUMa77jviwN7EAIUDIJMcwHTVheOE4mh4kzgi5bV8/zqKItt pvsgZFvBuUreO0DS6fUVPVSblqsAPfsSMxxqxATKaXZNqN3TqafnaDt2/N07EOsBNm oONXpT3UstVipGpDZTv1Z6cRGBIracEwHqdaQCfLOuwnh0HAehBJuMz6joeF1K72eF T3j/BQSuqYW2x2HaKbahm8Nm/ugo3IyxhKK+hI9hVCBiqcRHGfPMyTIQa4qVVV0rlR Fw7iN9AoF0q+qyPDJMxroKDP2uFXe6kzD9H2hRSbi9nuk3UX55jOD2E9RSiaktRaym 3TskeYK/ldHcQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fKn7v59jnz4wBF; Tue, 24 Feb 2026 16:58:03 +1100 (AEDT) Date: Tue, 24 Feb 2026 16:47:46 +1100 From: David Gibson To: Peter Foley Subject: Re: [PATCH] Fix build when HAS_GETRANDOM is undefined Message-ID: References: <20260223172739.144834-1-pefoley@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+8pY+BjcFj/iZqie" Content-Disposition: inline In-Reply-To: <20260223172739.144834-1-pefoley@google.com> Message-ID-Hash: R3JYVVMIW4YO65IV3XLGSDWPFUJ7KC2H X-Message-ID-Hash: R3JYVVMIW4YO65IV3XLGSDWPFUJ7KC2H X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+8pY+BjcFj/iZqie Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2026 at 12:27:39PM -0500, Peter Foley wrote: > e.g. > util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you= mean 'raw_random'? > 1163 | ret =3D read(dev_random, (char *)buf + random_rea= d, >=20 > Signed-off-by: Peter Foley Oops, that's mildly embarrassing. Reviewed-by: David Gibson > --- > util.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/util.c b/util.c > index db27431..a4f2be4 100644 > --- a/util.c > +++ b/util.c > @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen) > ret =3D getrandom((char *)buf + random_read, > buflen - random_read, GRND_RANDOM); > #else > - ret =3D read(dev_random, (char *)buf + random_read, > + ret =3D read(fd, (char *)buf + random_read, > buflen - random_read); > #endif > =20 > @@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen) > } > =20 > #ifndef HAS_GETRANDOM > - close(dev_random); > + close(fd); > #endif > =20 > if (random_read < buflen) > --=20 > 2.53.0.371.g1d285c8824-goog >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --+8pY+BjcFj/iZqie Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmdO30ACgkQzQJF27ox 2GeOlhAAhAG2baLSO3GUB1mTFWpkYr3dq0y+TrVI9hZ1JCWBS98pyGpmRpIOMaKy daGhjSiJpA1u83Zpj48+l4g6/eFZlm10gOfYiK0Fylgw5RJLLq1J946fdkWmp0Os yQyymeePvzoXL60uspzkE52LXxezY6yI7Hf6r1yMK3FL29LJmlyz/iVBJP3sGGkA AYYdKYlsyqH3o/vwJ9FiWCilcidRLDXmxpcI8Ybrga4OApkWYvPrbGfEqIKgww69 9C+OTr8J0rVZw81dMPmUelCux5vCS0u0NobNCBTVt6yrUcIXN77CCjc1GzlsaNVp sUCdmMidKHoM3/INdNIYWKAX0/EobGalRIh9kHvfJrbD02h5SBMpQ8Bg0bux8ZGy WnA2PLJaFJkALHpsHie9a2CN2swklZcGXnvpa3V9vuK1LhMW7UYzdI/GCIEc3PXD Jzh6Wpa70CV0i5AojaberVdtIjq/KFakVRrU3uK0BGAguI762q07fVNwbGHyoAnu +HyKeqNgzRQ7rPCjJ6zz3p1huhex8TWiczDbEkAX4HTdD/pQ48Pve8HDUGybkZz/ F3gTL9o38q6pp9rknlG1jj2B907SBm2d2Si4Df7R72evSS3rwZwNqu6Ex6bgl9IZ hJhjiMb3XQl8vlRO2l6NzkhFfjpv4+7nc43Nk5NSreX0jV/oyns= =c6hd -----END PGP SIGNATURE----- --+8pY+BjcFj/iZqie--