From: David Gibson <david@gibson.dropbear.id.au>
To: Peter Foley <pefoley@google.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Avoid clang warnings in fwd.h
Date: Tue, 24 Feb 2026 16:48:14 +1100 [thread overview]
Message-ID: <aZ07nqzLWM6LyAUB@zatzit> (raw)
In-Reply-To: <20260223172920.146057-1-pefoley@google.com>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote:
> e.g.
> ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
> 65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
>
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> fwd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fwd.h b/fwd.h
> index 1607011..7d299b6 100644
> --- a/fwd.h
> +++ b/fwd.h
> @@ -62,7 +62,7 @@ union fwd_listen_ref {
> };
> uint32_t u32;
> };
> -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");
I'd prefer to see an actual message added here, rather than just
minimally suppressing the warning.
>
> enum fwd_ports_mode {
> FWD_UNSET = 0,
> --
> 2.53.0.371.g1d285c8824-goog
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-02-24 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 17:29 Peter Foley
2026-02-24 5:48 ` David Gibson [this message]
2026-02-24 8:50 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ07nqzLWM6LyAUB@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pefoley@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).