From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=Uy3uDFFG; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 710425A0265 for ; Tue, 24 Feb 2026 06:58:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1771912683; bh=LVcppfHp9qyuzrK+2pNsvaT9fTa9HqSxv0vgp3NEfiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uy3uDFFG9KSLzmDv3+eNp0jstRm0e2mu2eSektqe12/uQ/RM78AAtKKnmW6qTOBWu H90mSdXd5Jf45bK2nlIYKsHc2vchP3ySnvPd4u6Yrq8YMkSmdyV0rwpVCV4hI05d4s nZtbzPBkIsQ2v0WM7bLpoYOA5i8IOU3WVJtbcpa60G4LKcby/dRSsW92hZP3QyF1AP w/KPXiqwMntxQjeofdqSVhoehJ7gw2r2WAcLzSSCRk0Tro8mJWvJSlwMbeS3e4nFkV UsLX0T/nrg4TwM8FuYiL1eX+v7Cgvx/xWfyPxeu4W1NrUWMxnl8dMow+Ht2w9V/QF7 woBYW/e1PYi/Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fKn7v5J8hz4w1v; Tue, 24 Feb 2026 16:58:03 +1100 (AEDT) Date: Tue, 24 Feb 2026 16:48:14 +1100 From: David Gibson To: Peter Foley Subject: Re: [PATCH] Avoid clang warnings in fwd.h Message-ID: References: <20260223172920.146057-1-pefoley@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pn6W7SVCLlX6cA2L" Content-Disposition: inline In-Reply-To: <20260223172920.146057-1-pefoley@google.com> Message-ID-Hash: I3COGM23VSS2JDSXXU7RYW4FFHVLC4NU X-Message-ID-Hash: I3COGM23VSS2JDSXXU7RYW4FFHVLC4NU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Pn6W7SVCLlX6cA2L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote: > e.g. > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extensi= on [-Wc23-extensions] > 65 | static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint32_t= )); >=20 > Signed-off-by: Peter Foley > --- > fwd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fwd.h b/fwd.h > index 1607011..7d299b6 100644 > --- a/fwd.h > +++ b/fwd.h > @@ -62,7 +62,7 @@ union fwd_listen_ref { > }; > uint32_t u32; > }; > -static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint32_t)); > +static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint32_t), ""); I'd prefer to see an actual message added here, rather than just minimally suppressing the warning. > =20 > enum fwd_ports_mode { > FWD_UNSET =3D 0, > --=20 > 2.53.0.371.g1d285c8824-goog >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Pn6W7SVCLlX6cA2L Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmdO50ACgkQzQJF27ox 2GeV0w//W5fXffOwmlgXAVSVIkFTioB/xfzapaUAc+GdlsouK6mnGIDfJDx1wsrF VloCkQp/EHj2nxDTKnnw+VuCR7ZAY0ixkG1S5iRaP1B8c/1LKoNXYdFBagb0Zisy LUOFW2R50obbsglwkMeKdS5tu4tYiUaqLzfjZ0nHVgJ3VlSs8q2JDGkKu/WPjTpI ZzcNP1tZ6Wwyg7NPsfHv1HlRLFsgZSBRyNlDs/vxcjfCKCJ92QAGBEnafpcRcxFM HHAIBWxLlxjkH9hGztWGgMxnwWRQHX6m1YyBzxBb9mItWrW/p7kT5Pbib/6n4BmB V48BUU6mUSYo87PhqfjhRahe+180U731MnKpeuZ5Hkp53KpN9qaTyQcEm3OQxzjV +JlB283Ys+mHycXNTd0LcmzdsCftYUkJBF1AbKs8YBAk8STFg7YcFdb67Gr23Mzc +gXvreqDekXijBREtaNsp4plRpqxnl9fvHRAmp1wwGrGl32zNaZwYEPB/YDoOKP5 0Wk4R7xkef4hACYe0dkyoV22EFPp7gds6F0++qpUT2YbefZaV1AEe1GKz1ELGfDu gx6A125TyHP2cb45y0J4ATQ1059bC+lud+4FUI0jpA6TtF4ImZks5r7IFqHRMcVw GoisJwj+ZzPi31NyiI55lfmby7PawyRQRpXRQoXh4jGjIMYBmIQ= =/Ziq -----END PGP SIGNATURE----- --Pn6W7SVCLlX6cA2L--