From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=VkR+Kff9; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E50DC5A0274 for ; Mon, 02 Mar 2026 02:26:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1772414782; bh=7GQ4CRkCIDV+ck63+vOo8Yf1aPy4t2dTEq7tygkIZdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VkR+Kff9s8twZNyXLQhK7q9+i8hDCvHqiGcDEP62+JaLyk12XldDWF2Dc1fMkfRok IOG92AwYvW4480VcJv5lrfCLRKkcb4aILzHAif6X1gPgnoSMIirpGfFmJQifgMHHSS 5pG4h94QB1PEOVNAR/H4J9fnkPvvDCXdCxdNXKIebfj+T68Zub/yNR8L48r3vK50MZ QgITLP3NOlX0btKI+pDVOx57QopaiYcuTbWMWbTEJfedcpcexaaZK0UxiJpXSfoTs7 ILRQbuUnx1olrg3stepuuRcrbaQob4wMO7iPCfE2SLsBMysjXYLi3BoLx4H0yw9aGc UTPiIo3p9vRWQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fPLqf6P4mz4wCB; Mon, 02 Mar 2026 12:26:22 +1100 (AEDT) Date: Mon, 2 Mar 2026 12:26:13 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 0/4] Reworks and improvements to TCP activity timers Message-ID: References: <20260206061739.33648-1-david@gibson.dropbear.id.au> <20260225071544.2c4b6de5@elisabeth> MIME-Version: 1.0 In-Reply-To: <20260225071544.2c4b6de5@elisabeth> X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0E8q82mEuS9wZFpe" Content-Disposition: inline Message-ID-Hash: 6DFB67KI5GCRLELYPSMLVOAYWRDWS7DH X-Message-ID-Hash: 6DFB67KI5GCRLELYPSMLVOAYWRDWS7DH X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --0E8q82mEuS9wZFpe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2026 at 07:15:45AM +0100, Stefano Brivio wrote: > On Fri, 6 Feb 2026 17:17:35 +1100 > David Gibson wrote: >=20 > > Here's a bunch of patches aimed at fixing bug 179, and reworking the > > currently broken inactivity timer along the way. > >=20 > > I believe patches 1..2/4 are ready to go - I've tested them, and I'm > > happy with how they're behaving. Patches 3..4/4 I think are correct, > > but I've been getting bogged down in details trying to test them in > > the specific FIN_WAIT_2 situation that occurs in bug 179. >=20 > I just tested things manually by cycling guest interfaces and checking > that keepalives come and eventually cause connection resets, as well as > that the activity timeout (shortened via define) triggers after the > expected time. Nice. > It's not great but I couldn't figure out a way to simulate the issue > with a single namespace test (without any connecting interface that can > be brought down), and simulating this with multiple namespaces > connected via veth looks doable, but not easy to integrate with the > existing tests. Right. I think it can be tested without bouncing interfaces at all - however it needs quite specific behaviour from both the client and the server. I couldn't figure out a way to convince socat to do what I wanted, so it would probably need custom endpoint programs. > Meanwhile the reporter of https://bugs.passt.top/show_bug.cgi?id=3D179 > confirms this series solves the issue, and delaying this further > doesn't sound like a good idea, so I went ahead and finally applied > this, fixing a trivial conflict with 812cdb802c6e ("tcp: Move tap > header update out of tcp_fill_headers()") on the way. Makes sense to me. --=20 David Gibson (he or they)=09| I'll have my music baroque, and my code david AT gibson.dropbear.id.au=09| minimalist, thank you, not the other way =09=09=09=09| around. http://www.ozlabs.org/~dgibson --0E8q82mEuS9wZFpe Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmk5zQACgkQzQJF27ox 2GdoIQ//d1Vdcmmf6otpkZ7z6qupS5YPeTFPFS+WOVNSqTPi74fognHDYBPgc/94 q/J1pDnxFN13AmETZ663aP9b+rhGL4myQviyI6uSJddm0oC1oHqWZZHRi2/4Uc0m VSR2xdMYbLeyJsLXoBMxI8uBPdwhSfZGb2s40jn38c6KMRlwBJ7JBI6A8tfGgxK4 vW4Y2NYX9qiiicPsygWcOEgZWxanKsy6dyIjGFG4AoWcw2w4B/krshO8nI92IYCA VDoWKANy2fzj1is0Q2Nkn2LsTVR5wrNmFOAJwTVTw3t+LIujnCk0DrNZA6h/3s+t aCkapRW9oyr4D9lL28ttY0rqMEwng2pF97Ty3gh31PWgvitCOTJsJ12R9ylWy+Z9 JTNd6fvNG05ZDmt4CuS1vpTuVcL2SCpNWR2/yb3giRKNXhVLn+JjrbeRKLrBEhup k5oNDOWkQzJ6dz293zN7Aaj3I/SdKIQmtF2YFBbYoPWOdCrvbF/YScRtN365Cbma 0sHI0H4CCdi5fYRMDBaV0SL48BTcGIXy1S+AA+KK6mLkPBxGj+vycgfqRcQt9nxU OOlKEhMLnrepULgbq+bdFRI/wln2HDAvit/7f5jF0MXu2BaKp2KhqGXVolOv1I4L OG6AVpjl/m1wgZP6KiPlNTZPFxMEFnE1mmVU0lVSIIfccj5Op6g= =dqYN -----END PGP SIGNATURE----- --0E8q82mEuS9wZFpe--