Re: [PATCH] Avoid clang warnings in fwd.h

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

On Tue, Feb 24, 2026 at 09:50:56AM +0100, Stefano Brivio wrote:
> On Tue, 24 Feb 2026 16:48:14 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote:
> > > e.g.
> > > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 extension [-Wc23-extensions]
> > >    65 | static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> > > 
> > > Signed-off-by: Peter Foley <pefoley@google.com>
> > > ---
> > >  fwd.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/fwd.h b/fwd.h
> > > index 1607011..7d299b6 100644
> > > --- a/fwd.h
> > > +++ b/fwd.h
> > > @@ -62,7 +62,7 @@ union fwd_listen_ref {
> > >  	};
> > >  	uint32_t u32;
> > >  };
> > > -static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t));
> > > +static_assert(sizeof(union fwd_listen_ref) == sizeof(uint32_t), "");  
> > 
> > I'd prefer to see an actual message added here, rather than just
> > minimally suppressing the warning.
> 
> Can you please suggest a message then? You added this static_assert()
> in the first place.

Fair point.

I looked into this, and realised that I can make another cleanup in
the vicinity which changes the union into a struct and makes this
static_assert() redundant amongst some other improvements.  Patch on
the list.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]