From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=JV8olwKI; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id A92D55A0274 for ; Mon, 02 Mar 2026 05:37:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1772426234; bh=0nJrEgsSPhTlKP3IRa6AHg5e0j8KLafGpT2BG/oQjKM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JV8olwKINTuIwvJDvfh0UQ7vQ3CLbd/GsGuAskSVXxGHylrGmGvb+KypBeuVyiK7W XZPYmky2R6I8tawqTHvMMd9i/OFZ63omqv+OMtAQzUk6fVJk8oWRSmTlq7l1mZk1hK tqZNA5iYC04KONXTAw6xB7DcWkOOZT2QKRvFHFBNGirfDf0UGRCnfJ9drrUrV8DaL9 0R+Qr6uPQaDRkvi9VWEFD8ffCc5dQy7s257rcpr+ihliF22SqdYFtC4Ozqti34JK4p hk7C1wMjzSsY9/cmahjdD8lTLJzmGOl/Gerj2qPrImeRCvcEs6BV7r4M7mj75f/DtV yvRWB+Ra2+rXQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fPR3t2JF7z4w9T; Mon, 02 Mar 2026 15:37:14 +1100 (AEDT) Date: Mon, 2 Mar 2026 15:34:52 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] Avoid clang warnings in fwd.h Message-ID: References: <20260223172920.146057-1-pefoley@google.com> <20260224095055.4c3be413@elisabeth> MIME-Version: 1.0 In-Reply-To: <20260224095055.4c3be413@elisabeth> X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mw8RiZA8te7nNCk+" Content-Disposition: inline Message-ID-Hash: EYHWKXU2H2JYWJJ3EWHLHSAMBONKHPHC X-Message-ID-Hash: EYHWKXU2H2JYWJJ3EWHLHSAMBONKHPHC X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Foley , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --mw8RiZA8te7nNCk+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 24, 2026 at 09:50:56AM +0100, Stefano Brivio wrote: > On Tue, 24 Feb 2026 16:48:14 +1100 > David Gibson wrote: >=20 > > On Mon, Feb 23, 2026 at 12:29:20PM -0500, Peter Foley wrote: > > > e.g. > > > ./fwd.h:65:63: warning: '_Static_assert' with no message is a C23 ext= ension [-Wc23-extensions] > > > 65 | static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint= 32_t)); > > >=20 > > > Signed-off-by: Peter Foley > > > --- > > > fwd.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/fwd.h b/fwd.h > > > index 1607011..7d299b6 100644 > > > --- a/fwd.h > > > +++ b/fwd.h > > > @@ -62,7 +62,7 @@ union fwd_listen_ref { > > > =09}; > > > =09uint32_t u32; > > > }; > > > -static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint32_t)); > > > +static_assert(sizeof(union fwd_listen_ref) =3D=3D sizeof(uint32_t), = ""); =20 > >=20 > > I'd prefer to see an actual message added here, rather than just > > minimally suppressing the warning. >=20 > Can you please suggest a message then? You added this static_assert() > in the first place. Fair point. I looked into this, and realised that I can make another cleanup in the vicinity which changes the union into a struct and makes this static_assert() redundant amongst some other improvements. Patch on the list. --=20 David Gibson (he or they)=09| I'll have my music baroque, and my code david AT gibson.dropbear.id.au=09| minimalist, thank you, not the other way =09=09=09=09| around. http://www.ozlabs.org/~dgibson --mw8RiZA8te7nNCk+ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmlE10ACgkQzQJF27ox 2GfvfRAAqL+Lin4v1THZ5wVruD/35DkxmL3PPf3oFqzzkYEZb8VSiJ5kT1AvbEOB 4VZ76oynIq3Vv5AG5dK8CM0B2zsUV4DN4pEQGUENF2HomBDcVsldu5BKyVaV+wPJ pbt6dB0YU3c5deusA/NyIWpYbmhtfKCnBNqTU9V+VkNJVWuw+mYciE3iuIg6byA5 MaLLKNZ9xChASainE/leXoChRBU8BA7aRRkr29h+Dx6lAJiN6ZTh/EKSOUiTSJSC dBft6LZBhVjva8tsruaagdvi62fBxysOC8gmnHZ9hhjrVqLn8yJz12oD4yW21EPZ doFygTtEVmApaM8Ds95XoGl4WqDbhscgln6I8uj36dRQQJltXNefWXmq1SvANsC1 RwKhDPXjTQjBbDtOoXgvqXY4I4OivZ0MfFr6P22CONc1D2d7msTIC/w/rbrD/tlx wfzlxBOszP6YGE9rViQw01GKr+MjfOktqF7nbepw19fdpMwuEqi4dM8ywSxF56dH 4AQ6SmzErFsVn6wBw7A4RBNQ4JjMm7aWDrHDMY15ka1m4/SWT7/AIogyskWFRjUW LF0x8txGCNRd5ZlKKjNCoTYNQbXd0g+gDkiSkQ1sGUkMX/pm0KemqHO8sConOxov OxJzie8Qbe7Krh7LO3HvuwizxslP44Gmq1da6hy2fAq53tJoMec= =iyih -----END PGP SIGNATURE----- --mw8RiZA8te7nNCk+--