public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Jon Maloy <jmaloy@redhat.com>, dgibson@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH v5 09/13] migrate: Rename v1 address functions to v2 for clarity
Date: Wed, 4 Mar 2026 09:56:57 +1100	[thread overview]
Message-ID: <aadnOZa7HevmOL3-@zatzit> (raw)
In-Reply-To: <aadeDFowWR0nHzpr@zatzit>

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

On Wed, Mar 04, 2026 at 09:17:48AM +1100, David Gibson wrote:
> On Tue, Mar 03, 2026 at 08:11:50PM +0100, Stefano Brivio wrote:
> > On Tue, 3 Mar 2026 12:53:23 +1100
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> > 
> > > On Sun, Feb 22, 2026 at 12:44:41PM -0500, Jon Maloy wrote:
> > > > Some migration address structures and functions have a _v1 suffix.
> > > > This is confusing, since they are currently handling version 2 of
> > > > the migration protocol. We are now going to introduce a new version
> > > > 3 of the protocol, so we choose to give these functions the correct
> > > > suffix _v2 instead. This is in correspondence with current reality,
> > > > and will help make a clearer distinction between the old and the new
> > > > versions of those functions.
> > > > 
> > > > Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> > > > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>  
> > > 
> > > Stefano, this is a sensible cleanup independent of the rest of the
> > > series.  Please apply.
> > 
> > Sure, I will.
> > 
> > What about 5/13, should I apply that independently as well, to start
> > cutting down a bit on the series? Jon, thoughts?
> 
> No.  Unlike 9/13, 5/13 depends on the earlier patches in the series.

Sorry, I mixed up 5/13 with a different one.

Yes, going ahead and merging 5/13 also makes sense.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-03-03 22:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 17:44 [PATCH v5 00/13] Introduce multiple addresses and late binding Jon Maloy
2026-02-22 17:44 ` [PATCH v5 01/13] ip: Introduce unified multi-address data structures Jon Maloy
2026-03-02 10:22   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 02/13] ip: Introduce for_each_addr() macro for address iteration Jon Maloy
2026-03-02 10:29   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 03/13] fwd: Unify guest accessibility checks with unified address array Jon Maloy
2026-03-02 10:33   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 04/13] arp: Check all configured addresses in ARP filtering Jon Maloy
2026-03-02 10:41   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 05/13] netlink: Return prefix length for IPv6 addresses in nl_addr_get() Jon Maloy
2026-03-02 10:43   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 06/13] conf: Allow multiple -a/--address options per address family Jon Maloy
2026-03-02 10:51   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 07/13] ip: Track observed guest IPv4 addresses in unified address array Jon Maloy
2026-03-03  1:40   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 08/13] ip: Track observed guest IPv6 " Jon Maloy
2026-03-03  1:52   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 09/13] migrate: Rename v1 address functions to v2 for clarity Jon Maloy
2026-03-03  1:53   ` David Gibson
2026-03-03 19:11     ` Stefano Brivio
2026-03-03 22:17       ` David Gibson
2026-03-03 22:56         ` David Gibson [this message]
2026-02-22 17:44 ` [PATCH v5 10/13] migrate: Update protocol to v3 for multi-address support Jon Maloy
2026-03-03  4:53   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 11/13] dhcp, dhcpv6: Select addresses for DHCP distribution Jon Maloy
2026-03-03  5:26   ` David Gibson
2026-02-22 17:44 ` [PATCH v5 12/13] ndp: Support advertising multiple prefixes in Router Advertisement Jon Maloy
2026-02-22 17:44 ` [PATCH v5 13/13] netlink: Add host-side monitoring for late template interface binding Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aadnOZa7HevmOL3-@zatzit \
    --to=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=jmaloy@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).