Re: [PATCH trivial 2/3] tcp_vu: Remove redundant eh->h_source assignment in tcp_vu_send_flag()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

On Fri, Mar 20, 2026 at 02:51:15PM +0100, Laurent Vivier wrote:
> tcp_fill_headers() calls eth_update_mac(eh, NULL, omac) which
> unconditionally overwrites eh->h_source.  The prior memcpy() setting
> it to c->our_tap_mac is therefore redundant.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tcp_vu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tcp_vu.c b/tcp_vu.c
> index c616b1fec2bf..9c4e916b1b8d 100644
> --- a/tcp_vu.c
> +++ b/tcp_vu.c
> @@ -102,7 +102,6 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_tap_conn *conn, int flags)
>  	eh = vu_eth(flags_elem[0].in_sg[0].iov_base);
>  
>  	memcpy(eh->h_dest, c->guest_mac, sizeof(eh->h_dest));
> -	memcpy(eh->h_source, c->our_tap_mac, sizeof(eh->h_source));
>  
>  	if (CONN_V4(conn)) {
>  		ip4h = vu_ip(flags_elem[0].in_sg[0].iov_base);
> -- 
> 2.53.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]