From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=GWo3U/6S; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 972745A0653 for ; Tue, 24 Mar 2026 00:11:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1774307506; bh=nuKiVDoenRRNB1Vi2vsQv7c+wTqLMoCneCMupJXwOBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GWo3U/6S2R86zQ6Jo1rt3ufvMqzvdJz5bhTRzf9f5KNioZuxW9Xl8IdFHqQ/Cy0D6 7FIwKfqTxBxCVRj7UB3lfAlG2B9AVBvS+bepSYK2MGSoraPwiKNS4V1KhWucQK/pi4 Bu7MMnhdRf9kPbDF7hnN7C47rJkVbO9mHsAlHkFt+ziMsfx5+rOP8SQsCXR/1wXCQ2 DW8OQIgCf0D4u5AtfSVYsCGpkjpgtgrr9OssSY4xJ2j7oICMd7vf0e4XsMbsRtxkW6 bGE9Jp3n7H/mBygaM1WRoe+VhuljOKQfUsCmgAPZItVSuwLNb49FpJs2z6u5YP1KEz ZS/MHKRa4v9Ug== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ffppB3LK8z4wCm; Tue, 24 Mar 2026 10:11:46 +1100 (AEDT) Date: Tue, 24 Mar 2026 10:11:39 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH trivial 3/3] tcp_vu: Remove redundant th->doff and th->ack in tcp_vu_send_flag() Message-ID: References: <20260320135116.575416-1-lvivier@redhat.com> <20260320135116.575416-4-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rVA4rjHGYBA4j4ZL" Content-Disposition: inline In-Reply-To: <20260320135116.575416-4-lvivier@redhat.com> Message-ID-Hash: FD45MXM4GUMU4USARQLDYY2JE27SFPF4 X-Message-ID-Hash: FD45MXM4GUMU4USARQLDYY2JE27SFPF4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --rVA4rjHGYBA4j4ZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2026 at 02:51:16PM +0100, Laurent Vivier wrote: > tcp_prepare_flags() unconditionally sets th->doff and th->ack, so > setting them right after the memset() is redundant. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > tcp_vu.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/tcp_vu.c b/tcp_vu.c > index 9c4e916b1b8d..7a348eb01248 100644 > --- a/tcp_vu.c > +++ b/tcp_vu.c > @@ -115,8 +115,6 @@ int tcp_vu_send_flag(const struct ctx *c, struct tcp_= tap_conn *conn, int flags) > } > =20 > memset(th, 0, sizeof(*th)); > - th->doff =3D sizeof(*th) / 4; > - th->ack =3D 1; > =20 > seq =3D conn->seq_to_tap; > opts =3D (struct tcp_syn_opts *)(th + 1); > --=20 > 2.53.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --rVA4rjHGYBA4j4ZL Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnByKoACgkQzQJF27ox 2GczhBAAmrUcmoz5zqJm1nGnxoanjQbMDNtVGVg+YXsD6emwfwNBt31LzNDWTqtl jXZWAHA/cdl47mcdMp6Ne1mntyak9HGwMlzt2EK1iOEXU70xXNUgcmhO+BWFUvo0 0ub+Of3Oa+z0jTL0ELpvGHNFA2NpqpO8G+Ni2ijUtjcxN0/dO46Vo2X+jAY0H2oc oW1IueR+zQYWBRLcmcQUzGGJcFVTgNRo4G2K2Nz5WNusBlkzLYxklyQF+BR7lDhn 2VWqJ2ss58zCwCNOJbLVfQQ9dfruZiDZfS2LACg3PHawRBYxh6sQ+e65H+ZSMWZK 8oMJK4LNFJvKzfO3chhAdeWle5aVveebR8ntc7sfsFEqNQ06L4T0ooQT3CQlCAcA Iddq2QPaTVQo+vy2aDD22mBW0wthtIg79oO77ZqyQqQviNZ4+vDWDSi8QbP+h7hM zvDah4jVm2jU+vyU8ooxV7VP4IOjRxEfG1X0Cql6UotIljcxp814GVM6YC1Mqziu fZlENQqB6SRovmWvt+xJk90TErZtqJnlpenm5KUpAt5fCmia/asjsUFsvzYDi1Oe J9rGIL8afY6T2zM9XOVIxF2hYWgVe9zZWzA4hvuG3rWuxlxnVLm53CvpLmk44rFY PP/g3KDI0UECS9oiWmsszrikBxMAu85tI1/ChjeAiUOrdVs0uaQ= =OX6r -----END PGP SIGNATURE----- --rVA4rjHGYBA4j4ZL--