From: Laine Stump <laine@redhat.com>
To: libvir-list@redhat.com
Cc: sbrivio@redhat.com, passt-dev@passt.top,
Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [PATCH 2/4] qemu_extdevice: Make qemuExtDevicesHasDevice() check def->nets
Date: Wed, 15 Feb 2023 02:22:57 -0500 [thread overview]
Message-ID: <aca8d4f3-1571-76c9-94dc-89cf2030cec0@redhat.com> (raw)
In-Reply-To: <446dd5c17d7c3aa302f30253edc33fa8788100fa.1676374699.git.mprivozn@redhat.com>
On 2/14/23 6:51 AM, Michal Privoznik wrote:
> We can have external helper processes running for domain
> <interface/> too (e.g. slirp or passt). But this is not reflected
> in qemuExtDevicesHasDevice() which simply ignores these.
The slirp-helper patches missed adding the check in this (oddly-named)
function (even while adding in the correct hunk to
qemuExtDevicesSetupCroup()) probably because it wasn't really obvious
without reading/interpreting/understanding all the code in two separate
files that it was needed; my passt patches missed adding the check in
this function because I was following the pattern of what was done for
slirp, and slirp hadn't touched this function (nor had it touched the
function that calls both of these functions,
qemuSetupCgroupForExtDevices(), which is in another file). It's
reasonable to think that some future person may also not notice
qemuExtDevicesHasDevice(), and believe that they only need to modify
qemuExtDevicesSetupCgroup().
Anyway, my point is that I think this could be avoided by adding a
comment in qemuExtDevicesSetupCgroup() that points out it is only called
if qemuExtDevicesHasDevice() returns true, and so any addition to
qemuExtDevicesSetupCgroup() should have a corresponding addition to
qemuExtDevicesHasDevice(). It's too late at night / early in the morning
for my brain to compose a concise sentence to this effect, but it would
make me happy if you added one before pushing.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
> ---
> src/qemu/qemu_extdevice.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
> index fdefe59215..47e97f3565 100644
> --- a/src/qemu/qemu_extdevice.c
> +++ b/src/qemu/qemu_extdevice.c
> @@ -296,6 +296,17 @@ qemuExtDevicesHasDevice(virDomainDef *def)
> return true;
> }
>
> + for (i = 0; i < def->nnets; i++) {
> + virDomainNetDef *net = def->nets[i];
> +
> + if (QEMU_DOMAIN_NETWORK_PRIVATE(net)->slirp)
> + return true;
> +
> + if (net->type == VIR_DOMAIN_NET_TYPE_USER &&
> + net->backend.type == VIR_DOMAIN_NET_BACKEND_PASST)
> + return true;
> + }
> +
> for (i = 0; i < def->ntpms; i++) {
> if (def->tpms[i]->type == VIR_DOMAIN_TPM_TYPE_EMULATOR)
> return true;
next prev parent reply other threads:[~2023-02-15 7:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 11:51 [PATCH 0/4] qemu_passt: Don't let passt fork off Michal Privoznik
2023-02-14 11:51 ` [PATCH 1/4] Revert "qemu: allow passt to self-daemonize" Michal Privoznik
2023-02-15 7:06 ` Laine Stump
2023-02-14 11:51 ` [PATCH 2/4] qemu_extdevice: Make qemuExtDevicesHasDevice() check def->nets Michal Privoznik
2023-02-15 7:22 ` Laine Stump [this message]
2023-02-15 15:23 ` Michal Prívozník
2023-02-14 11:51 ` [PATCH 3/4] qemu_passt: Report error when getting passt PID failed Michal Privoznik
2023-02-15 7:24 ` Laine Stump
2023-02-14 11:51 ` [PATCH 4/4] qemu_passt: Don't let passt fork off Michal Privoznik
2023-02-14 13:02 ` Stefano Brivio
2023-02-14 15:30 ` Michal Prívozník
2023-02-14 16:22 ` Stefano Brivio
2023-02-15 7:50 ` Laine Stump
2023-02-15 17:04 ` Michal Prívozník
2023-02-15 18:22 ` Laine Stump
2023-02-15 18:30 ` Stefano Brivio
2023-02-16 8:52 ` Michal Prívozník
2023-02-16 9:07 ` Peter Krempa
2023-02-16 9:15 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aca8d4f3-1571-76c9-94dc-89cf2030cec0@redhat.com \
--to=laine@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mprivozn@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).