From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=U8TYTKqg; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id A67515A0262 for ; Tue, 07 Apr 2026 02:54:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1775523266; bh=xeFMTXePiRlQsLbOdSDg42NEwM3RxinW8aFpTrpcrYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U8TYTKqg/4poOEieypMG5OKxINadohY0LiYwfOlgsLJ5aLmO7hyQmkthtB8GL9mZV 60cEleEUTBUfRJh9cnnQPKfN15NaBZFnAB7oSHGL/PKhPnT5OjgYrbmIilbomuNJvX YtG3Po3yBUDRy/Ww31EtNQUefQz/95EPDD8mgAKPXQI0TwaCN7AabKE5fjB8/D0TqV t6H0L3vb0aM6GLXhPbME0asWcmmV7KXMwhJ1g4ZP6PDvkn6j/SqnpS6CxP864vBtvb mwalZa+mhZrp8Atl0a9cu3wcvprGfwerdJHuw16cdn+tDjnf/1AXzitpVZ3btd2fEv JCFqY3wwbqo5A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fqSQB2y1kz4wKV; Tue, 07 Apr 2026 10:54:26 +1000 (AEST) Date: Tue, 7 Apr 2026 10:46:56 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v1 2/2] tap, tcp, udp: Use rate-limited logging Message-ID: References: <20260401182910.669164-1-anskuma@redhat.com> <20260406101247.3d9b3086@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o2sCOniYob5np62o" Content-Disposition: inline In-Reply-To: <20260406101247.3d9b3086@elisabeth> Message-ID-Hash: IQJP4Z6DV3F3H55XRC72KVEKDTQZFQTC X-Message-ID-Hash: IQJP4Z6DV3F3H55XRC72KVEKDTQZFQTC X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Anshu Kumari , passt-dev@passt.top, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --o2sCOniYob5np62o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 06, 2026 at 10:12:48AM +0200, Stefano Brivio wrote: > On Wed, 1 Apr 2026 23:59:10 +0530 > Anshu Kumari wrote: >=20 > > Now that rate-limited logging macros are available, promote several > > debug messages to higher severity levels. These messages were > > previously kept at debug to prevent guests from flooding host > > logs, but with rate limiting they can safely be made visible in > > normal operation. > >=20 > > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead > > of its ad-hoc rate limiting, and promote the guest MAC address change > > message to info level. > >=20 > > In tcp.c, promote the invalid TCP SYN endpoint message to warn level. > >=20 > > In udp.c and udp_flow.c, promote flow allocation failures and dropped > > datagram messages to warn level, and rate-limit the unrecoverable > > socket error message. > >=20 > > Link: https://bugs.passt.top/show_bug.cgi?id=3D134 >=20 > By the way of this ticket, I forgot to mention that as it came up after > a discussion on a series by Volker (Volker Diels-Grabsch ), > it would be nice to Cc: him on the next version of this patch. >=20 > > Signed-off-by: Anshu Kumari > > --- > >=20 > > - Inside udp.c > > - David: should this be changed to warn_ratelimit? I am not sure about = it > > debug("%s error on UDP socket %i: %s", > > str_ee_origin(ee), s, strerror_(ee->ee_errno)); >=20 > I had a closer look, and it looks like we're hitting that part for any > error reported via ICMP that can be associated to a given UDP socket, so > I would say it's part of our regular networking operation, and we > should keep it as debug(). Thinking about this again, I agree. Looking at this another way, the error is already being reported at the right level: as an ICMP message to the guest. At the passt level this might be useful for debugging, hence debug() but doesn't represent anything out of the ordinary or worrying. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --o2sCOniYob5np62o Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnUU/EACgkQzQJF27ox 2GetAQ//XpPtNGLZzjwYtqlUfVAfQBqwUCyKNbYLJFNz2kqRwRXRVm89aOXo+voU gkoJrX5OVOnenkCtWAWDz/HR6z6zRicApw2ycHExMpjsJcaWhPAWema9/TFiN8jF pn93k84Bnh3GB4pMsfMMBlW2Boct7TYwNpY5cNCzICeNzQ4JbG5pUYUUvZ6NW2z2 KQjYKC4h50ZelJ9sUhuhO25eteZcDvZqeO3q/QdaEqxlBemO2cNsqNrECk9FvnJT VxtZAMPvFwgB4DS/NPobrvW/4/l4t8UGefxyuFb3rgFsw04qvEMHlUc44drfiYe9 HnSI9tddf9j0QcLqupxCWxRzmOZ1xhMjy64lOWv4kyxNAdD7ZKOGmLlXzhZERlsX paSvEXKGZbNNjDGi8sF1g9NPe/jvUChlHNEqPyt6UAq9o7OTuiSgFuDsXgR7wisa gOUb+l4l4KKxuclWIf/t1I3eAt6+BXFsrGN42uzf7L7CB9MMNfkBxGoEaWswIrmf bCwtZw/7LyOfIGh4QuWAvq7PELcvy0f2JfCmNg5+6sl9HVfDzyf0ZX82YTUcKmFW sImm127bLpfXXOkUlmRyC+aJ/orF6DsLFQu3HxN9DkI3P6Zd0lFHzrvUPV9HT3vI KIPs1LZlg+8FLuIAuNsFnf4TeT3Enk+BZ0mprjj5vXp/bUFEr3Y= =3SW+ -----END PGP SIGNATURE----- --o2sCOniYob5np62o--