From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=eRglis8w; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 9D7295A0271 for ; Thu, 09 Apr 2026 02:48:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1775695681; bh=ZD/GwDc2N81q+UEJnXcqDyo61hKg3OSLhX0LrKnfCfI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eRglis8wGCSJLfByoxIiODX7V4r//Z/If0RW9mrcXMFr1P+yym27auyZvxoXfwh9D 6lp/cU6lgDmp/i4nFC3Jhv6LhP85hwslGd7T+5dYx1uYRbdj7qG6yK+86BMsFYIILj 8S7IN2LM4Exm7wssmO1jMaeRAd9JInMsXIVSkAFqU0lGPKnHq9j0/T6eMPvsVW0SRb HnMWSBglrTgJK/cEuP/4TPzZQ8cWfQvTV0Ox0seTpAW7g97FwR267eUG8vVCKJjOav GhRORK+SCW1i8HfKNMV7faV9UleseeMHCGYu9YS22k27c93iZiMFm5fRZWzJHL1rOi IT6cnkZeGkBQQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4frh9s26Q0z4wTg; Thu, 09 Apr 2026 10:48:01 +1000 (AEST) Date: Thu, 9 Apr 2026 10:10:36 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 11/18] fwd: Improve error handling in fwd_rule_add() Message-ID: References: <20260407031630.2457081-1-david@gibson.dropbear.id.au> <20260407031630.2457081-12-david@gibson.dropbear.id.au> <20260408234006.45f6365e@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VA+5hwKuwkP8yf5E" Content-Disposition: inline In-Reply-To: <20260408234006.45f6365e@elisabeth> Message-ID-Hash: 6CGBFPISKKDKAKNJJEHZW6VMFKESR3J6 X-Message-ID-Hash: 6CGBFPISKKDKAKNJJEHZW6VMFKESR3J6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --VA+5hwKuwkP8yf5E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 08, 2026 at 11:40:07PM +0200, Stefano Brivio wrote: > On Tue, 7 Apr 2026 13:16:23 +1000 > David Gibson wrote: >=20 > > fwd_rule_add() sanity checks the given rule, however all errors are fat= al: > > either they're assert()s in the case of things that callers should have > > already verified, or die()s if we run out of space for the new rule. > >=20 > > This won't suffice any more when we allow rule updates from a configura= iton >=20 > Nit, as I guess you'll respin: configuration. Oops, fixed. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --VA+5hwKuwkP8yf5E Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnW7m0ACgkQzQJF27ox 2Gfa5A//R7bCv91d7OEEZOL7tG1CswY8mcfqoYthhhGbBn1bAsZNzeVPmKHRP+lO 4TzUwZxxTQm02leGHqjQzbu6RG+6OE0PBgAEL7t/x/H97bBlO8ofk88i3/UhkfYC U3umlnsuyc5HMIxhknGJZ5ATN9rSRwESZUhirog7v9dNEtEBP6aEAE2JWioD+K60 4aaJX4u7rNp11z7k7IUVJU1WKDmT6JQZeLtyyhpVV2t7OlTjfapXkPOFpazkVIuT wZNb6yN5g2w6fkwfG2pmTxqhnLDD+cEaGwz1Ei6/KLYwHkfqibKADRElpYUDb4UI Ex1in6LfIe0PsbMhw72snicWdEwFC3s3ZyIg1eZ+XpZ63RJ0U3+2S79PM38Rzccu E50JsZliZyzW+kwN3OmRwMrfAK/Uug13G5gyvF2fnPceo1vGpliravY9TicWFtAL iI4hmXbwVZkSBlDO1LpiIJBMVfgeQywY6gJ65mdGLnmvfzLnO/G0Redn9o1fPBNs GI+CbXXIuFb//snXphkKVA35vEM2iDuS6mbHR4GdJdqpTaimQgIchpgRJ0FPd9HV y1wevX/JfGKMSJBc0aRb+yDzkWKVlmFZY4iV/P6+JI5UDevWHJueoR3bE5+NNLWt G+YjeQPJTKGocBkUANoEN1aejuX5YhebTLji7HWqlqt8OEulWC8= =IcpE -----END PGP SIGNATURE----- --VA+5hwKuwkP8yf5E--