From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z5fx8sSr; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5C8055A004E for ; Wed, 20 Nov 2024 13:40:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732106454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=03y9folzMCYMpfKfXzrJDpw6FXxgdQ4DVM/vbTFelRo=; b=Z5fx8sSr9FhyJcjWQQiHUhLUgbGJ4KiWIjKHwCQmwOG6eIRjVMP3/pX3Fzs8a2xkMtNoH2 xxSakDqHu9Gtl88dkXHhxgn4H+PFxTrmzsHOu8vpG0xFHFVj1iMAQyQ8nJa1pMYQGojJE6 XZSN+iRvbHTxKmgNuWq/MObOhIgZ7XM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-T-zOCpaFNC2pg03hU98Kog-1; Wed, 20 Nov 2024 07:40:52 -0500 X-MC-Unique: T-zOCpaFNC2pg03hU98Kog-1 X-Mimecast-MFC-AGG-ID: T-zOCpaFNC2pg03hU98Kog Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43157cff1d1so39582085e9.2 for ; Wed, 20 Nov 2024 04:40:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732106451; x=1732711251; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=03y9folzMCYMpfKfXzrJDpw6FXxgdQ4DVM/vbTFelRo=; b=S2dI8KTo1tPYR8cAJKSItOkeB355DycNaLxuYhbLpjTY4TMGyqvdv8jA5YxzalG9qT 3epO7Y/sWTpE/u+vKqdQAMLKLLqWx0PaE3h/FfXa6sAppUt3gf9WKm6SiGAES77Gqd5V p3IDEJaK3rFVsW0E7O8mR/GFNbHEU/yNrx/5Y5RJvur2lWJoZa856DqniqIEsx8chJKq IWWnW0hSw9XOaYPDjhNMjDNtT+Sl1fgXdYyS4j5FvCmyA/dmEMT1WJaQxLktRw7rLO1y LXslolKpSNfX4hlm2yKwByQNB39h1NRcFM+fLCOVVfeZ01IpkdLhlnbDEljjJuA34MbA 492A== X-Gm-Message-State: AOJu0YwAp9OV3HcU/WS8HGMDQuWcTVsnMWxtA6RRmkA2OAqyTn27ZzHv aNZjbmbZ97RVyqbDFLFAmVWuRcrPkvh5pbtmsaySOOft77uEFqqzgyW5SRsGFcuRfmt/uZFR/Km NTvJuDBRfqxEjdc/XECXiiA2MfRv/vj8RiGP+XMSjAy5HZyhf+j2ieMkUXw== X-Received: by 2002:a05:600c:3ba6:b0:431:5aea:969 with SMTP id 5b1f17b1804b1-433489b24bcmr23030475e9.8.1732106451525; Wed, 20 Nov 2024 04:40:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5nSFq08YjsLOHNYbkp3S9XZXCTTwTxUGuk+nOKTEW4WAMs+OM+3E6rXoEggyJLZm0O/glHw== X-Received: by 2002:a05:600c:3ba6:b0:431:5aea:969 with SMTP id 5b1f17b1804b1-433489b24bcmr23030245e9.8.1732106451034; Wed, 20 Nov 2024 04:40:51 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b01e1046sm18765345e9.4.2024.11.20.04.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Nov 2024 04:40:50 -0800 (PST) Message-ID: Date: Wed, 20 Nov 2024 13:40:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 07/10] vhost-user: add vhost-user To: David Gibson References: <20241119151037.2196652-1-lvivier@redhat.com> <20241119151037.2196652-8-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pdIuFT6g7tMGOhc80E4iH48u3-tKTJtVW4kMnOXb-M8_1732106452 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: ITEJY4FEDPLFFEGKEDKH4E3H55FPZWOV X-Message-ID-Hash: ITEJY4FEDPLFFEGKEDKH4E3H55FPZWOV X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/11/2024 04:33, David Gibson wrote: >> + vu_set_vnethdr(vdev, flags_elem[0].in_sg[0].iov_base, 1); >> + >> + eh = vu_eth(flags_elem[0].in_sg[0].iov_base); >> + >> + memcpy(eh->h_dest, c->guest_mac, sizeof(eh->h_dest)); >> + memcpy(eh->h_source, c->our_tap_mac, sizeof(eh->h_source)); >> + >> + if (CONN_V4(conn)) { >> + struct tcp_payload_t *payload; >> + struct iphdr *iph; >> + uint32_t seq; >> + >> + eh->h_proto = htons(ETH_P_IP); >> + >> + iph = vu_ip(flags_elem[0].in_sg[0].iov_base); >> + *iph = (struct iphdr)L2_BUF_IP4_INIT(IPPROTO_TCP); >> + >> + payload = vu_payloadv4(flags_elem[0].in_sg[0].iov_base); >> + memset(&payload->th, 0, sizeof(payload->th)); >> + payload->th.doff = offsetof(struct tcp_payload_t, data) / 4; >> + payload->th.ack = 1; >> + >> + seq = conn->seq_to_tap; >> + ret = tcp_prepare_flags(c, conn, flags, &payload->th, >> + (struct tcp_syn_opts *)payload->data, >> + &optlen); >> + if (ret <= 0) { >> + vu_queue_rewind(vq, 1); >> + return ret; >> + } >> + >> + l4len = tcp_fill_headers4(conn, NULL, iph, payload, optlen, >> + NULL, seq, true); >> + l2len = sizeof(*iph); > Much of the above duplicates tcp_vu_prepare(). Any chance you could > call into it instead? I tried but tcp_fill_headersX() needs the length computed in tcp_prepare_flags() but tcp_prepare_flags() needs to be after tcp_vu_prepare() because tcp_vu_prepare() resets the TCP header and tcp_prepare_flags() updates it with the flags. tcp_prepare_flags() should be called in the middle of tcp_vu_prepare(). It's really simpler to duplicate the code of tcp_vu_prepare() in tcp_vu_send_flag() rather than to call tcp_vu_prepare() from tcp_vu_send_flag(). Thanks, Laurent