From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=KCJFJMrS; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 4594C5A0265 for ; Thu, 16 Apr 2026 03:24:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1776302649; bh=ycrQYe8tFrLWVGQ4hvvvjoP2sFVLwkXXqryV+eIgFtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KCJFJMrSvIn31KXG0TJIuLzfrn/cvwZhnHRlKiMrdgktpT9S5qJTrV77vV5frdopk OTd6z470G5vIM4SrihgCok646NV4hh1//3qK7rwe72kfAfcfh2K7rsenYfRYuQtCCh EkzmpvLYLe/ba+FZH4+cAw91ej3tkFMlu75Q4P2CbhhcVRoDYlP8kQmp4PIRBDN57X EKyNWjlEP+M+MBDMic9ZXTUF7acXX1UBgcyy32gbgbv0fSXQf35kgfXzDfqxPsY9dd 4CNzOc6/oQi8Mth0/xF1njvFdND3BrE0cfQyDSyhwSQob41RGRa0Gajj2fkcGLAh2F +6wgmezONe7Lg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fx0fK3QK3z4wBF; Thu, 16 Apr 2026 11:24:09 +1000 (AEST) Date: Thu, 16 Apr 2026 11:24:04 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3] tap, tcp, udp: Use rate-limited logging Message-ID: References: <20260410103737.1642986-1-anskuma@redhat.com> <20260415213836.418df481@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EuC1qQ7TrnhuoHcd" Content-Disposition: inline In-Reply-To: <20260415213836.418df481@elisabeth> Message-ID-Hash: SGBHOZSOWOLITUXFA5GU5TZ6WDARG3RD X-Message-ID-Hash: SGBHOZSOWOLITUXFA5GU5TZ6WDARG3RD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Anshu Kumari , passt-dev@passt.top, v@njh.eu, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --EuC1qQ7TrnhuoHcd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 15, 2026 at 09:38:36PM +0200, Stefano Brivio wrote: > On Mon, 13 Apr 2026 16:25:52 +1000 > David Gibson wrote: >=20 > > On Fri, Apr 10, 2026 at 04:07:37PM +0530, Anshu Kumari wrote: > > > Now that rate-limited logging macros are available, promote several > > > debug messages to higher severity levels. These messages were > > > previously kept at debug to prevent guests from flooding host > > > logs, but with rate limiting they can safely be made visible in > > > normal operation. > > >=20 > > > In tap.c, refactor tap4_is_fragment() to use warn_ratelimit() instead > > > of its ad-hoc rate limiting, and promote the guest MAC address change > > > message to info level. > > >=20 > > > In tcp.c, promote the invalid TCP SYN endpoint message to warn level. > > >=20 > > > In udp.c, promote dropped datagram messages to warn level, and > > > rate-limit the unrecoverable socket error message. > > >=20 > > > In udp_flow.c, promote flow allocation failures to err_ratelimit. > > >=20 > > > Link: https://bugs.passt.top/show_bug.cgi?id=3D134 > > > Signed-off-by: Anshu Kumari =20 > >=20 > > Reviewed-by: David Gibson > >=20 > > > --- > > > v3: > > > - Promote flow allocation failures to err_ratelimit from > > > warn_ratelimit. =20 > >=20 > > Nit: doesn't affect the validity of the patch itself, but I'd consider > > "promotion" in this context as going from a less severe to more severe > > error level. So going from 'err' to 'warn' is a demotion, not a > > promotion. >=20 > Wait but this is now going _from_ 'warn' _to_ 'err', so it's indeed a > promotion, isn't it? Oh, sorry, my mistake. I misread "to x from y" as "from x to y". --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --EuC1qQ7TrnhuoHcd Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmngOjMACgkQzQJF27ox 2GfkRA/9Fp5gHfBNxx1ELLFRRSSkzlUP32H8eS569QYwMRbH4oSINzsL5Hw3OVcA sAwDq5OgnIdxIy2b51SuBiWSCvKoOXFdYqDU1eJFwtv+x3F7cZnx9Enw2ivUNqav r6KL+kjaBWeiwppZeAoTnQaWqjecKxn+5yWR/wW/bQ7fX3mXwPjFIKDO0xjRUhW+ o+fcOLFgUyPDjTEeaC/5eYDdd0jeCvkEUlHY/ZA9h7QViR1yWDgj2c6VcspRbp2a JdPxyr4abWrA95ObZZ/MNJtBWcCUblWr+DEC5AaZ0B1belJvA/uqwKv5kV7cPYmo yP2z0tB3SPm4B5bGT3h2q5hl97yLKXx007yLBNT7ChnlmrmkuZNA3L8n1l5mB2Ie QU1NoZkF6RAbKdwYzrPPtIEobUfP8HAsQCJQ4jluI1E5xrluM+wmAZbfPEOobRNw 1+aCiP3vmty/8CFhtdAWfJo5WW2gTMOqJKQiA0Pkwc9QWp+KeYyDx9rkva+s1TR1 1JJyQ/jGJL8aJLX//e8mvIbQxvLB/UTsZbnXo4UJgcHEiwyP7t6TF1oLCNqNpvKR 5dfzgfyQSPX0ohLL7GfyygbURf5nxTkj+I6LRFapWaxDq0aUo18Gl0Tjy+UE7Efn fRZO5BVKGHYs3lW7/3c6vppiJnI5tOgavOOxZ8jVMVoP7mU6VuI= =Y88Z -----END PGP SIGNATURE----- --EuC1qQ7TrnhuoHcd--