From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=JqUqg407; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 8EFE15A0265 for ; Tue, 21 Apr 2026 02:05:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1776729953; bh=TWPlJ3TSXTssw3QdWf9GXYf6gM/FIJtPkdlM3892w8I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JqUqg407jdmWAxu/SntgWVPTBRp2J9RhsWtF1i7vtlXkTTkJMrBBsCX+qyb324TMz J7U7HTSOGL7oRrxn0MmbWYw6FpXsS5pfS0i0KYQyhilD9MsoOvo0ehjMD1gNfgXtNt Dmexao7XHawI17OmzOK/JK6T0CIP7X3aKLev1j2o+ajq+jPk6GOZerlc1pHnNBDy6H VPGJUF+ELEh6suq9N7tlFGHGS7UR/9weXC43L9NBFmxiSn/zZ9GAsH4OHAQ793SP2y fi2vPNLkoYwIZbA5Q7JV0QW100UHISUmwzvHkhgr1Xc+FsmGzu+PyBNZVKsGPHH6aR pVBblbzNxRQkA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g02gj3hlbz4wB4; Tue, 21 Apr 2026 10:05:53 +1000 (AEST) Date: Tue, 21 Apr 2026 10:05:27 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 00/11] Rework forwarding option parsing Message-ID: References: <20260417050520.102247-1-david@gibson.dropbear.id.au> <20260421003326.64a03015@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aOaRFQ5/InqQTUiP" Content-Disposition: inline In-Reply-To: <20260421003326.64a03015@elisabeth> Message-ID-Hash: ZHIJVMJP3A2C5BFZQQ6JGVFLSTNPSCHI X-Message-ID-Hash: ZHIJVMJP3A2C5BFZQQ6JGVFLSTNPSCHI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --aOaRFQ5/InqQTUiP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 21, 2026 at 12:33:27AM +0200, Stefano Brivio wrote: > On Fri, 17 Apr 2026 15:05:09 +1000 > David Gibson wrote: >=20 > > This series makes a number of significant reworks to how we process > > forwarding options (-t, -u, -T and -U) in passt & pasta. This is > > largely motivated by moving towards being able to share this code with > > a configuration update tool. However, along the way it also enables > > some forwarding configurations that were technically possible with the > > forwarding table but couldn't be specified on the command line, in > > particular bug 180. > >=20 > > There is still a bunch of work needed to make the parsing code truly > > shareable with pesto, but this is a solid start. > >=20 > > v3: > > * Removed already merged patches > > * Further revisions based on Stefano's review, including > > * Improved example text in manpage and usage > > * More flexible rule dumping > > * Re-integrated conflict checking in fwd_rule_add() >=20 > Applied up to 6/11, with the nit in 3/11 reported by Laurent ("double > space between ) and {") fixed. I'm not seeing 5/11 & 6/11 in your tree yet. Did you forget to do a push? >=20 > The rest looks good to me, minus pending comments (all from Laurent). >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --aOaRFQ5/InqQTUiP Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnmvzgACgkQzQJF27ox 2Gfbgw/+LFCs3WuoVPRMX7lajF8i6JmtLf6R3SlGQLNlfCAT6pMCC3XhHZ665+99 ieyZdt9HQjKXDdntEyIPkG5hnU5s5CKC1alwnk772otwz6/XvT6Ul7+WLSS1TYvz 4D1hr/ibNiREJb4yKU3ML/bJLwzZyegT49fPOcGBXA0c4g4YqS2i9YYlgp7Zw/zE 4P9qRg3hRrbTzlPzxQJhT6+ZaY+Nt8232YaGVpu+lDnl661j/UoFdpZ99bC1u0RK daU0Z3nhJwP8ImPV1zo9WkKXaMmCg9Cs8U68IFxIn9oPeQ6DGv5CDB6Bsg8na8J2 HKLqwwvFkRc3CQsTqP+q68VM41nH0Q6uZvwE2x5K+DTJnTFIL3KyJL2gQ6OBpNLN WerXjpBIfeuBI6zzpSnAIglVMCkM195ZZ+r0szcCg53qSd8+SnJexjbWHVLapnl8 26o7wJ1YDkWO/ZvufBYdB9yOhNpFPH8Y1XJ8Hd2rFOXpIZKA0bdc4nicrlBfRUJK RPxMp6QITE7ky2W4InLlV/C9y0Y7EOHwrlCrxUIzC+G/S2svnaN6Tq1WtKMSy/p/ 80xeOv9jhTAgkdr/s8XOAa/XxB6Py6P1sNMZentYoNyWRQMzTQOlUuGXAYs1KE22 CwgMqP6ADcOEYOUWZ59/NkJgMkNCRV6xov4A24r9ErN+MNVu7V4= =qlpD -----END PGP SIGNATURE----- --aOaRFQ5/InqQTUiP--