From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=bQGDndJ5; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 308605A0269 for ; Tue, 21 Apr 2026 05:04:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1776740645; bh=qBGzrZSr2Ybjcc+W69d+/ZEKOp1kF9wwemVqtyyAncE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=bQGDndJ5J6/KOS82/J6fIuBUeF607N1f1QrKxRuClDWEmBnBGgj8UBIt9tTvRIXXs U+vfxLIVk9xJzN7+m3Av+matlG37oyVpfdeR4PTx8fJktSAAgN6h2f8JQElK63r5Uw zKNiDcu4zLMguOvi6Dbe3E8flKLAc0Bx/FfFlEN+6T5L2JCaTvR3x+m/o+c+xDc4KW aLsGpJyJHW4rcybi9CKB36M2HQcFpmNoKn+Mf0uDoIslAqyieeHUns6WEipczX+spi wLSLT3U0DIQyL/n+c7heBRnFyLxBlXUZaSROdfVTwtEEf25zDT9Sh/9eP3OZoYfBGP 27KH+08ZUOUxg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g06dK0cmCz4w26; Tue, 21 Apr 2026 13:04:05 +1000 (AEST) Date: Tue, 21 Apr 2026 13:03:59 +1000 From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: Re: [PATCH 00/13] Improvements to static checker invocation Message-ID: References: <20260421024344.1379633-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aMf8VSJTSm5BtzKx" Content-Disposition: inline In-Reply-To: <20260421024344.1379633-1-david@gibson.dropbear.id.au> Message-ID-Hash: 4SNO5JQKMSPFKWAI6BSG23ZU6S2EBKB3 X-Message-ID-Hash: 4SNO5JQKMSPFKWAI6BSG23ZU6S2EBKB3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --aMf8VSJTSm5BtzKx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 21, 2026 at 12:43:31PM +1000, David Gibson wrote: > While working on pesto, I ran into a number of awkward errors with the > static checkers. This series reworks the invocation of the checkers > in a way that will let us deal with that. As a bonus, it also gives > us static checking for passt-repair and qrap. It also makes a few > other cleanups to the Makefile that seemed natural along the way. Sorry, realised 4/13 introduced a test failure due to a bad interaction with test/build/build.py. New spin coming shortly. >=20 > David Gibson (13): > Makefile: Use make variables for static checker configuration > cppcheck: Split out essential defines into a BASE_CPPFLAGS variable > Makefile: Remove preprocessor flags from $(FLAGS) > Makefile: Remove non-standard $(FLAGS) variable > Makefile: Make conditional definition of $(BIN) clearer > Makefile: Use common binary compilation rule > Makefile: Remove unhelpful $(HEADERS) variable > Makefile: Add header dependencies for secondary binaries > Makefile: Split static checker targets > passt-repair: Split out inotify handling to its own function > passt-repair: Simplify construction of Unix path from inotify > passt-repair: Run static checkers > qrap: Run static checkers >=20 > Makefile | 106 ++++++++++++++++++------------ > linux_dep.h | 2 +- > passt-repair.c | 171 +++++++++++++++++++++++++++---------------------- > qrap.c | 42 +++++++----- > 4 files changed, 188 insertions(+), 133 deletions(-) >=20 > --=20 > 2.53.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --aMf8VSJTSm5BtzKx Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnm6R4ACgkQzQJF27ox 2Gew5A/+OmO/DaJVzBSO8Gs/s/TTyB+Kxc2XFXRuZR/NgiT+rRaaBHyfw9ZBRb02 /5LTprpDQ7WcUJ8XWhn4UNaVtEZLAeh58+b5d77Crc60Hq5C2Va/YJ+P4rwynEJ+ tVq27zV6FNfusVxF9fu3EqBlr+OSM+m3UVKn6Tiublo1IigawVLyk4O3+AqgPmLX /z54R8HPJBxBAlCZLQ5Z4Md9B2cibuX9thc244+PxGdw4+dUohS/XUgCB70O0x4B avn8OZGE14eBdVYHGuChbDB0/73N1iFTyoUQnqTAW/biqbAp21Yo4jW6emx1C6wg dvX64wGUGGAexR2KNga0CRZPtAzIE4fRZoCRp3QY2N1TpzMmPITBfXWqXogoeU7V qaK6JdQ4Qt0WdToBLxO7rQlRkDk6wp7vpvGEa2iNJaFkBR82L6F7o2p+bRYXfT7t bxHEw0eaD3nCCBBQEgVUHUwMBusWnDlkZ4p15bbm6dSujhG0FMZGiG7pMV2Y0cMT w/PN5CGXDq4macZivCtsMXzY+RRLaOqcz7P2j3dpmypmFMreyvLPmWYiP2R8Luou vK1N05+AyUWOem7zzzuuSCrTY/zgRJ9znxaFmneHtuCGENbHYtaUoFY2JRApbZ96 4His1whZiAsz4CWOn/0Dc1bF/EftBJJ2S2HC598eM1diRpi8VLs= =uol/ -----END PGP SIGNATURE----- --aMf8VSJTSm5BtzKx--