From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=cvynqCpc; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6B8A45A026D for ; Wed, 29 Apr 2026 06:47:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1777438023; bh=s2eGfdDNKCEMsLj6w6A2t+v84N1dy21k7d2w1FHmG70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cvynqCpcevrcMfbdBIYSdlxzRohxRrCqQTrZdaHeMCwDumclYDS9dfsg/xPTSxvSd 3fSL04q3OnTTuf96pJsRlOUq2gLpH/7N3k1RZONK90mdSmpO2x1FJN2QA8+m0nlW9o 1AnYTC/yFxBBgfO86xE7ePcrMdoh1voXCLFtWkW1SFuXqHQ3bATH8npD/LRR5056Jq Qif/6bHlYuOZkQi2vg2Wa0sdlANLGGUKKy8x7w2tJuyWJ6el0nQarPjxg6CnOXpjI3 jXcwX5eqH2W18okLhT2yLptHgIyIYyrgPOXQeYYJuZDx1+QBnMCMiqiXKveT8N5Auo rQXxBZ20e9gLw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g54XR4jqrz4wpK; Wed, 29 Apr 2026 14:47:03 +1000 (AEST) Date: Wed, 29 Apr 2026 13:48:47 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 13/13] qrap: Run static checkers Message-ID: References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-14-david@gibson.dropbear.id.au> <20260428091736.5239794b@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="//2PbsY6Ei3LaXXt" Content-Disposition: inline In-Reply-To: <20260428091736.5239794b@elisabeth> Message-ID-Hash: AY5ZEZ7NFXQGZLNMBNE2FJI2HFFL6C56 X-Message-ID-Hash: AY5ZEZ7NFXQGZLNMBNE2FJI2HFFL6C56 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --//2PbsY6Ei3LaXXt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 28, 2026 at 09:17:38AM +0200, Stefano Brivio wrote: > On Tue, 21 Apr 2026 13:23:38 +1000 > David Gibson wrote: >=20 > > Run the static checkers on qrap as well as on passt-repair and passt. = This > > shows a number of minor warnings, which we fix. >=20 > This is actually for qrap only, so I would drop it. See also > 8346216c9adf ("Makefile: Simplify exclusion of qrap from static checks") = and > 988a4d75f894 ("Makefile: Exclude qrap.c from clang-tidy checks") Ah, yeah, leftover comment from an earlier draft that handled qrap and passt-repair in the same patch. > It's not really something we maintain and the next commit touching qrap > should really remove the whole thing instead. The "soon" in > 988a4d75f894 was almost two years ago. >=20 > My worry is that if we enable static checkers here we risk having to > waste time on warnings in the near future. Yeah, that's fair. Let's drop this one. >=20 > Other than this and the comment to 4/13 the series looks good to me, > and I'm basing v6 of "RFC: Dynamic configuration update implementation" > on it. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --//2PbsY6Ei3LaXXt Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmnxf5kACgkQzQJF27ox 2Gc7VQ//Vi5zppen53o4K+MdKESb5ebhLJJUxUUiDe+yB08aE6ktYUZihLUW1YdG 2GQxx9gbGq7Na1lLVfUse+JM7fqbOgapjUtr0JRV4yz5lSWY48/tdDI4GCtc9Iz2 AUv9IB5t6n+jUJQnORlYHbyKrLqEzhG93H4GFr/rvKC8PRpQefTAj4n6cRdEhRfg +6DalpG2L/wgAvIsMbMs/SyYgkSswwERAbDFl5cyncZRf6iQH9OXfgkqdkGMfOHU +Esp2BT4vkYs5vX78f7diA69qs75PDX1vbIJxgkWRwPLdBzZfghrZPYVWF34mOIx p+DCswzDCdUUDYiziO3v9VTmUE62cXhLWhT1bdkMd0Q6kGtEzTz+t6e3s5eLBn1x AlYqpP4dE+7iSZ2Y6s0HQyfpyFtTmPF18O2Pg/Lwl87xzJ6qA8Ng4Qoczp8cRpGJ qjIqoyFlOm7sgtMsIKoR9erJHO60ZAbd28S5oGtjqciNP/u2kiGGfeGJWHTzZYU4 O+UE7H/+uWDitHotichY9ybcpnXWw5KTyvu3+TxQzM9oUzQ0bEFPA60fy2gj4Mt4 i4HMworRiIVOMkdfCoHcrBQZpdJCJauwFL6SWzfz5158vMRlFvTQJX17rrpBVimf K78pXMT6xj8kFWh9PJxyyp4blcqGjQlBwZmXoRze096XCX4EDvo= =aROs -----END PGP SIGNATURE----- --//2PbsY6Ei3LaXXt--