From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ph4xYdGI; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 0BE1F5A0271 for ; Wed, 11 Mar 2026 14:06:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773234362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xGwVaGWJZRIgz8Ru6x7vETW+edN1wygJYBG3oNWo/pw=; b=Ph4xYdGIVlbGXR/zEXyOC5pzTfz0H6+P7yfvGPj8ZNFfS5OKOyoHl9r6b5ZrsI/XigcXZz wKpPFWZBSRLOvvj5FTSB4V2Nz6JIu+1lH49CcqDylhCohc0w9Uh9t8lNSKj+0knPl+PvSt 7pV7RbEYjyr5nKwdwLelSzoxmIpE4ik= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-Oib_AYKMOBmoiOzJ4iJBZw-1; Wed, 11 Mar 2026 09:06:01 -0400 X-MC-Unique: Oib_AYKMOBmoiOzJ4iJBZw-1 X-Mimecast-MFC-AGG-ID: Oib_AYKMOBmoiOzJ4iJBZw_1773234360 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4853b00f9f5so28797755e9.2 for ; Wed, 11 Mar 2026 06:06:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773234360; x=1773839160; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xGwVaGWJZRIgz8Ru6x7vETW+edN1wygJYBG3oNWo/pw=; b=ioQ89B9H/rxAKcrt9v/ry3TtHlZ2mSWD6MmO3CMOHDoQVyrDCACpr9hWeL77Xx9yaF GODJcC3R9s/BuyR71BFfdngDdaBquOX71NDgnZZc2cDRxekRZk1z41uLC+UpygKOV401 2OugsOp/KlV7f2F6okZx04l7AfEC9WE4DS42cuBEGqmz23rfPCv9wjUmCzPbK3yN9mtO 5KXLg3f/aHGwyXpUhy/cfecy0o4yFMWvKjT7igpAmxRPNpqCdVmHySBmSJriTCJT8QPO w5ufw0gErVIEil9Qx56Y+5E42+xM4e0yAlPn8G1pG5GGphD0UFA9YCf5KRv0Q6qJ5l7N fudQ== X-Gm-Message-State: AOJu0YxzLCehj2/ugjXFuuaho+6kgRxsc7F2w4lrpwiXprFEQLuj/ndv OxfopSoJEr2/clvYRfTkbnQpuy/tUsNtJ0TuVuTmIXN99tJ6wT5GTpjFQEy65dHxJMhwAYY/dT+ EzgL1bnzxSN6f/NHSrH3o/lUgHr+o15WjOMZMNtMhV61PtrnSpHqF/w== X-Gm-Gg: ATEYQzyVslAQ3yEvVzwKhB5r3N73lc8fQbJFIsUmbiL10agnFcLlpAcHYaRe6TxDRqR i24Z6sICxlQ5C/HD5M89W9TIFh2o6VaT5KcrnFAtul4D+t2cT5Qh1Mk9Sx4x8Ggfpxpc0Yuxdlv qpkbUhKgKJSQ8Lyr4pHhM5oMa2rKCBGcToZjfv/tSlkdeiXGWAWISKUgbGUvUizpu/rrXekdL+G bGCayA5tMeTgidEjozB+4lI+CtF/Eb1teQ7HCsacg24Tp1JpFQ7dvgqIar5pwlYgFRURhGT/yWm kP85Amg1ZFg2kcrkUt2MiEFuUDbeBuGr/KzdyFzj48PaepwxzSaDBImyjZ1twZX1UZRwOn7uWc0 6oqhB0oauK6pszyR0VvrKiH+QzgXbN/mvU+laryT77AzmMPKSTPXOugcUACzEcyWzQQ== X-Received: by 2002:a05:600c:1d16:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-4854b0a40cfmr41053005e9.5.1773234359771; Wed, 11 Mar 2026 06:05:59 -0700 (PDT) X-Received: by 2002:a05:600c:1d16:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-4854b0a40cfmr41052335e9.5.1773234359063; Wed, 11 Mar 2026 06:05:59 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4326:a36e:a7cb:624b? ([2a01:e0a:e10:ef90:4326:a36e:a7cb:624b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f81aca65sm7619750f8f.17.2026.03.11.06.05.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 06:05:58 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 14:05:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/12] vhost-user,udp: Use 2 iovec entries per element To: David Gibson References: <20260227140330.2216753-1-lvivier@redhat.com> <20260227140330.2216753-13-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 27iafl48P9Wq6gkgwR6rREgXpUh2naM35g6ukOq7RlU_1773234360 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 4FURAAEWKZZX3UQ5P3AAXK6TAU3SY35O X-Message-ID-Hash: 4FURAAEWKZZX3UQ5P3AAXK6TAU3SY35O X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/2/26 02:03, David Gibson wrote: > On Fri, Feb 27, 2026 at 03:03:30PM +0100, Laurent Vivier wrote: >> iPXE places the vnet header in one virtqueue descriptor and the payload >> in another. When passt maps these descriptors, it needs two iovecs per >> virtqueue element to handle this layout. >> >> Without this, passt crashes with: >> >> ASSERTION FAILED in virtqueue_map_desc (virtio.c:403): num_sg < max_num_sg >> >> Signed-off-by: Laurent Vivier > > Reviewed-by: David Gibson > > It looks like a reasonable short term fix for the specific iPXE > problem. > > Longer term, having a fixed 2 iovecs per element still seems fragile, > if we encounter some other occasionally-used guest side virtio driver > which splits its Tx buffers up in an even weirder way. It would be > nicer if we can actually take our cue from what the guest actually > gives us. I'm not sure how feasible that is, though. I agree with that. I'm going to rework this part to allocate a variable number of iovec per element. It will be cleaner and more correct. Thanks, Laurent