From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=Q0QMapyQ; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id CEB165A0265 for ; Wed, 06 May 2026 09:41:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778053298; bh=FJiOuJuSxzsyMY8ZBtza6gHfDzJVD+m6FqNumashbHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q0QMapyQa1dNXk31FLp4FTo/qGLkBaldebKUchKvpO9Pcx57230pCo4yVz8MGI1eo JgfrlVL+JHI51BLBFCM8ENcLQoSt2YZvWWuGfkIJgI4+IplUbjHZ+NQb5XK9ZyEWvP PBcai8mpQKIYYlaEWnX1X6Ro+3Otj2/2bB5hvQ8uqD34IdApE7Jf4QDCi/dGMrVQvW MsQgq/WX3a9BJBk/GzN+YV4hdQnvrfCCFBF+6R3JlnFBVmyxEaTLuHKTdwQtPQ7sxK W0FEv6g6PNqxsSN7cGJZzUu345YbAnFvS7ifsJf25o31QbTRkf5QPNtnEE3HxZO/Ju MHUI/cKhgQoAw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g9S4f49X7z4wJh; Wed, 06 May 2026 17:41:38 +1000 (AEST) Date: Wed, 6 May 2026 17:41:13 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v8 10/19] pesto, conf: Have pesto connect to passt and check versions Message-ID: References: <20260505234719.1437340-1-sbrivio@redhat.com> <20260505234719.1437340-11-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SqwxTzB5P+Eupy7h" Content-Disposition: inline In-Reply-To: Message-ID-Hash: VGS5TFSSNBTTED2QTKV2X6QMV2DLTBKA X-Message-ID-Hash: VGS5TFSSNBTTED2QTKV2X6QMV2DLTBKA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefano Brivio , passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --SqwxTzB5P+Eupy7h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2026 at 09:06:05AM +0200, Laurent Vivier wrote: > On 5/6/26 07:38, David Gibson wrote: > > On Wed, May 06, 2026 at 01:47:10AM +0200, Stefano Brivio wrote: > > > From: David Gibson > > >=20 > > > Start implementing pesto in earnest. Create a control/configuration > > > socket in passt. Have pesto connect to it and retrieve a server gree= ting > > > Perform some basic version checking. > > >=20 > > > Signed-off-by: David Gibson > > > [sbrivio: Avoid potential recursive calling between conf_accept() and > > > conf_close(), reported by clang-tidy] > >=20 > > Huh. For some reason that warning didn't trip for me. Although it's > > technically true they can mutually recurse, I believe they're both > > tail calls, so it shouldn't eat the stack. > >=20 > > > [sbrivio: In conf(), check we're not exceeding sizeof(c->control_path) > > > instead of sizeof(c->socket_path), and, in pesto's main(), print > > > argv[optind] instead of argv[1] to indicate an invalid socket path, > > > both reported by Jon Maloy] > > > [sbrivio: In pesto's main(), drop unnecessary newline from error > > > message, reported by Laurent] > > > [sbrivio: Don't use SOCK_NONBLOCK on accept4(), as that only applies > > > to the *new* file descriptor, which we don't want -- set O_NONBLOCK > > > on the listening file descriptor using fcntl()] > >=20 > > Making the new (accepted) socket non-blocking was the intended > > behaviour here. We also want non-blocking for the listening socket, > > but that was already done in feab892c7 ("tap, repair: Use > > SOCK_NONBLOCK and SOCK_CLOEXEC on Unix sockets"). >=20 > This patch has been dropped since v6 of the series. Oh, right. Sorry, I forgot it had been part of this series; thought it was already merged from an earlier series. What was the reason for dropping it? --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --SqwxTzB5P+Eupy7h Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmn68IwACgkQzQJF27ox 2GepWg/+IZB+6487Y2Wm+pM3EZeW92biyx27TJ3nfPvBFy0ja94J/mOnjjsmKJsh 9Wez6kJdEVXiim2oYF7DpStRVT1QkCDhKxk6cqUVeIAhmfLOFaUhRJMfeRnILwXT Hwlshx5e7yu/OOdBa3sRjZgZdaf/tPKfu8t5bvmnH8iGLsEhXEqQOJUMRGIYbuPY w1EtYLO2UcG1FKoZaI6+Dkeb5ifpTSgVpB6IpnxPA9NR/8zRjuwSlwJIW4Em41CF whqMGdRK+BZKcGkXbJKUvJUUCzHrNzQHKDLoP9/Ztg5Q+aT6FXmydqEbdz2UmpSb AcHOLdJXGyo9fcn9BgE5TK+sjPKUFOJA/+iJ0QnJA+vRzPvTEpBc6mLb514WTIC3 JGMQ6Am73IbjufEMVJ4Nm9CMydPH/6UlJuXQ60HVpz8m1LIGRLCkL4CEhwAu1nGN 1baAoZ6lJMhSuB4thdqtabppLZYVg0xIZdm8f53aqkg15JmyK84YUzscMs/d1e4d ScCGps+ecHkENvsFXA45V8FL8Z5tBTfiYhAjs3dAo4DLlP55H+2nP0ePejUzdWdI gQ+qDWMRBYemiamo5muRfvECDf/V79eEiIKIXmrGz1FPQABE8JmPvkwI6Rw4crGV 1cORS58Yt60UlEIU83MCycMK68+7zhj3cy33y1asUCqBX/Y5kqU= =frAa -----END PGP SIGNATURE----- --SqwxTzB5P+Eupy7h--