From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=YqZ9kdYO; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 0B9A95A0265 for ; Thu, 07 May 2026 05:22:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778124133; bh=dwqZW+9IBLHvhC5pfZjX0A1fYVvJoaViK9mJGlY40Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YqZ9kdYO5YBRgt1FUxChaV8ax0OclHEpeDhwvU2KZXRxtBEpAbIdghNDTexsoXUsC IHP1ZDOzjhpIOl4+yWy8H8lr+k/9a1KVptreirRcRliBFGvoYsLM4JW6E22dxLFVrS ZsOJRkWzd1oB18Tpe7AOg43pSE/H4ls0l4vLnNuLjA5mKZ4+OagykO6tLy15An4FIh zq9jgNDaJwDyClcp8bszCxz4cPU04MwF0dDVwGbokish+3dAH7leCI4A8GyUQof5yv tpYc3b4p1chopwtS4ohdmU0tPznfbOUgu0G8Idabq/S2CDhq92V4g6bR/mORQDPa1i 9BTTel9znETgQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4g9yGs4kLGz4wCt; Thu, 07 May 2026 13:22:13 +1000 (AEST) Date: Thu, 7 May 2026 13:18:33 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v11 19/23] pesto, conf, fwd_rule: Add options and modes to add, delete, clear rules Message-ID: References: <20260506213155.1886983-1-sbrivio@redhat.com> <20260506213155.1886983-20-sbrivio@redhat.com> <20260507041032.065058a1@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fq4hI32M4LKaotXx" Content-Disposition: inline In-Reply-To: <20260507041032.065058a1@elisabeth> Message-ID-Hash: FHQD7P66JYARCDHMODNOJX7DGJBBTRHU X-Message-ID-Hash: FHQD7P66JYARCDHMODNOJX7DGJBBTRHU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy , Laurent Vivier , Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --fq4hI32M4LKaotXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 07, 2026 at 04:10:33AM +0200, Stefano Brivio wrote: > On Thu, 7 May 2026 09:51:10 +1000 > David Gibson wrote: >=20 > > On Wed, May 06, 2026 at 11:31:51PM +0200, Stefano Brivio wrote: > > > Instead of just being able to add to the existing tables, implement > > > an explicit --clear option to replace them, which now becomes the > > > default behaviour, and implement explicit --add and --delete options > > > to maintain the table and add or delete specific ports. > > >=20 > > > The option --clear PIF forces the clearing of a table, instead. > > >=20 > > > These options can be combined arbitrarily and are handled as > > > sequential commands, as now described in pesto(1). > > >=20 > > > If no option is given before forwarding specifiers for a matching > > > table, the command line is interpreted as a replacement of the > > > existing rules. > > >=20 > > > To this end: > > >=20 > > > - there's no protocol change, as pesto is anyway sending updated > > > copies of the table > > >=20 > > > - the forwarding table functions now include a new fwd_rule_del(), > > > which deletes existing rule only if a matching one is found > > >=20 > > > - a trivial fwd_rule_clear() is factored out from the existing > > > conf_handler() implementation, so that it can be directly used > > > in pesto > > >=20 > > > The entry points for parsing of port specifiers now take an additional > > > 'del' parameter which is passed down all the way before reaching the > > > fwd_rule_add() implementation. If a rule should be deleted, at that > > > point, fwd_rule_del() is called instead. > > >=20 > > > Signed-off-by: Stefano Brivio > > > Reviewed-by: Laurent Vivier =20 > >=20 > > Reviewed-by: David Gibson > >=20 > > Several concerns below, but they can all be addressed as follow ups. >=20 > Just to set expectations: I won't take care of those, mostly because > there are actual blocking issues (not with this series, they would also > be follow up) that I'm trying to take care of instead, see e.g.: Makes sense. > https://github.com/containers/container-libs/pull/755#issuecomment-4392= 427315 >=20 > so you'll need to follow up with patches, in case (and expect delays in > reviews). Yes, that's what I expected. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --fq4hI32M4LKaotXx Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmn8BHcACgkQzQJF27ox 2GcomhAAg8FpCf2cLhYGesAj/R23sDrDDtD+Wr8Z+GVoGu6MLFuLiadNcOMwiT6W OGp51xcZ8i+qfiWn9HAPt4SW2Vcg+2Bc0uifW8HrKcIOIoiyreDVUcuOr4l+ExOO fqTsdz/+Q9zxj74KnRCSwmKDcjyD77W7C/CcWr0/67HiEeNUDkHvEjcNPm8wcPHU 3iKqBMEvsThzwn5RyQOmo9N0QQRsKiUB12PkM/7XIJMQ2assgu1VJNHH1VLXgUCT IrhFPIwi5nJLtkOt/A081WtBeSEixG55G1bBwebhYEMZVjRGj5eDprQmuHWp+xQn 6vLUgzVDlAB/qJnB8a/jV8aT3s345qgBkdxch/m2kzLInpVWyQq6ktIpkyCVNSmv UVTJ+tMJNgAeBoc34Ya5AVO9p3dmd9jbFarFu6JRjLI2gKuRhG8NJ3foezPqojhI qoeupOVtzNt0eHcqxT7Z14Eo4vCAVfCeM2QogIGrUGlt5qFYuO9P+2wFIs5DixVL DfnPntaPHQVGzockLcxCtnmu4WL9YAGRTrCBScuEXlJWYRbJHuJ2RkvNj3gvL5jq pytLeETR5KPqe+QFxbJmKT5rqnbSdzFe0jgOAVvPBF/8EbZlz750ar2tp7yJ6Eqy UnqrIWS+rKbw6EptqEefE9S5puA18wJaYYZ9YoqetkO0jpL7d6E= =YTJT -----END PGP SIGNATURE----- --fq4hI32M4LKaotXx--