From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=NeGv2iQ8; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 165185A0265 for ; Fri, 22 May 2026 02:04:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1779408243; bh=LXlFSbfkZ6a0hojqdD4g0NkyO9fiMQCSbh0WIB8nif0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NeGv2iQ83Sf1whffb0WUJl5yofJkawNr+xp77oWs9O6f1swNXDrhtj6uEC6SpC7YM IQcAZ6fTEbtr9CLrKRMxookmqF0CDA6BArsUllgRBFDpLJxjjoEPWZsc/8n+Om1VLE leARpvEfneWAxAAWH10xUatpncvo50bFaG3HFK8WGzV3JXh/e5tRTHyXKhNCv0pjR+ ZLR+IzXC15TkHDV1LoUQoVc35da/M4h/ZsaPav9mC8D0GbVTZ0GZB9S9a5MRnrTKQn tJSnnPCMZYDERWW128mYwU0M474pPJx5wnDSow6L3bGPWht0u8ENUVOwXvU6QUjJiX tkZjt+AH/lShA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gM59H3d1Kz4wSj; Fri, 22 May 2026 10:04:03 +1000 (AEST) Date: Fri, 22 May 2026 10:03:58 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/2] netlink: Fix comments to variables for netlink sockets and sequence Message-ID: References: <20260521180146.1834333-1-sbrivio@redhat.com> <20260521180146.1834333-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Jnc7VwSdNsgVXq/b" Content-Disposition: inline In-Reply-To: <20260521180146.1834333-3-sbrivio@redhat.com> Message-ID-Hash: Y2RNQIWTBN4GKMLTVQFVJLWOB6MU67LX X-Message-ID-Hash: Y2RNQIWTBN4GKMLTVQFVJLWOB6MU67LX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy , Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Jnc7VwSdNsgVXq/b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 21, 2026 at 08:01:46PM +0200, Stefano Brivio wrote: 11;rgb:ffff/ffff/ffff> Commit 3c469013cfaa ("netlink: add subscription on c= hanges in NDP/ARP > table") added the descriptor for the new socket, int nl_sock_neigh, > next to the variables for the existing sockets, without updating the > comment, and before the variable reserved for the sequence number. >=20 > That seems to suggest that the sequence number applies to the notifier > socket as well, but that's not the case. Further, the comment didn't > match anymore. >=20 > Move the variable declaration for nl_sock_neigh below, and add a > separate comment for it, actually describing it. While at it, fix the > indentation. >=20 > Fixes: 3c469013cfaa ("netlink: add subscription on changes in NDP/ARP tab= le") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > netlink.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/netlink.c b/netlink.c > index 0863734..8d20dbb 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -56,10 +56,12 @@ > #define NLBUFSIZ 65536 > =20 > /* Socket in init, in target namespace, sequence (just needs to be monot= onic) */ > -int nl_sock =3D -1; > -int nl_sock_ns =3D -1; > -static int nl_sock_neigh =3D -1; > -static int nl_seq =3D 1; > +int nl_sock =3D -1; > +int nl_sock_ns =3D -1; > +static int nl_seq =3D 1; > + > +/* Socket for neighbour event notifier */ > +static int nl_sock_neigh =3D -1; > =20 > /** > * nl_sock_init_do() - Set up netlink sockets in init or target namespace > --=20 > 2.43.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Jnc7VwSdNsgVXq/b Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoPnW4ACgkQzQJF27ox 2Gfc8RAAqKPl2MoFneGDmbIdpuCroKUobo568rpHwV2PRGIESbivIofTOhA6zgeB zMgmY9LK/9gT2L+9xo0nRvvhlEF/ap8vGpOC19BjNcM8TUj9vYPitSMeZs11DfWL wSKSF7w6LRI3qqlOxWTlQCFcvaobyMtuvMj6KR1wV8NDws1WPz3HOTSMZ5xbpCNt zjHG0Q+akicy82hPxBcBHJ2TPLEKuR/OUO8zD6O0Rq1dnVbe/m0lfuu2Gm+OPT9N +KB3NvL5P8j9XJG6Ee9ZCW+sqFsV1nXivqECsTAqCBsHNlM5QaW3NM9pIgsbMnkZ AZHCUdFOL37tynKsyhfJAxwiq5OLUweZEDLPtzRKw0+0OBr9OOM92U1krZIlxmUY izKPBRYHqlmWTSLUKLfBCSN7ttkOzgyeQLuFO1fo5hiAIoog7ra5X/mxeDyp5BKg Z/zamTgioTl2h3nDaz+wEFOYvPMHwgFH6dC0GEIRiv1VFpTAKkX31RYbJNdbhG8S HT8tLeiChWGuqCaBQrDiCjMcnHT8UT0bBKv+sqiFhQq66MtlTYeYIoAKQlKr0ujE nAy1cLKROOlRSVf4GLgJ0/ZxgNFOzo3ek175hr10UBdjluR3QOVc8zDAqXFP5Ibk 2B2uifjLOJ7Ettl9PgXiWvIB4Gogqq71zrwWCAg9rK5AAHJe2tM= =BLyV -----END PGP SIGNATURE----- --Jnc7VwSdNsgVXq/b--