From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=XubYLVuE; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 965275A026E for ; Wed, 20 May 2026 03:33:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1779240781; bh=HW+4qsIx3Lo21SG8n7VdR86rVPXnIUOSQQgqvLltBbc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XubYLVuEYjTQYNhKjqjPcHkqdFVGX2plhc5uuRre+YZLOoCOgPIXM1Hbe5NgmOOmB 15VqugWpI9jOBAM/E+cIfMavuJAubg81cYzxujPjptNILbDkYn6mT3MdlQiwDIRZAU l9HHdioyTrBk+Z+U75+l3LQ9O2eKTFxHWa1MzEDghNivwfUtHCucfb2KLnncFbWAGa y+ioHNutIOl2PRw5ffH4b0LyTwCg4cPTDdJKwcMw9dQoIe2J4pSPlFpMkslo7oOhyk mnacbvSLNLl+eQrby7CaWOgR9evMv83KCPWSQNMp/5Av7C3q0yPPRZz3LoBAYxjdHE lvRqHhuLWJ+Vw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gKvDs1gfwz4xRh; Wed, 20 May 2026 11:33:01 +1000 (AEST) Date: Wed, 20 May 2026 11:31:14 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/6] Add --dhcp-boot and --dhcp-opt options Message-ID: References: <20260518132002.418296-1-anskuma@redhat.com> <20260520023804.131ef7ad@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bZzOhyp0yggyPchB" Content-Disposition: inline In-Reply-To: <20260520023804.131ef7ad@elisabeth> Message-ID-Hash: DZVC7YQTH2TA56TQ3DUXXV6NO7LUXOE4 X-Message-ID-Hash: DZVC7YQTH2TA56TQ3DUXXV6NO7LUXOE4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Anshu Kumari , passt-dev@passt.top, lvivier@redhat.com, jmaloy@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --bZzOhyp0yggyPchB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2026 at 02:38:04AM +0200, Stefano Brivio wrote: > On Tue, 19 May 2026 15:30:41 +1000 > David Gibson wrote: >=20 > > On Mon, May 18, 2026 at 06:49:56PM +0530, Anshu Kumari wrote: > > > This series adds support for custom DHCP options in passt, enabling > > > network boot (PXE/UEFI HTTP Boot) and arbitrary DHCP option injection. > > >=20 > > > Two new command-line flags are introduced: > > >=20 > > > --dhcp-boot URL Sets the boot file URL (DHCP option 67 and the > > > legacy boot file field) > > >=20 > > > --dhcp-opt CODE,VALUE > > > Sets any DHCP option by numeric code, with > > > type-aware parsing per RFC 2132 > > >=20 > > > The DHCP reply path is extended with option overload support (RFC 2132 > > > option 52), allowing options to overflow into the file and sname fiel= ds > > > when the standard options area is full. > > >=20 > > > *** BLURB HERE *** =20 > >=20 > > Nit: remember to remove this boilerplate that git-publish inserts :) >=20 > No, no, that's from git format-patch, I swear (as somebody who doesn't > use git-publish). Oh, my mistake. Same thought applies, though. > Another detail, while at it: for some reason git send-email picked > the "chain-reply" style, that is, if you look at this in a threaded > email client, patch #1 is a reply to the cover letter (fine, expected) > but patch #2 is a reply to patch #1 (not expected), and so on. >=20 > That's the --chain-reply-to option for git send-email. You should > disable that (for example in gitconfig in case you have it on there) > and just use --cover-letter. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --bZzOhyp0yggyPchB Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoNDuEACgkQzQJF27ox 2Gepuw//ah5l8Bqky+O9cxktjtri+19onEPtPLoG9UlSQHY2pWO1A1GbWlSa8Eko 24/2wH8l11bduYLnvAeqrJSjYtYH3Qbw/WDTkh7DD0HFJ3rGGGRHfJJM+XwflxtX 4YRvaSQKM+DC5IkcXO3ac7INqXKMyGXy03B1XEFetur954PoY3gvt+1LIjNOZEBp DBekXGpV35Su+OaR6JEIRCxgDFrVUsGIb6tMEPc/Mn3qdnd7qb2+cHcGk4nbpSb5 oN9wmNQzUL78am3uxyk6HK6uF8QFJakLIeslDBBocNLPn3vOrYonkQo0V3J+xSuC Qzj0ctVpU4nIuSJJaKzMrIWnEANlszLUba/S4OwYzPElUy8tCVtSwAV/yJDHQtmO SXPKI/e9LKpnVNHxMB68eXL651UpNmb9jl6c4PxQhr7fu+1CgGRn28cjJ1LOr+DD 7kOO68kYew+F+i2zPP+ShXNfF5HmCHu2/jEu261zh2xPmU63CszGTLRmkwq4gwQP oQefXQoAsxd0P0PZb5A6av62EFiOI9TtUlyGQBHQTua6d0SG8kf4c22PKESiFnJw 87JKLlUDiPqCPNou5SlCeEGxJsjVbCUDwOjGFJWPEClnBSuyZDJfh6f8gKvrTIIP jUyGf+N4g5mYHCGpjF4xZjNz7/yhVhaK/elm+hfFwN11wCuRt/M= =DsEz -----END PGP SIGNATURE----- --bZzOhyp0yggyPchB--