From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=BWE1DEDg; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 9409E5A0262 for ; Mon, 11 May 2026 04:43:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778467379; bh=wqaF2hsy/ACUSGBZktL2Jf8LKrOMHYQmdmPiYN7cOa0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BWE1DEDgqhSS0edl6DJp2imMHneEgXfgEDZezmZsMXpRO9Zn9GAE5/pkoR7GWJop3 URZkuftQVmFLn6pe+UgFNkL+Oo1lc8wDeFDSfTomo31T0ey1rb1sclNjnS+FGxe/Eg bDki0UVEAyd1c8/CTUr3GZFgJ2NLo1gBWsVCAIlIEReUuheIwkwhZiLtRecbPEAdw/ qQqE+vnXwaktcAuwGsy7jeHTHGRz5sUhAxWX8Cn0dD+wq8P4DHmlx9msR2nRS0pa35 DIuf24mutz94fdaUNCaTQtgQ01itJr2kFMCYGor0YMYiKjvYmUdez9qSoHT5yCvxnZ CO4r2Fc1gbFvQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gDPCl38mGz4wJS; Mon, 11 May 2026 12:42:59 +1000 (AEST) Date: Mon, 11 May 2026 12:42:53 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v8 3/3] udp: Pass iov_tail to udp_update_hdr4()/udp_update_hdr6() Message-ID: References: <20260416160926.3822963-1-lvivier@redhat.com> <20260416160926.3822963-4-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="puZkAwrZsXyt4OpW" Content-Disposition: inline In-Reply-To: <20260416160926.3822963-4-lvivier@redhat.com> Message-ID-Hash: VCHDH52RN7TR42LIDUX3F3FFNQCZJWCS X-Message-ID-Hash: VCHDH52RN7TR42LIDUX3F3FFNQCZJWCS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --puZkAwrZsXyt4OpW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 16, 2026 at 06:09:25PM +0200, Laurent Vivier wrote: > Change udp_update_hdr4() and udp_update_hdr6() to take an iov_tail > pointing at the UDP frame instead of a contiguous udp_payload_t buffer > and explicit data length. This lets vhost-user pass scatter-gather > virtqueue buffers directly without an intermediate copy. >=20 > The UDP header is built into a local struct udphdr and written back with > IOV_PUSH_HEADER(). On the tap side, udp_tap_prepare() wraps the > existing udp_payload_t in a two-element iov to match the new interface. >=20 > Signed-off-by: Laurent Vivier > --- > iov.c | 1 - > udp.c | 70 +++++++++++++++++++++++------------------ > udp_internal.h | 4 +-- > udp_vu.c | 85 ++++++++++++++++++++++++++------------------------ > 4 files changed, 86 insertions(+), 74 deletions(-) >=20 > diff --git a/iov.c b/iov.c > index b1bcdc4649df..c0d9c6d21322 100644 > --- a/iov.c > +++ b/iov.c > @@ -368,7 +368,6 @@ void *iov_peek_header_(struct iov_tail *tail, void *v= , size_t len, size_t align) > * > * Return: number of bytes written > */ > -/* cppcheck-suppress unusedFunction */ > size_t iov_push_header_(struct iov_tail *tail, const void *v, size_t len) > { > size_t l; > diff --git a/udp.c b/udp.c > index 4eef10854d8a..536b9a74dd15 100644 > --- a/udp.c > +++ b/udp.c > @@ -255,20 +255,21 @@ static void udp_iov_init(const struct ctx *c) > /** > * udp_update_hdr4() - Update headers for one IPv4 datagram > * @ip4h: Pre-filled IPv4 header (except for tot_len and saddr) > - * @bp: Pointer to udp_payload_t to update > + * @payload: iov_tail with datagram to update Would be nice to clarify here that @payload includes the UDP header on entry, but excludes it on exit. > * @toside: Flowside for destination side > * @dlen: Length of UDP payload > * @no_udp_csum: Do not set UDP checksum > * > - * Return: size of IPv4 payload (UDP header + data) > + * Return: size of datagram (UDP header + data) > */ > -size_t udp_update_hdr4(struct iphdr *ip4h, struct udp_payload_t *bp, > +size_t udp_update_hdr4(struct iphdr *ip4h, struct iov_tail *payload, > const struct flowside *toside, size_t dlen, > bool no_udp_csum) > { > const struct in_addr *src =3D inany_v4(&toside->oaddr); > const struct in_addr *dst =3D inany_v4(&toside->eaddr); > - size_t l4len =3D dlen + sizeof(bp->uh); > + struct udphdr uh; > + size_t l4len =3D dlen + sizeof(uh); > size_t l3len =3D l4len + sizeof(*ip4h); > =20 > assert(src && dst); > @@ -278,19 +279,18 @@ size_t udp_update_hdr4(struct iphdr *ip4h, struct u= dp_payload_t *bp, > ip4h->saddr =3D src->s_addr; > ip4h->check =3D csum_ip4_header(l3len, IPPROTO_UDP, *src, *dst); > =20 > - bp->uh.source =3D htons(toside->oport); > - bp->uh.dest =3D htons(toside->eport); > - bp->uh.len =3D htons(l4len); > + uh.source =3D htons(toside->oport); > + uh.dest =3D htons(toside->eport); > + uh.len =3D htons(l4len); > if (no_udp_csum) { > - bp->uh.check =3D 0; > + uh.check =3D 0; > } else { > - const struct iovec iov =3D { > - .iov_base =3D bp->data, > - .iov_len =3D dlen > - }; > - struct iov_tail data =3D IOV_TAIL(&iov, 1, 0); > - csum_udp4(&bp->uh, *src, *dst, &data, dlen); > + struct iov_tail data =3D *payload; > + > + IOV_DROP_HEADER(&data, struct udphdr); > + csum_udp4(&uh, *src, *dst, &data, dlen); > } > + IOV_PUSH_HEADER(payload, uh); > =20 > return l4len; > } > @@ -299,18 +299,19 @@ size_t udp_update_hdr4(struct iphdr *ip4h, struct u= dp_payload_t *bp, > * udp_update_hdr6() - Update headers for one IPv6 datagram > * @ip6h: Pre-filled IPv6 header (except for payload_len and > * addresses) > - * @bp: Pointer to udp_payload_t to update > + * @payload: iov_tail with datagram to update Same comment as for udp_update_hdr4(). > * @toside: Flowside for destination side > * @dlen: Length of UDP payload > * @no_udp_csum: Do not set UDP checksum > * > - * Return: size of IPv6 payload (UDP header + data) > + * Return: size of datagram (UDP header + data) > */ > -size_t udp_update_hdr6(struct ipv6hdr *ip6h, struct udp_payload_t *bp, > +size_t udp_update_hdr6(struct ipv6hdr *ip6h, struct iov_tail *payload, > const struct flowside *toside, size_t dlen, > bool no_udp_csum) > { > - uint16_t l4len =3D dlen + sizeof(bp->uh); > + struct udphdr uh; > + uint16_t l4len =3D dlen + sizeof(uh); > =20 > ip6h->payload_len =3D htons(l4len); > ip6h->daddr =3D toside->eaddr.a6; > @@ -319,24 +320,24 @@ size_t udp_update_hdr6(struct ipv6hdr *ip6h, struct= udp_payload_t *bp, > ip6h->nexthdr =3D IPPROTO_UDP; > ip6h->hop_limit =3D 255; > =20 > - bp->uh.source =3D htons(toside->oport); > - bp->uh.dest =3D htons(toside->eport); > - bp->uh.len =3D ip6h->payload_len; > + uh.source =3D htons(toside->oport); > + uh.dest =3D htons(toside->eport); > + uh.len =3D htons(l4len); > + > if (no_udp_csum) { > /* 0 is an invalid checksum for UDP IPv6 and dropped by > * the kernel stack, even if the checksum is disabled by virtio > * flags. We need to put any non-zero value here. > */ > - bp->uh.check =3D 0xffff; > + uh.check =3D 0xffff; > } else { > - const struct iovec iov =3D { > - .iov_base =3D bp->data, > - .iov_len =3D dlen > - }; > - struct iov_tail data =3D IOV_TAIL(&iov, 1, 0); > - csum_udp6(&bp->uh, &toside->oaddr.a6, &toside->eaddr.a6, &data, > - dlen); > + struct iov_tail data =3D *payload; > + > + IOV_DROP_HEADER(&data, struct udphdr); > + csum_udp6(&uh, &toside->oaddr.a6, &toside->eaddr.a6, > + &data, dlen); > } > + IOV_PUSH_HEADER(payload, uh); > =20 > return l4len; > } > @@ -375,11 +376,18 @@ static void udp_tap_prepare(const struct mmsghdr *m= mh, > struct ethhdr *eh =3D (*tap_iov)[UDP_IOV_ETH].iov_base; > struct udp_payload_t *bp =3D &udp_payload[idx]; > struct udp_meta_t *bm =3D &udp_meta[idx]; > + struct iovec iov[2]; > + struct iov_tail payload =3D IOV_TAIL(iov, ARRAY_SIZE(iov), 0); > size_t l4len, l2len; > =20 > + iov[0].iov_base =3D &bp->uh; > + iov[0].iov_len =3D sizeof(bp->uh); > + iov[1].iov_base =3D bp->data; > + iov[1].iov_len =3D mmh[idx].msg_len; In the non-vu path, udp_payload_t already has the UDP header contiguous with the payload, so I don't really see a reason to use a 2-entry IOV, rather than a single entry IOV (for which we could re-use ((*tap_iov) + UDP_IOV_ETH)). > + > eth_update_mac(eh, NULL, tap_omac); > if (!inany_v4(&toside->eaddr) || !inany_v4(&toside->oaddr)) { > - l4len =3D udp_update_hdr6(&bm->ip6h, bp, toside, > + l4len =3D udp_update_hdr6(&bm->ip6h, &payload, toside, > mmh[idx].msg_len, no_udp_csum); > =20 > l2len =3D MAX(l4len + sizeof(bm->ip6h) + ETH_HLEN, ETH_ZLEN); > @@ -388,7 +396,7 @@ static void udp_tap_prepare(const struct mmsghdr *mmh, > eh->h_proto =3D htons_constant(ETH_P_IPV6); > (*tap_iov)[UDP_IOV_IP] =3D IOV_OF_LVALUE(bm->ip6h); > } else { > - l4len =3D udp_update_hdr4(&bm->ip4h, bp, toside, > + l4len =3D udp_update_hdr4(&bm->ip4h, &payload, toside, > mmh[idx].msg_len, no_udp_csum); > =20 > l2len =3D MAX(l4len + sizeof(bm->ip4h) + ETH_HLEN, ETH_ZLEN); > diff --git a/udp_internal.h b/udp_internal.h > index 64e457748324..e6cbaab79519 100644 > --- a/udp_internal.h > +++ b/udp_internal.h > @@ -25,10 +25,10 @@ struct udp_payload_t { > } __attribute__ ((packed, aligned(__alignof__(unsigned int)))); > #endif > =20 > -size_t udp_update_hdr4(struct iphdr *ip4h, struct udp_payload_t *bp, > +size_t udp_update_hdr4(struct iphdr *ip4h, struct iov_tail *payload, > const struct flowside *toside, size_t dlen, > bool no_udp_csum); > -size_t udp_update_hdr6(struct ipv6hdr *ip6h, struct udp_payload_t *bp, > +size_t udp_update_hdr6(struct ipv6hdr *ip6h, struct iov_tail *payload, > const struct flowside *toside, size_t dlen, > bool no_udp_csum); > void udp_sock_fwd(const struct ctx *c, int s, int rule_hint, > diff --git a/udp_vu.c b/udp_vu.c > index ef8e60cc390a..8cf50ca1c38f 100644 > --- a/udp_vu.c > +++ b/udp_vu.c > @@ -98,69 +98,73 @@ static ssize_t udp_vu_sock_recv(struct iovec *iov, si= ze_t *cnt, int s, bool v6) > /** > * udp_vu_prepare() - Prepare the packet header > * @c: Execution context > - * @iov: IO vector for the frame (including vnet header) > + * @data: IO vector tail for the L2 frame, on return points to the L4 he= ader > * @toside: Address information for one side of the flow > * @dlen: Packet data length > */ > -static void udp_vu_prepare(const struct ctx *c, const struct iovec *iov, > - const struct flowside *toside, ssize_t dlen) > +static void udp_vu_prepare(const struct ctx *c, struct iov_tail *data, > + const struct flowside *toside, size_t dlen) > { > - struct ethhdr *eh; > + bool ipv4 =3D inany_v4(&toside->eaddr) && inany_v4(&toside->oaddr); > + struct ethhdr eh; > =20 > /* ethernet header */ > - eh =3D vu_eth(iov[0].iov_base); > + memcpy(eh.h_dest, c->guest_mac, sizeof(eh.h_dest)); > + memcpy(eh.h_source, c->our_tap_mac, sizeof(eh.h_source)); > =20 > - memcpy(eh->h_dest, c->guest_mac, sizeof(eh->h_dest)); > - memcpy(eh->h_source, c->our_tap_mac, sizeof(eh->h_source)); > + if (ipv4) > + eh.h_proto =3D htons(ETH_P_IP); > + else > + eh.h_proto =3D htons(ETH_P_IPV6); > + IOV_PUSH_HEADER(data, eh); > =20 > /* initialize header */ > - if (inany_v4(&toside->eaddr) && inany_v4(&toside->oaddr)) { > - struct iphdr *iph =3D vu_ip(iov[0].iov_base); > - struct udp_payload_t *bp =3D vu_payloadv4(iov[0].iov_base); > - > - eh->h_proto =3D htons(ETH_P_IP); > + if (ipv4) { > + struct iov_tail datagram; > + struct iphdr iph =3D (struct iphdr)L2_BUF_IP4_INIT(IPPROTO_UDP); > =20 > - *iph =3D (struct iphdr)L2_BUF_IP4_INIT(IPPROTO_UDP); > + datagram =3D *data; > + IOV_DROP_HEADER(&datagram, struct iphdr); > + udp_update_hdr4(&iph, &datagram, toside, dlen, true); > =20 > - udp_update_hdr4(iph, bp, toside, dlen, true); > + IOV_PUSH_HEADER(data, iph); > } else { > - struct ipv6hdr *ip6h =3D vu_ip(iov[0].iov_base); > - struct udp_payload_t *bp =3D vu_payloadv6(iov[0].iov_base); > - > - eh->h_proto =3D htons(ETH_P_IPV6); > + struct iov_tail datagram; > + struct ipv6hdr ip6h =3D (struct ipv6hdr)L2_BUF_IP6_INIT(IPPROTO_UDP); > =20 > - *ip6h =3D (struct ipv6hdr)L2_BUF_IP6_INIT(IPPROTO_UDP); > + datagram =3D *data; > + IOV_DROP_HEADER(&datagram, struct ipv6hdr); > + udp_update_hdr6(&ip6h, &datagram, toside, dlen, true); > =20 > - udp_update_hdr6(ip6h, bp, toside, dlen, true); > + IOV_PUSH_HEADER(data, ip6h); > } > } > =20 > /** > * udp_vu_csum() - Calculate and set checksum for a UDP packet > * @toside: Address information for one side of the flow > - * @iov: IO vector for the frame > - * @cnt: Number of IO vector entries > + * @data: IO vector tail for the L4 frame (point to the UDP header) Clarify that it points to the UDP payload on exit? > * @dlen: Data length > */ > -static void udp_vu_csum(const struct flowside *toside, const struct iove= c *iov, > - size_t cnt, size_t dlen) > +static void udp_vu_csum(const struct flowside *toside, struct iov_tail *= data, > + size_t dlen) > { > const struct in_addr *src4 =3D inany_v4(&toside->oaddr); > const struct in_addr *dst4 =3D inany_v4(&toside->eaddr); > - char *base =3D iov[0].iov_base; > - struct udp_payload_t *bp; > - struct iov_tail data; > - > - if (src4 && dst4) { > - bp =3D vu_payloadv4(base); > - data =3D IOV_TAIL(iov, cnt, (char *)&bp->data - base); > - csum_udp4(&bp->uh, *src4, *dst4, &data, dlen); > - } else { > - bp =3D vu_payloadv6(base); > - data =3D IOV_TAIL(iov, cnt, (char *)&bp->data - base); > - csum_udp6(&bp->uh, &toside->oaddr.a6, &toside->eaddr.a6, &data, > - dlen); > - } > + struct iov_tail current =3D *data; > + struct udphdr *uh, uh_storage; > + bool ipv4 =3D src4 && dst4; > + > + uh =3D IOV_REMOVE_HEADER(¤t, uh_storage); > + if (!uh) > + return; > + > + if (ipv4) > + csum_udp4(uh, *src4, *dst4, ¤t, dlen); > + else > + csum_udp6(uh, &toside->oaddr.a6, &toside->eaddr.a6, ¤t, dlen); > + > + IOV_PUSH_HEADER(data, *uh); If the iov has contiguous space for the header (which it usually will), uh will alias the same buffers that data references. Is IOV_PUSH_HEADER() safe in that case? I suspect it isn't, since it uses memcpy(), not memmove(). > } > =20 > /** > @@ -227,9 +231,10 @@ void udp_vu_sock_to_tap(const struct ctx *c, int s, = int n, flow_sidx_t tosidx) > vu_queue_rewind(vq, elem_cnt - elem_used); > =20 > if (iov_cnt > 0) { > - udp_vu_prepare(c, iov_vu, toside, dlen); > + struct iov_tail data =3D IOV_TAIL(iov_vu, iov_cnt, VNET_HLEN); > + udp_vu_prepare(c, &data, toside, dlen); > if (*c->pcap) { > - udp_vu_csum(toside, iov_vu, iov_cnt, dlen); > + udp_vu_csum(toside, &data, dlen); > pcap_iov(iov_vu, iov_cnt, VNET_HLEN, > hdrlen + dlen - VNET_HLEN); > } > --=20 > 2.53.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --puZkAwrZsXyt4OpW Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoBQiwACgkQzQJF27ox 2GcGBw//Utokc9ElANJpaaetd751EJEyMFNRs8RKFUJrrXljv4AbvWuWy5xLKDqn 5PcI3ds+c1Y263kAGmhLzrMRlMThQkKQmPahq3Q+SXiAC1wzF5z49TswLSS7uzyP 3kcpNUQuxv+OjhXYlm/VZaqR+AJ9n6E+EDsR2zld2xiEs4ELtcTmhY0WuWlcjmND v6Seu8p4hp+kCn9RnchmlV5BMajZ5ENptf9aBWZttkGNinKcwcm+A2+kTtWWa3Pv Jy8mELovvAhUsBrUSxBoF7VuVljThxfFs2xhLwVyu02SifvGvwdUeLPvPhARnx6q RiBsVVsOhUlN2bb3Nixyzt1KaaDonFWU910NAGvswt3RSNJD7rdAVjJyswXrciyB R93Lrvz+0TDCuMs3dflMk9YQ4yEFkEQv20GQnLdWyYw9elWPPLPNkLVIwjd+BXEu pzk5R1PH1e6HCoANQIOva3ypUnKegYGulYz7uWPvSm//Puyon6FUgeMmnv52S8H5 gM1qCqQSLw2CEw9MoGkS2igFQ55R9VwuL2Yk784cdFDTqVoBTh7v9iM1iJeLtsJG 7+9wRYSyjEyK04X6nxgmfiyNn3i0WPhFf9XmA2Alb6LCSnkRJwbf2DvzuFHto/l/ uQMsi+KlEhG3sCaBwQ0Mf1RkYjN/XnBj8CPJ7H8IlPGYFEDV4tQ= =rMOR -----END PGP SIGNATURE----- --puZkAwrZsXyt4OpW--