From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=XyX0k32U; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id EC08C5A026D for ; Thu, 14 May 2026 03:10:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778721049; bh=HxCFJLUlAOjSRKsbDdunBBnWm2xMz1QnCVQmhGCo9vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XyX0k32UljxkXWHzdZ6qojlD4e+ILyT2LopURTwoENOh7gu5jKZKlxu4jGy4o0l/j IGNg9/2vzBCmgpnTCh52+JVyPIWCrRrt5rkVq5P+NhfYxro918fjdkDaDlrwMWeIAi /aK4rCeNdGBAK8BX1/uyJH+mUBHxQEj3qbFYbL/NPdAYzOr4swWnGhhsWdXcEuJybz qY4hW4Na2cqeQldf4e8pWfV54O73dqjYDK1gQahQNHNLeH7tdedhv5YXdHGazNNK4v aLHAj3KZ/5CgZJNpCJFn8c+ZYlTnx9cFCIwdfBgrdDBSIl+xTdixCqhABbWR7TYGT3 MiJM810Uf9qvg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gGC211gQVz4wM1; Thu, 14 May 2026 11:10:49 +1000 (AEST) Date: Thu, 14 May 2026 11:02:33 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/2] Fix a Coverity reported socket leak Message-ID: References: <20260513071821.3137329-1-david@gibson.dropbear.id.au> <20260513092313.285842e4@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="heRwvzTD/qQ6pmou" Content-Disposition: inline In-Reply-To: <20260513092313.285842e4@elisabeth> Message-ID-Hash: CPTVKWQTXPCBNH26U45E4VT7CNAYPL33 X-Message-ID-Hash: CPTVKWQTXPCBNH26U45E4VT7CNAYPL33 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --heRwvzTD/qQ6pmou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2026 at 09:23:14AM +0200, Stefano Brivio wrote: > On Wed, 13 May 2026 17:18:19 +1000 > David Gibson wrote: >=20 > > I got coverity working for me again, version 2026.3.0. This pointed > > out a potentially fairly nasty socket leak in tcp_listen_handler(). > > Here's a series that fixes it. >=20 > As we discussed in the call on Monday, Jon was going to look into > those. Oops, sorry, I forgot. > Cc'ing him for awareness, as maybe he doesn't need to look into those > anymore (but I'm not sure if you already tried passing the '--security' > switch). Well, not this specific warning and the one I fixed by accident in the "More caution with NONBLOCK" series". There are a bunch more. I think they're mostly false positives, but how to evade them is not very obvious. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --heRwvzTD/qQ6pmou Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoFHxoACgkQzQJF27ox 2GcCHw/8CRvPX43B9xWD1sLzFNz6FA+9/DVDX6NF5WkX0CBCLgyCO91WIexMo3qd vdkvnxjkp4WZ8gjyjVWMSZSMuzIjz2dif0sOOjMgj34+0VD5Cu+OsCLlmvKcigWK H3YCAWw3uJ5ND5bhDzs1/Kb8ccLAadRQotuun4slgaU6Whxrg9KnYQgQBFiHRZQK 3w4Z0e4cqvYZ6kuHH49DfpAfSojr7MHHAKd95lS8Lr1A+tRwxCFuU5JtkrbnXV4c 5hN2dtB5z34lVl9eHmLmm1x2UD+rugx2vsRujY/lTL90A7nn+1lbp8TPrnaBbzrP Hj9pCavUB+K1+GNrct3C0g54pzOpVyj7OmeEBIFTQ72pqkjZR/24PDBWbQxQSDmI R1Pw6ozchwExbj9NsVG3O+72mnZgJXKfjPJEWA96xkubw3GTSXskpW9W3LP6J4xU jI8EC7Jon/K/E+MbDbnEZikC+BvuYBOsvcFnVWs+WQBzupX0iIdjf/f9tURfapbZ W7iKYB3Iv3oFAyYdYQ//ToaFSiIiKw1BHRmiagiS7xJNxFtdyvK4JxflDmBpTeiD CUBZv0hOP4CJ8V1yWlCsGpt7+oV353Cj2O86hNP4wSgmOrQjhJZxC3pFKQvM3R4M vJc4XbJf1bmXS54xeWwLo01iqiQXB5O+pgKgMGc/p6w72mDFFzY= =41GM -----END PGP SIGNATURE----- --heRwvzTD/qQ6pmou--