From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=b6fem4eK; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 042CB5A061A for ; Sun, 17 May 2026 03:08:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778980099; bh=ZNpgvjuw1VAJWhDxHxnEs86Hq6HZfUUC4dMUCu3J3W8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b6fem4eKh/myNyMr5kxB41c9t633j+hDZaSWX3d2BghVfUSrrukR35qR3V7KSG26S U/oz9KlGL1/L2qdOGdypJulCkJGSKy9Q1wjJ64lfXvOTJAd6te6WnMmerywFYFmcT0 JNZiXwGptcfSeVcBVVf/dI1zi1wzBCj7XOLv1Hz40UGxyfHR8sOfwMpmlNfFstjICy cjlJmf0TG7AMwJzEyJ+K1oak5D5dhfJH5VZuPdbqyM07XBq8isov8IroCdzBLlKSoB dIRtFegiqfQ+GLiJPhqEwIu2NortYAFI90vkgh9AsfH/Hh9jSq8sbYG2bZrIFzBWXU GGxQxJzpOPT1A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gJ2ql6GJYz4wK2; Sun, 17 May 2026 11:08:19 +1000 (AEST) Date: Sun, 17 May 2026 11:08:16 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/3] Fix broken build with -DNDEBUG Message-ID: References: <20260515041312.317644-1-david@gibson.dropbear.id.au> <20260516174643.6c0c5e24@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NbbGNH3KSDHo6cBT" Content-Disposition: inline In-Reply-To: <20260516174643.6c0c5e24@elisabeth> Message-ID-Hash: MHJV5KKLHGC4UG44RMENBKIIUHRSHV24 X-Message-ID-Hash: MHJV5KKLHGC4UG44RMENBKIIUHRSHV24 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jan Palus X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --NbbGNH3KSDHo6cBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 16, 2026 at 05:46:44PM +0200, Stefano Brivio wrote: > On Fri, 15 May 2026 14:13:09 +1000 > David Gibson wrote: >=20 > > Fix the trivial but nasty with -DNDEBUG builds recently reported by > > Jan Palus. While we're there, add a couple of extra build tests. > > These wouldn't actually catch this problem, but they're better than > > nothing and do catch the #include problem I also spotted. > >=20 > > David Gibson (3): > > test: Extend exeter build tests to cover more recent binaries > > Fix build with -DNDEBUG > > test: Add test for builds with -DNDEBUG >=20 > Applied, with 2/3 amended as suggested by Jan. Uh.. I'm afraid you modified the wrong copy of assert_with_msg(), effectively nixing asserts in the !NDEBUG case while leaving my implementation in the NDEBUG case. > Jan, I'll let you know once I tag a new release so that you can drop > your no-assert.patch. >=20 > I'm trying to figure out, first, a couple of potential regressions > (https://bugs.passt.top/show_bug.cgi?id=3D202, > https://bugs.passt.top/show_bug.cgi?id=3D203) so that those can be > fixed in the new release as well, but it might be a while before I even > get to look into them, and I won't wait more than a few days with a new > release in any case. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --NbbGNH3KSDHo6cBT Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoJFPYACgkQzQJF27ox 2GdEzQ/+MDd1S2y32/MrzVnbbnN2VvJsvRyz2U4m5Y1Uit7vwL/BF+dQlKGrL6Fs qJR72DrvyuD18nxktOzUNaIk8q0czWTGH468+pkeZTTSr/X85KCeNoqyD1aaWF8m 5e4NKxPlkxJlHAjNu7+VRptow65GZghhFamYRxX4WQ1q0V7k+8GQZnBtbmMrUW15 S5nwW6siRlAuI95wRvMwM4FrMoXXtMwywDaSfnHaCx1VzQSWHYtE9/reafAIta/Z 5tg9RY7+HmfJTsmyr3AZMWkYKAk9uQicGOMgg30bBbi8x7pgFKcRG3K82RS/qWnz 41MFPYwayUuLbo66hpMOiPj8Ws0fvmH+QFBhwfv3fDaPKxOJ5+QdMgAIHE/nhbNB joNDJsRvHGQ5SNkmzkr5PBe3qt636g+LcZEUh4AacqpMx/KHYwfswSge9PgtUCtS YLS8uANLOcHRTh+7ZQlFQHfPd6cRHHYiUt18XYxtVVE+B7FBglnz+jh3saGTuEhN FF5HTKd8lUlahLt5vUCEJGyjlobrXJCUqqzQEh+3L3ITn13TUYzkNkU46EcsqGxL ZtTOrsqWCrGAJRb2Q0ILIAio0w+WKyzjG8vuTgMJ7jig9Oz9hQrEQr2NZCuWTxOh djYW1R1HX9M4LcgW374tjhBzGmlVc7oaZKqh5L1NML5AE9atbZM= =1l4K -----END PGP SIGNATURE----- --NbbGNH3KSDHo6cBT--