From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=B5VnUizI; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 429E35A0275 for ; Sun, 17 May 2026 03:09:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1778980177; bh=QKpnMQ6YxXOsTY9Cr82RoCj//8BrPcnwAMufWMq7avk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=B5VnUizIFS0+dom76IskKIEXLBHcSiosN1aROx8DoJ9ebK6KNZ69N/C4sPpvMf5J6 Nulh/qZaT5749+sgj1UnK9y3eDyt1BPIKm9mHiWo2R90iZf20UtJXY6qAwMwA2bGyC UsoyMvwc9Nx47ilQMni8mYkMLqFMGgOUFlVyR8qvbkhe4xlrZ+qx9BSqL7o1pzRPdt QuShEoTWkKfZSTMFAuLUkU1lH14QlWj81PFplbQnUQnYXYFJQYWhzVBNEwFKvkgYa9 n9Z27o0thFOwpR0KB6s/tmIt1VsgiPLDQ3CYX1A/rM8VrEl/nD2VyOGEDusTDRDpV0 qsH/evMs/+yng== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gJ2sF3XWRz4wLd; Sun, 17 May 2026 11:09:37 +1000 (AEST) Date: Sun, 17 May 2026 11:09:33 +1000 From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: Ignore Re: [PATCH v2] util: Fix changes to assert_with_msg() Message-ID: References: <20260517010747.138489-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GjG+d5+oJ+pCJ//V" Content-Disposition: inline In-Reply-To: <20260517010747.138489-1-david@gibson.dropbear.id.au> Message-ID-Hash: RTVLKC4JZVLI6Z4UILTF7WJ2I2JC35LJ X-Message-ID-Hash: RTVLKC4JZVLI6Z4UILTF7WJ2I2JC35LJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GjG+d5+oJ+pCJ//V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 17, 2026 at 11:07:47AM +1000, David Gibson wrote: > A last minute fixup to commit e51494552b78 was misapplied. Instead of > improving the implementation of assert_with_msg() for the case where > NDEBUG is defined, it effectively eliminated assert_with_msg() in the > normal case where NDEBUG is _not_ defined. As well as removing assert()s > which protect us in case of certian types of bug, this introduces some > cppcheck and clang-tidy regressions. >=20 > Fixes: e51494552b78 ("Fix build with -DNDEBUG") > Signed-off-by: David Gibson Sorry, sent this (identical) "v2" with a mistype. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --GjG+d5+oJ+pCJ//V Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoJFUkACgkQzQJF27ox 2Gdb6hAAkeqtPHTBP4psUAnI4gLfCyf8Fims3P5TJUyn5mxRBr3IlAm6vQ9nYvB9 aFTp5eRFkFIcos/aUTx7XF5/ETKQ8bnf6x79TAr4bqj9aoLu4wqBln3LJSt4OuN1 2JlluhHqRaJh4oI0DFE4d0xrHghkTkiTeeo9oNhAoPO7uUQPaJgHQrkPGzIr8DSA +z9/IRPdHzqAjB/UHn6+krVTD99kW5OaWmw+SIqC/E9J9Vuy2Jyd0HS3oh/bXFBR hpFYqWpNilztYRZwXK1EOaiCT8ucv/LiGGaQvnOPhsitplp82fhKpGyK/npmfh7w mfqEQeY0JI8fA2gO3JzAWrz0ULSeEClNaELLg0ES7fWgh+bod1HsRdakfi9Rqks9 FA7IrIJFuilHY1CPMWtlnt73LqVaIIYKFduoOZZdBeT6kTlIzV6t0G/gzt7JbENE BYXvZL4mslbClKNBJ8KuTPI9L3Ij+rUTVhKRhPYVD4kPIr4+C+BYMC7qTAZjHPd/ sD5Tmp4k1OMGIub+bIYJ41je3M30n/N2LYEAHWFJPq24B5MnIseR/pJ592Gb/r26 7W/21mCaT3SFvEk9jBFseZCdUZZG9dipSLFddpkocvQPDuxGIN4t0HHDlayGkssA m0wf6cle5orPihZ7goN7MHnQh+Jd7bFmQ/6+ayjsaGLLVVMTBhI= =GU+U -----END PGP SIGNATURE----- --GjG+d5+oJ+pCJ//V--