From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=drvxBn1g; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 8B2985A026E for ; Tue, 02 Jun 2026 04:25:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1780367126; bh=YYvDFJ2YQVSIvmDUMOTaSiNe1MqQdoqSWPA+52TtzRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=drvxBn1gxuZvBgsECdka89BFa4mLFa933sHY8jtcsD6+BCbiR/r/clfORzEBw5ewD jUla67OHBEzKCi+UfPknsiEiCYXlUEkiTcSuAjC9Du6Ain4BpPv/CadpyrVW+P8P6j pUGBBtP4zU8WIwenDXqpxtdyrRATGGn9KPFFw4hE0eY1d8wj3BJ/XA3ej/NiAWw3CK eVdiKapXAhruhS8Mr8IgXIaaJT83B1hhi1MktOsM8c3YgTMsn/dAEJgg60quaqcYoz 22X4HNn9PqDLNmVrH3xDU53aDYWrnZ/Wzip+BehJZP4/ElRHsdGMzmYRlv28Nyn86o 3qltWj6PvtZSw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gTvnL0Xphz4wKK; Tue, 02 Jun 2026 12:25:26 +1000 (AEST) Date: Tue, 2 Jun 2026 12:02:02 +1000 From: David Gibson To: Anshu Kumari Subject: Re: [PATCH v3 2/6] conf: Add --dhcp-boot command-line option Message-ID: References: <20260601073758.1571317-1-anskuma@redhat.com> <20260601073758.1571317-3-anskuma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nyw1qb4/Mcxu/wBT" Content-Disposition: inline In-Reply-To: <20260601073758.1571317-3-anskuma@redhat.com> Message-ID-Hash: EGWEMWNPV3ZGM46X567Z2A4TQ3DJZPW6 X-Message-ID-Hash: EGWEMWNPV3ZGM46X567Z2A4TQ3DJZPW6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --nyw1qb4/Mcxu/wBT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 01, 2026 at 01:07:52PM +0530, Anshu Kumari wrote: > Introduce the --dhcp-boot flag that sets the boot file URL for > network boot specially for ipxe. This patch adds the option > storage and CLI parsing. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D192 > Signed-off-by: Anshu Kumari Reviewed-by: David Gibson > --- > v3: > - case 32 now calls dhcp_add_option(c, 67, optarg). > - Handles duplicate codes: --dhcp-boot and --dhcp-opt 67 coexist > correctly, last value wins. >=20 > v2: > - Removed separate dhcp_boot[PATH_MAX] field =E2=80=94 --dhcp-boot foo = now stores into custom_opts[] as code 67 (same as --dhcp-opt 67,foo) >=20 > --- > conf.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/conf.c b/conf.c > index ce78af1..f7281e2 100644 > --- a/conf.c > +++ b/conf.c > @@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int stat= us) > " a single, empty option disables the DNS search list\n" > " -H, --hostname NAME Hostname to configure client with\n" > " --fqdn NAME FQDN to configure client with\n" > + " --dhcp-boot URL Boot file URL for network boot\n" > " --dhcp-opt CODE,VAL Set DHCP option by code\n"); > if (strstr(name, "pasta")) > FPRINTF(f, " default: don't use any search list\n"); > @@ -1239,6 +1240,7 @@ void conf(struct ctx *c, int argc, char **argv) > {"migrate-no-linger", no_argument, NULL, 30 }, > {"stats", required_argument, NULL, 31 }, > {"conf-path", required_argument, NULL, 'c' }, > + {"dhcp-boot", required_argument, NULL, 32 }, > {"dhcp-opt", required_argument, NULL, 33 }, > { 0 }, > }; > @@ -1475,6 +1477,9 @@ void conf(struct ctx *c, int argc, char **argv) > die("Can't display statistics if not running in foreground"); > c->stats =3D strtol(optarg, NULL, 0); > break; > + case 32: > + dhcp_add_option(c, 67, optarg); > + break; > case 33: > comma =3D strchr(optarg, ','); > if (!comma) > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --nyw1qb4/Mcxu/wBT Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoeOZkACgkQzQJF27ox 2GexNg//ecIZqtOm1YszbjC88HiS9I8OGmD6tvHOV9hmyN7661UTiQEbg7PSm8My Le2QqZeyIwvPyaZTwLqab9UCTJoOgR2oRPi8B329mcWL4JJByl/7wg6qLtjSzIYC xq/sogQmIV/Q18eMvLgEOecOsW3nrOnClTlJ+h55AnUKKUPP5U9euBLBtdkOOr8K XGcLceEAhSBbTVAsvpWgz40+ToeMHpxh9gMr+iH63+qyqqGLbi7fNNc4klaB2NZW 6gOD+0Ij9t+WyB5BhOe9agkPq8WAQS6Q6HCqtNM+YZWgNupyS4Fp4d782YPPGvEX QoV9TmRgdW0Y3nQBak0XJCwnn81Uz8T/UgiiEdYHh6Mr10EOCm5VnLZDqeM/rT/y YcKNbcwe+3dhtxcZo0UIKcTdtIQQ3F6/wSfyIXIwpx15jUllCf7aXNpAi+d9g4x9 IW/6JD05oKYAGPa2dJJDXPSl85AkdrNZOa1EnNVYye1AMxeoKX/+O1Vgb8SGIADH EZpiUIMHFxUd2HefaLp1vGKxSnZvxRF5Wwn/1YY60IAXgEfcultZz36RUNQcFLMd ohZGEHdGN6eX+odZL2NBIdBc64LHpIxJs3wyvEhf7A86EJicYGrLoVCHqfxPDR2q VDcvMiEcZzxWjELp3lAFnpWp9cAUPLG6pHmz2Lz2NIjC1DMXAYo= =bfJz -----END PGP SIGNATURE----- --nyw1qb4/Mcxu/wBT--