From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=lawQc88W; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id BAEF15A0269 for ; Tue, 02 Jun 2026 04:54:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1780368890; bh=K5cnXs51p839TkUR2+DSm050lOM5r4hDXPPkWGIdM0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lawQc88WKK1QpLvKkd9gPHOEGCn6vrtxrkXNxkWZu2l0NRXArjrGbT5fqWZrvxDyi vbxEPdyPwRuOWshkQILD+qfvr3czhO3x3Y/kzFV/PspNT9anXYXvGw9PUb9t8A/3HT LrbnaTtLQdEnLqAtA+FPpZx1gFZFitxha6q8WE+QxkHqjzdAmXWNfqQLE7LUfyCCWU ASVGTGnPhojYQ2EUMS6w5L2OLbnBZGDY88P+3zvazvlV+NrUvs0vIPrvLhyRDrr/V9 0JU/kdRY8gmsYLDkOzkhZqq+WUSIXCO7Y5NfnuUQpNHLGMgZQAeIPuylRoqXGXARV3 pVFYjip0OLiSA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gTwRG3szkz4wKH; Tue, 02 Jun 2026 12:54:50 +1000 (AEST) Date: Tue, 2 Jun 2026 12:54:47 +1000 From: David Gibson To: Anshu Kumari Subject: Re: [PATCH v3 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Message-ID: References: <20260601073758.1571317-1-anskuma@redhat.com> <20260601073758.1571317-7-anskuma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fltJJzemuT/uQb3L" Content-Disposition: inline In-Reply-To: <20260601073758.1571317-7-anskuma@redhat.com> Message-ID-Hash: STDXZZ6YOT2Y5O7R5IQY6BTC3B5ZP5CV X-Message-ID-Hash: STDXZZ6YOT2Y5O7R5IQY6BTC3B5ZP5CV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --fltJJzemuT/uQb3L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 01, 2026 at 01:07:56PM +0530, Anshu Kumari wrote: > Document the new --dhcp-boot and --dhcp-opt command-line options in > the passt(1) man page, including supported option codes grouped by > value type and usage examples. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D192 > Signed-off-by: Anshu Kumari Note that as a general rule, I think it's preferable to include manpage / doc updates with the patch that implements the code change. That can get fuzzy when the implementation is across several patches of course. In any case, not worth reworking here. These options should probably also be mentioned in usage() output (though with a much briefer description). > --- > v3: > - Removed options 33, 55, 61, 119 from supported codes list > - Added note: "If the same name option code is given more than once, > the last value wins". >=20 > v2: > - Updated --dhcp-boot description. > - Highlighted cross-referenced options with \fB...\fR. > - Updated IP list format from "space-separated within quotes" to "comma= -separated". > - option 121 dropped. > - Added option 55 to string options list. > - Removed --dhcp-boot override reference from --dhcp-opt description. > --- > passt.1 | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) >=20 > diff --git a/passt.1 b/passt.1 > index 908fd4a..57e2cc1 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -430,6 +430,47 @@ Send \fIname\fR as DHCP option 12 (hostname). > FQDN to configure the client with. > Send \fIname\fR as Client FQDN: DHCP option 81 and DHCPv6 option 39. > =20 > +.TP > +.BR \-\-dhcp-boot " " \fIurl > +Convenience shorthand for \fB\-\-dhcp-opt\fR 67,\fIurl\fR. > +Sets the boot file name (DHCP option 67) for network boot. > +For UEFI HTTP boot, also set the vendor class identifier using > +\fB\-\-dhcp-opt\fR 60,HTTPClient. > + > +.TP > +.BR \-\-dhcp-opt " " \fICODE\fR,\fIVALUE\fR > +Set a DHCP option by numeric code. The value format is determined automa= tically > +from the option code. Multiple IPv4 addresses are comma-separated. > +This option can be specified multiple times. If the same option code is > +given more than once, the last value wins. Options set with > +\fB\-\-dhcp-opt\fR override built-in values. > +Only the following option codes are supported (unsupported codes cause a= n error): > +.RS > +.TP > +.B IPv4 address options > +1 (Subnet Mask), 16 (Swap Server), 28 (Broadcast Address), 50 (Requested= IP), > +54 (Server Identifier) > +.TP > +.B IPv4 address list options (comma-separated) > +3 (Router), 4 (Time Server), 5 (Name Server), 6 (DNS), 7 (Log Server), > +8 (Cookie Server), 9 (LPR Server), 10 (Impress Server), > +11 (Resource Location Server), 41 (NIS Servers), > +42 (NTP Servers), 44 (NetBIOS Name Server) > +.TP > +.B Integer options > +2 (Time Offset, 32-bit), 13 (Boot File Size, 16-bit), 19 (IP Forwarding,= 8-bit), > +23 (Default IP TTL, 8-bit), 26 (Interface MTU, 16-bit), > +37 (TCP Default TTL, 8-bit), 38 (TCP Keepalive Interval, 32-bit), > +51 (IP Address Lease Time, 32-bit), > +53 (DHCP Message Type, 8-bit), 57 (Max DHCP Message Size, 16-bit), > +58 (Renewal Time, 32-bit), 59 (Rebinding Time, 32-bit) > +.TP > +.B String options > +12 (Host Name), 15 (Domain Name), 17 (Root Path), 40 (NIS Domain Name), > +60 (Vendor Class Identifier), 66 (TFTP Server Name), > +67 (Bootfile Name), 252 (WPAD URL) > +.RE > + > .TP > .BR \-t ", " \-\-tcp-ports " " \fIspec > Configure TCP port forwarding to guest or namespace. \fIspec\fR can be o= ne of: > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --fltJJzemuT/uQb3L Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoeRfYACgkQzQJF27ox 2GfPuQ//SBBRiv1lJsw4CI+6wAJhxi+wsynNqXx7IOeHpVSrkT0YIy8Gk0CdWq1s 2Q+RsSS1u2CrK1OcpjM7vS+qaeN7WMGNlMPa8L7zZG2sWr9r0L6BUCcgwIMAkRzj GVU4WeqntkFVlDpEG5FRWFPOts5o8pjDT1VmiFbThkVk86e923Oz4TpYpsyc8mBn OlyQ57eRZlSywXcnmlxd/2U7mXfn+VaXN15NLinoxyWU4pnW8bjgz5PMP3Hi+K3p +t+NIm2/ikvuWsJKSKlMMmB92PFwwc7NG0hCDG/jBmrjhFvDf0jErVlBFJMwTL3f WST9h0sXm5ttwvg8jCsG7XTJOaLwxXzWd4tlSFJvsuoGGmxgi7i+j/DcqAQfn12r 8ZED7cp2dhFqcP5JEyTK4xTUVU+UAlwPYYN5BKaxADMP6i25PXh7UBpDX+0KQ0wS BS2bdZf8VK3A5+ymukjrCOMWFVP9jOHtbrr+5PiPi6PZlZ8YAKD7mwVAsmWlsRDa 8TYw/aKWPWp+l4Dd5nRg43QyjZ07vyOM3jCEaAD3b0VUvRCBYWsgy7S3hD8YkfeF 3Ghh3OAeYSWENP4bwjxvrjQxiEH7dPICIEFY6ObkoIOWLcQ/Th4BSL9+Ew56lXm+ 2djHxdx9z6G3RX9wLryczSYCOOVSBn1UjNRnN3rRuF8M59TzEpA= =zKo9 -----END PGP SIGNATURE----- --fltJJzemuT/uQb3L--