From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=TBj2KMbY; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 31AA45A0269 for ; Wed, 27 May 2026 06:16:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1779855376; bh=Avm2/Ke6KNNg4SLLWc9psTkY0z0MLJECWAMBi5iexQ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TBj2KMbYcFoNlUgLjleXWsSDEZLnIy9rRRKgGDgIpLVkixd6iT/DxRp4bb8cQ+EQy SoiOsblAs3I6uFJ/NIR3xPn5NX1rLYEHdxdONQhQWMZ03CJd/0xcu3NiHxxgOuk9AA oWVy34OMdqmBgOOTt0JJTSrLNFG766CchRnf81Wx1b5v47z/fWxsrUeIXDJXEBFQve aymzbByiU1htUNmQncot19ssRkP1bRLNQVhIU4qzbbuYpvQPq1CHxUvPaAxg/shexG YzkniaAL9sC7e1YqGj170gNSjqLkDWjgg41HQYwbNf6VFC33YIoEnyFEjp2PwriNvw os3n3ylBOfzKg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gQGX05x42z4w2D; Wed, 27 May 2026 14:16:16 +1000 (AEST) Date: Wed, 27 May 2026 14:16:12 +1000 From: David Gibson To: Anshu Kumari Subject: Re: [PATCH v2 6/6] doc: Add --dhcp-boot and --dhcp-opt to man page Message-ID: References: <20260526123115.1226166-1-anskuma@redhat.com> <20260526123115.1226166-7-anskuma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MW4VFK8d/dFzxcFZ" Content-Disposition: inline In-Reply-To: <20260526123115.1226166-7-anskuma@redhat.com> Message-ID-Hash: AXNTDGYXMAM5ODVEIXKOJKNSULQ6OB4Q X-Message-ID-Hash: AXNTDGYXMAM5ODVEIXKOJKNSULQ6OB4Q X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MW4VFK8d/dFzxcFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 26, 2026 at 06:01:13PM +0530, Anshu Kumari wrote: > Document the new --dhcp-boot and --dhcp-opt command-line options in > the passt(1) man page, including supported option codes grouped by > value type and usage examples. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D192 > Signed-off-by: Anshu Kumari Reviewed-by: David Gibson Not worth a respin, but as a general rule, I'd include man page updates in the same patch adding the functionality described. > --- > v2: > - Updated --dhcp-boot description. > - Highlighted cross-referenced options with \fB...\fR. > - Updated IP list format from "space-separated within quotes" to "comma= -separated". > - option 121 dropped. > - Added option 55 to string options list. > - Removed --dhcp-boot override reference from --dhcp-opt description. > --- > passt.1 | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) >=20 > diff --git a/passt.1 b/passt.1 > index 908fd4a..199172f 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -430,6 +430,47 @@ Send \fIname\fR as DHCP option 12 (hostname). > FQDN to configure the client with. > Send \fIname\fR as Client FQDN: DHCP option 81 and DHCPv6 option 39. > =20 > +.TP > +.BR \-\-dhcp-boot " " \fIurl > +Convenience shorthand for \fB\-\-dhcp-opt\fR 67,\fIurl\fR. > +Sets the boot file name (DHCP option 67) for network boot. > +For UEFI HTTP boot, also set the vendor class identifier using > +\fB\-\-dhcp-opt\fR 60,HTTPClient. > + > +.TP > +.BR \-\-dhcp-opt " " \fICODE\fR,\fIVALUE\fR > +Set a DHCP option by numeric code. The value format is determined automa= tically > +from the option code. Multiple IPv4 addresses are comma-separated. > +This option can be specified multiple times. Options set with \fB\-\-dhc= p-opt\fR > +override built-in values. > +Only the following option codes are supported (unsupported codes cause a= n error): > +.RS > +.TP > +.B IPv4 address options > +1 (Subnet Mask), 16 (Swap Server), 28 (Broadcast Address), 50 (Requested= IP), > +54 (Server Identifier) > +.TP > +.B IPv4 address list options (comma-separated) > +3 (Router), 4 (Time Server), 5 (Name Server), 6 (DNS), 7 (Log Server), > +8 (Cookie Server), 9 (LPR Server), 10 (Impress Server), > +11 (Resource Location Server), 33 (Static Routes), 41 (NIS Servers), > +42 (NTP Servers), 44 (NetBIOS Name Server) > +.TP > +.B Integer options > +2 (Time Offset, 32-bit), 13 (Boot File Size, 16-bit), 19 (IP Forwarding,= 8-bit), > +23 (Default IP TTL, 8-bit), 26 (Interface MTU, 16-bit), > +37 (TCP Default TTL, 8-bit), 38 (TCP Keepalive Interval, 32-bit), > +51 (IP Address Lease Time, 32-bit), > +53 (DHCP Message Type, 8-bit), 57 (Max DHCP Message Size, 16-bit), > +58 (Renewal Time, 32-bit), 59 (Rebinding Time, 32-bit) > +.TP > +.B String options > +12 (Host Name), 15 (Domain Name), 17 (Root Path), 40 (NIS Domain Name), > +55 (Parameter Request List), > +60 (Vendor Class Identifier), 61 (Client Identifier), 66 (TFTP Server Na= me), > +67 (Bootfile Name), 119 (Domain Search List), 252 (WPAD URL) > +.RE > + > .TP > .BR \-t ", " \-\-tcp-ports " " \fIspec > Configure TCP port forwarding to guest or namespace. \fIspec\fR can be o= ne of: > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MW4VFK8d/dFzxcFZ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoWcAsACgkQzQJF27ox 2Gd4SQ//bnwK4Z4uZAq5+YMTaCPZKodXiH44K+TRAvCLT/yrKTfJ9mrtWhBc1BAt p4O2GpodlqDwAoPd/M/Yv+yocrqI1Ea/y93WUEmFwinKXkIVIIkyZSVC/xX5Ciye M9SoEdUOcBpYrxPu4RoB4NpcsuKjrYuRdj5+lPngFX2cXxM6rcxj9JOomTE4CUdO zuC1r3zlGq6xKYtenPGV4jMt0qp7MKNSSSFZo4C9MHdc/tpycAgLqx/0xZ3O28cM RX/Gsc/Wpsb7XZOaqAXq5cexsd+abt2eQ/ijsDEAjepHmGeGeQrIjgApYs/S4K57 b1EmOCM1IOBll7dY1+QAsenfK7kadKcuxtPFI83wJy+5NSPDsHnbCZVNIHiFQ9jP l6ET9wTMOL0NZMuvg4WAzaPiJ9iNHjIJROR+OlyrR7ttibeZyfiIu85A7IFkJQzX ODD6X1k4PkQ8Pmsbdcx5NDd1ZOuBOusG95QmioENfT/IqbxxP0YijRjnJm9yr6zn L0AfM+I/e5LtdNehFNfpA7UZ/uP57yvMR3p3wM8u12h/mCMesY1+t6Q1Tu6vYy0F nU9FeO7z/xlV8QBB1S/mSybDQiCm0FDKZMsBAsGXpQ1SMjecoN9LjsenUWy+rh0v iK3ySWdmwWp6f+ImhSPiSblYIulaZDB7CH+j/LF8y299uu+Acgg= =hGuX -----END PGP SIGNATURE----- --MW4VFK8d/dFzxcFZ--