From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=ZmDqtFW9; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6C5175A0262 for ; Thu, 28 May 2026 02:50:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1779929433; bh=jdncUickU/9dBPHkBdjo0mhOnwl+Se5XAV+bXNXUkbY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZmDqtFW9UEDEP5z5T+hsOWSaMi6MJr41BFzbKionanScKafnosmIgZ4Gx/Bj0i2uL TW/pJMNTG4lxhbirCawuitQq1twYGweXLvg7Uyr6JrFU2E8zTsF4LroP4U6HUlMoIU MqN7m2GgOlinFxxMPRQ5k4AhmaHPdPQ8RCSy/t2SoU5TMfWYZ1WJaGCX1qVJW4K63z bjpT+lk4jRTGROcrPqka1yprtbrcBKDage+9T+2eL5ZcdHInzlV7c9mhKm6tBvSwBM iWX1eLrB2gxcbSdEe41TDOiLsULpG7ErcgeywDQlD7Xq+4nqf5NrSIwK5bvqSOYe79 Cwf7YIXOFPC5g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gQnw93D0Lz4wL6; Thu, 28 May 2026 10:50:33 +1000 (AEST) Date: Thu, 28 May 2026 10:40:06 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/2] Fix a Coverity reported socket leak Message-ID: References: <20260513071821.3137329-1-david@gibson.dropbear.id.au> <20260527132213.5a8ff221@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5aw8EhDIltfC8pIn" Content-Disposition: inline In-Reply-To: <20260527132213.5a8ff221@elisabeth> Message-ID-Hash: EGTTLNBCRQYJRAZM4DVONETQLY3US3LX X-Message-ID-Hash: EGTTLNBCRQYJRAZM4DVONETQLY3US3LX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --5aw8EhDIltfC8pIn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 27, 2026 at 01:22:15PM +0200, Stefano Brivio wrote: > On Wed, 13 May 2026 17:18:19 +1000 > David Gibson wrote: >=20 > > I got coverity working for me again, version 2026.3.0. This pointed > > out a potentially fairly nasty socket leak in tcp_listen_handler(). > > Here's a series that fixes it. > >=20 > > David Gibson (2): > > tcp, tcp_splice: Make helper for setting SO_LINGER socket option > > tcp: Don't leak sockets on error paths >=20 > Applied, sorry for the delay. >=20 > I was wondering if Jon wanted to eventually take these in a series > fixing more warnings and waited a bit (which turned out to be longer > than I thought) but 2/2 could fix some real issues and we have a report: >=20 > https://github.com/containers/podman/issues/28644 >=20 > that might actually be fixed by that. I'm now asking the reporter if > they can try out this fix. The bug I'm fixing here occurs before we allocate timerfds, so, alas, I think it's unlikely it will fix that report. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --5aw8EhDIltfC8pIn Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmoXjtkACgkQzQJF27ox 2GcVpA//fCXMW5RyHqliNUWPBi3+Cyfa4WEHC8lfPWXpW+vSCLiY7TraERRvZzS0 Wy4aBZ7ZPCA72YEYCpkaE/0mYdP53Q/WVq7UmfS+irYZkqbdJhDTT7lBWlZUbklD ZiA7+3RwvxdcYRzwMJFdaUoPEYfEA+cmxFVvyBDZajKkF9i3Vrqqo2O4V/PfEh+z rP6+ccIxanw5WsdJ94U1mOfs6vKVfZBtZlW4uMtah+yRS7RwzF+x4vVS2ecRdO+3 FRbiYVVDg/7xFU1HRA6PBm9/dvKZZtuVEJfF2w3O2n7Vd47kxWyfvplnuXHL5mLY D3bTlPn46rgjtJMDY2Mj1duZwxhfN4jqPX8g5+WYZZwnyI570Wios7ucjhWf9fUn ZOSYAvIE5rJM/RFGMEf0h1DyVZh33Z4pZUC/7TvQ75PZ9INb8r5shLLLg20uXUYt zj6ZNXMjZRpuG107kpFWfJwkxriHKwjM+IEBquHPG9qlO0RfMBFAz3lD+Tu8fwH8 yLswQtYMrSEIlllwu7Sg4l2Ro9cKalVBEqpnMf+tY2S/ejIVyPtF2GjrVe5r+PLD tg7e4eJ8QGBOJXZStTHA61uoYMPA4fige0KiIgAdNv7Rcm7D4avkq+MPgwCaf3Fh RpamNPRw1pKi2qLQ8Gvhasd8UsbRKSRgjX1WwzpaUJabPIDS6jM= =RCMZ -----END PGP SIGNATURE----- --5aw8EhDIltfC8pIn--