From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=OtVvwzEA; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id DB7DB5A026D for ; Mon, 15 Jun 2026 10:17:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781511454; bh=GUzeS/ExpXKZethaRPi9DUigS1py2VluvzfBcBJZadM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OtVvwzEAvIVr+mnGajrfLzNne0YPB42hphjODnST/weCueS3+z+DuWDKUi+VKFHIg MBat0qE07rLVQL06zSdc+GUSlYtPCMiKNicR1XngYIjuwQbdzp5VTaxlfPbYD30Vg9 nFX2QvrVtWTNagf98gh0gJdFEs1427zHlwj7rc2frxzKIHI0YIfRRlU1kUluC/YhnA s8DB0MI4C36oN7YNX25trslmd+5wmoQpmYAUYpj4s0zFjl1jujjyngKsSfw/ydNM11 HX6iBnn310UfbLmECtAp80ct5hdfknfCiyuDwC3RWr6ORcz+/1KehXqgt13rFW+t5P /+oDX6QtQd0CA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gf2zf10tZz4wTR; Mon, 15 Jun 2026 18:17:34 +1000 (AEST) Date: Mon, 15 Jun 2026 12:52:27 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/4] Assorted minor socket creation cleanups Message-ID: References: <20260609063005.113744-1-david@gibson.dropbear.id.au> <20260612010516.4d9cfd0e@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j1jSNIZpf/AVSvQu" Content-Disposition: inline In-Reply-To: <20260612010516.4d9cfd0e@elisabeth> Message-ID-Hash: TZPGNCA452TQQ3MY7GNNOOSYQIHRVLW2 X-Message-ID-Hash: TZPGNCA452TQQ3MY7GNNOOSYQIHRVLW2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --j1jSNIZpf/AVSvQu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 12, 2026 at 01:05:17AM +0200, Stefano Brivio wrote: > On Tue, 9 Jun 2026 16:30:01 +1000 > David Gibson wrote: >=20 > > As discussed on our recent call, I was looking again at bug 167. I > > discovered it's still fairly fiddly to address this, but while > > investigating spotted a number of cleanups to make in the vicinity. I > > think they make sense even without fixing bug 167 (yet), so here they > > are. > >=20 > > David Gibson (4): > > flow: Correct misleading signature of flowside_sock_l4() > > Makefile: Remove unused DUAL_STACK_SOCKETS define > > fwd, pif: Remove duplicated logic between tcp_listen() and > > udp_listen() > > pif, util: Move listen(2) call from sock_l4_() to pif_listen() >=20 > I was about to apply this (there are no apparent conflicts with "[PATCH > 0/4] RFC: Improvements to flow specific logging", which I still need to > review), but cppcheck now says: >=20 > --- > flow.c:216:31: style: inconclusive: Function 'flowside_sock_l4' argument = 4 names different: declaration 'tgt' definition 'side'. [funcArgNamesDiffer= ent] > const struct flowside *side) > ^ > flow.h:176:31: note: Function 'flowside_sock_l4' argument 4 names differe= nt: declaration 'tgt' definition 'side'. > const struct flowside *tgt); > ^ > flow.c:216:31: note: Function 'flowside_sock_l4' argument 4 names differe= nt: declaration 'tgt' definition 'side'. > const struct flowside *side) > ^ > pif.c:111:10: error: Overlapping read/write of union is undefined behavio= r [overlappingWriteUnion] > ref.fd =3D sock_l4_dualstack_any(c, ref.type, port, ifname); > ^ > pif.c:116:10: error: Overlapping read/write of union is undefined behavio= r [overlappingWriteUnion] > ref.fd =3D sock_l4(c, ref.type, &sa, ifname); > ^ > --- Bother. I thought I'd done a cppcheck / clang-tidy pass, but apparently I missed it :(. > ...is it just my version (2.19.0)? No. Although my version (2.21.0) also gives some new errors on the main branch. Hang on.. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --j1jSNIZpf/AVSvQu Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmovaOoACgkQzQJF27ox 2Gc9Iw//fFwe8PFHuOuhNFAHQyyUU1I4INuDJpPXEIuGxDaY+hKWmlW4r1iLDQ1E ggWa/j4/YkE9EPGf7nST3NoGIf4IAS84Efzzec69q3wVY4ODtintdTeWn43Aa5/B 88CeNaulGwevbi2UO5YI7w7dZ5y3r16i61rNY59kIyUXKzT3O/YA3nqlUPkt4Je5 rFfwzTG/CQtWdApy7FbsPsSCfIK472QpjM9Vw450rM+3ln0kOXAK8x9bVgJG1Tfe 7dfo9HbjfP83M3TrpRzqJnFp1hZvmQi230UNDd67O9gWE3XgZkBNmBUXuYrDqWHL oiALOg8XXCbcZDw9lYNo3XQQ+w4l8jHt/4WLi46qbRu+CoSNzxLhUkM+I/S/5d/i 3EREiABvFyyBUbN8SvZrwpkkyGdhe+GNJE6ZFpD6rC+WIJjw8UUYXfhvYM4ZdG8E /AF7WhOHH8mEQxyw027ObPIWaxeg/jau/rqDSpyW9UjZbD8rqEIIGWf6gQ2go23k toDRFajb236DFarqTaIYsi0B1hTyZy5JuuUtFdP8wumCvpxiCnBkpZFLpV9dn0aJ CS8OzOf7I4s0EYsN/JAj8ees5AdH0Lzk3EdpxybNVHdCwHKt/g2fi2B854NxJiNK 0hcwIihGqNvKuYrztDjwzjynApolMqUPRfgt5S1UuCiyTaDnnyA= =tzpR -----END PGP SIGNATURE----- --j1jSNIZpf/AVSvQu--