From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=bHIos+26; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 10A0F5A0265 for ; Thu, 18 Jun 2026 06:16:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781756208; bh=HmrYXOtUQoIfmTUNBMuEKqPTrwh9YbMIgaZ+sjQVLpk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bHIos+26NAA3oS7K0ZenTh3Q0hhUD8TUA+W9T7gGgJwwndqfItRoxgceloDDf/kT1 midYut89sgQObyowejVdL3LGpfdbOtk2U1gQ0KDEzrxiXcPJQmVG4/JFbLqbWJpSBF BHljIHXzPuWqdNttHd81qVAqhrUzwjvkEJ+hgCBThlLLiwRnnSkiwRNq1rMwfInx7J 9VfoZFmi+4WZB6kWZ1mm6lKTU9urewAUcc75qlGiU6Hhc+cp3gS5AHSWRwrPEVeMce sJdyjP1y9hAZbkvfhK1P1rCuARKA5R9PFSd/NFfXvF+Snrjjil9tV/GxsiceB+RS0Q 8dOWIYM8XUWqw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ggnVS68fTz58m4; Thu, 18 Jun 2026 14:16:48 +1000 (AEST) Date: Thu, 18 Jun 2026 12:52:07 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH] inany: Fix doc comment to match u32 field, not u64 Message-ID: References: <20260617122103.97215-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dpLVsiHpYSrTBlmP" Content-Disposition: inline In-Reply-To: <20260617122103.97215-1-lvivier@redhat.com> Message-ID-Hash: O74IKRMW77WXAOLZOXNFCULFTKPL5W25 X-Message-ID-Hash: O74IKRMW77WXAOLZOXNFCULFTKPL5W25 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --dpLVsiHpYSrTBlmP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 17, 2026 at 02:21:03PM +0200, Laurent Vivier wrote: > The original siphash incremental patch added a u64[2] member to > union inany_addr for hashing. During review, this was changed to u32[4] > to preserve 4-byte alignment: a u64 member would have forced 8-byte > alignment on the union, mismatching struct in6_addr. >=20 > The doc comment was not updated, fix @u64 references to @u32. >=20 > Fixes: fc8f0f8c48ef ("siphash: Use incremental rather than all-at-once si= phash functions") > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > inany.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/inany.h b/inany.h > index 73385b916240..6bf3ecaa0e7d 100644 > --- a/inany.h > +++ b/inany.h > @@ -22,9 +22,9 @@ > * @v4mapped.zero: All zero-bits for an IPv4 address > * @v4mapped.one: All one-bits for an IPv4 address > * @v4mapped.a4: If @a6 is an IPv4 mapped address, the IPv4 address > - * @u64: As an array of u64s (solely for hashing) > + * @u32: As an array of u32s (solely for hashing) > * > - * @v4mapped and @u64 shouldn't be accessed except via helpers. > + * @v4mapped and @u32 shouldn't be accessed except via helpers. > */ > union inany_addr { > struct in6_addr a6; > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --dpLVsiHpYSrTBlmP Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmozXUkACgkQzQJF27ox 2Gf+TA/7BOl5E2bC3Y9gs1Z/DH+dxozZbAFHyxcYXopeWuOOLvt3yfJuUF73dzt9 6KOKgk+XQIS1ZJa54Ike0yYKTYcR4astA3aoMSYNgCScZDIVyo28W1kUouSze7s2 spdBs1u/fNP6Tdk2SGcdhgBO5THXOv2D0VIitRiyM7xnjRUUG0T08h1G4xzLFNIP AOkUT9cjnXd+vAhEuR8pYpgZxkpLgR2ocHkXMm+8UJ9zCTsk/xgwxDlSzpAPCpLC f4R0Zos+SzGG/2IcS3trMOaz7TIvtdzBh+sxIvLKlPPGsjsgY5xZz73igsrgMhs9 flF726fnpC91eaS97XpnTskqyKXc8pj9sSLjLXrsYqeyqOgYVRWaCmQfijFthvOi sYk6Q6ptW3eGITKuLOg9dV+uP1iVqnB+6sZuXGo7a6sUTKjGLZfw9lja1qpqRcUJ HVE+qg1eOvHUp93vMN+l5TYiR/qq/AEYFzByAag2Ihj3XIbYdMIA0WWQs98XQqmS pavVv6pz20FDIikctBGz9LdMcCUWRsrn8oM4ZtxHO7+5T1U4zgBS025WMbjwiEtx fXY0eixWDAG/lDrHdwwR4JAfXw43DzEF3BR4Sp2hmfXm9uIDcJfyGKO6fi/Pzg2m xt3lSXOyToLamGcgFOV0oe1VAbyP3VpgcgahUjmzRVjDWn88x1U= =iiMe -----END PGP SIGNATURE----- --dpLVsiHpYSrTBlmP--