From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=RWEErdJ+; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 777B65A026E for ; Fri, 19 Jun 2026 05:54:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781841241; bh=iRXzqbVZWgWFCdgC8J8gaTl7xA7iEqIeGc3dM80zQ2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RWEErdJ+fUgDcD2MhUlI6iSmDAytSTOkWLLHf62fui7/gnjZjRgL7kVsoxh0TbkaM tkHhE7ZOvxsxB5lzOybWwmo1UVsF2bxN8bQj6TC/Kvt71EqcR150HgMUvRdEG15Fsd fL0hNO1q+fYc7K4OtIEEFOC3VH/5568KlBGTbOl9spbRLP5rKxS/OHBEvdhp6hASOy f762pCHZzq8h9ZjG/SWuVkH95YoE154oKj78uh76z0U2Aj+XkOCRhjvofFWqbN5mtb nByPB4ND7DxMQEOlZQX5ckTme86/awJDoSLG61l5faIMlD4whd1z5qQwJ2HmU1PZK1 FYruI44r/kmtg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ghNxj711Nz58sl; Fri, 19 Jun 2026 13:54:01 +1000 (AEST) Date: Fri, 19 Jun 2026 13:53:54 +1000 From: David Gibson To: Anshu Kumari Subject: Re: [PATCH v4 4/4] conf: Add --dhcp-boot command-line option Message-ID: References: <20260617132243.1499556-1-anskuma@redhat.com> <20260617132243.1499556-5-anskuma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k/QzVyrAR8+4B9Rj" Content-Disposition: inline In-Reply-To: <20260617132243.1499556-5-anskuma@redhat.com> Message-ID-Hash: AVOMSPOAWIY4BLFKQ4VSAGYWG2EJ2R35 X-Message-ID-Hash: AVOMSPOAWIY4BLFKQ4VSAGYWG2EJ2R35 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --k/QzVyrAR8+4B9Rj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 17, 2026 at 06:52:38PM +0530, Anshu Kumari wrote: > Add a convenience shorthand --dhcp-boot FILE that sets the boot file > name (DHCP option 67) for network boot. This is equivalent to > --dhcp-opt 67,FILE. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D192 > Signed-off-by: Anshu Kumari Reviewed-by: David Gibson > --- > v4: > - Changed argument name from URL to FILE in usage and man page. > - Fixed UEFI HTTP boot wording in man page >=20 > v3: > - case 32 now calls dhcp_add_option(c, 67, optarg). > - Handles duplicate codes: --dhcp-boot and --dhcp-opt 67 coexist > correctly, last value wins. >=20 > v2: > - Removed separate dhcp_boot[PATH_MAX] field =E2=80=94 --dhcp-boot foo = now stores into custom_opts[] as code 67 (same as --dhcp-opt 67,foo) >=20 > --- > conf.c | 5 +++++ > passt.1 | 7 +++++++ > 2 files changed, 12 insertions(+) >=20 > diff --git a/conf.c b/conf.c > index 836b297..f100e0b 100644 > --- a/conf.c > +++ b/conf.c > @@ -618,6 +618,7 @@ static void usage(const char *name, FILE *f, int stat= us) > " a single, empty option disables the DNS search list\n" > " -H, --hostname NAME Hostname to configure client with\n" > " --fqdn NAME FQDN to configure client with\n" > + " --dhcp-boot FILE Boot file name for network boot\n" > " --dhcp-opt CODE,VAL Set DHCP option CODE to VAL\n"); > if (strstr(name, "pasta")) > FPRINTF(f, " default: don't use any search list\n"); > @@ -1258,6 +1259,7 @@ void conf(struct ctx *c, int argc, char **argv) > {"migrate-no-linger", no_argument, NULL, 30 }, > {"stats", required_argument, NULL, 31 }, > {"conf-path", required_argument, NULL, 'c' }, > + {"dhcp-boot", required_argument, NULL, 33 }, > {"dhcp-opt", required_argument, NULL, 34 }, > { 0 }, > }; > @@ -1496,6 +1498,9 @@ void conf(struct ctx *c, int argc, char **argv) > die("Can't display statistics if not running in foreground"); > c->stats =3D strtol(optarg, NULL, 0); > break; > + case 33: > + conf_dhcp_option(c, 67, optarg); > + break; > case 34: > comma =3D strchr(optarg, ','); > if (!comma) > diff --git a/passt.1 b/passt.1 > index ccdcbb2..f2341ef 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -430,6 +430,13 @@ Send \fIname\fR as DHCP option 12 (hostname). > FQDN to configure the client with. > Send \fIname\fR as Client FQDN: DHCP option 81 and DHCPv6 option 39. > =20 > +.TP > +.BR \-\-dhcp-boot " " \fIfile > +Convenience shorthand for \fB\-\-dhcp-opt\fR 67,\fIfile\fR. > +Sets the boot file name (DHCP option 67) for network boot. > +For UEFI HTTP boot, the vendor class identifier also needs to be set usi= ng > +\fB\-\-dhcp-opt\fR 60,HTTPClient. > + > .TP > .BR \-\-dhcp-opt " " \fICODE\fR,\fIVALUE\fR > Set DHCP option \fICODE\fR (1\-254) to \fIVALUE\fR. The value format dep= ends > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --k/QzVyrAR8+4B9Rj Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmo0vUcACgkQzQJF27ox 2Gf5Mw/+KavnYkCrNi+SmIRTksssf/u9J07jm7S9k2GwK1P+ak/aIqZU5gDjT0hA zPn/nWFBIw4ZIvwE0EaXshysiFt7aQNb5xLnk8mdDayS5ec7r9Wbl4rqo62t66+M IDJNkFsOo9NEqIfKi6/OEw7ZPBbnFVZ8pG3cadwdwokJZUDr3+ZClI0stasYn8il oZrgr5MD0SH4s7Xg5/Ww7VG+BP3jXGgaNoeK40NhA84WelUa2t9Zpm9EuuecLzv6 Du8jRtuyzXHr8q2/wqITBeA/EBMNumny0wB4qi0PCwmzIKVwRystbWsAWOpNM+RY s+HvdBae1r3xOxw0TNtjI0Ve3ppxKvOK5y9m4bm8TiqUpvFDrp4hvumOtp+Y0iZz DDQgl8eDfogiGoSx87igN05t2nOWq9mTNJSjeZXHOm7wKMQfgLcZ+MjJNXW6jMGa NlNIfP4jnMrofnpL1Ic2LbYzaSkoTndIUfDqPfpcKY/lBcRq1kUeK3WPPNWRyZQ9 UmVY2TEY0dr8i7+ADlUdcmZ/K4Bq1z6GMffXLkCYG7Ot5SbvboukIQloBAvmFId3 ydUiu+WJR9qppkDdGzpEgZXjvodEAIoCDK3iGjid38Jss2BrVwBK8k+vWUl2AY/G rfUxniVLuOR5aorIucAiqBY5oIcPSCT1wzFMZKErNqnjgTPQQ1k= =I7CC -----END PGP SIGNATURE----- --k/QzVyrAR8+4B9Rj--