From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=OkMYNIma; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id EA7585A0265 for ; Fri, 19 Jun 2026 07:37:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1781847437; bh=o3fCYUXcda9yh4Y3duhL9tAgTDmFGIdpS2Dg8epxmMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OkMYNImaUgZCjLGxxXBbYThmbHQjNXh8j7nDW/9ONELOeSBLP99wAN9S23/1RHi2f cuw5XJjM4ksZAkZChhC4K1lcQeiLuDuYqI6z5oKpnNAYHYMd507FzxZcotapzj6FD2 evkEByJsBvPjKOINr2Y/IBZmMOPJGxhN127HOX0HEg7cSsSAFFNYc//Ct0JmIn5Xjc oNPWchJPGYwrk9mtotccKaNFQ2iR9IaKWdIHj1gmJK6YbXWcDKtRi7BI81lJChKP2G Ozl1Cg7nRZv9wzReNhtMOVXb2lIFMXLU3Yr9shrtxSGWyVOuEh9/z5Ol7RRTSCpsvb IMWIUEC3GSOqQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ghRDs0lCkz58sw; Fri, 19 Jun 2026 15:37:17 +1000 (AEST) Date: Fri, 19 Jun 2026 15:37:11 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v5 04/12] tap: Thread queue pair through all remaining tap paths Message-ID: References: <20260616125130.1324274-1-lvivier@redhat.com> <20260616125130.1324274-5-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FXY2/G8CNsWplMkb" Content-Disposition: inline In-Reply-To: <20260616125130.1324274-5-lvivier@redhat.com> Message-ID-Hash: YQDXUYAZK73GKOWWO237E7SYHKVQPWOO X-Message-ID-Hash: YQDXUYAZK73GKOWWO237E7SYHKVQPWOO X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --FXY2/G8CNsWplMkb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2026 at 02:51:22PM +0200, Laurent Vivier wrote: > The previous commit threaded queue pair through vu_send_single(). > Extend this to every other tap entry point: tap_send_single(), receive > handlers (tap_add_packet, tap_handler, tap4/6_handler), send helpers > (tap_udp4/6_send, tap_icmp4/6_send), and connection setup > (tap_listen_handler, tap_start_connection). >=20 > All callers pass QPAIR_DEFAULT except vu_handle_tx(), which derives > the queue pair from the virtqueue index with QPAIR_FROM_QUEUE(). >=20 > The parameter is plumbed but not yet consumed. Subsequent patches will > use it to direct traffic to the correct queue pair. >=20 > No functional change. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson With the exception of one nit.. [snip] > diff --git a/vu_common.c b/vu_common.c > index 8b555ea9a8b1..6aa1ba768136 100644 > --- a/vu_common.c > +++ b/vu_common.c > @@ -200,11 +200,12 @@ static void vu_handle_tx(struct vu_dev *vdev, int i= ndex, > =20 > data =3D IOV_TAIL(elem[count].out_sg, elem[count].out_num, 0); > if (IOV_DROP_HEADER(&data, struct virtio_net_hdr_mrg_rxbuf)) > - tap_add_packet(vdev->context, &data, now); > + tap_add_packet(vdev->context, QPAIR_FROM_QUEUE(index), > + &data, now); > =20 Since the body has grown to >1 line, this should get { }. > count++; > } > - tap_handler(vdev->context, now); > + tap_handler(vdev->context, QPAIR_FROM_QUEUE(index), now); > =20 > if (count) { > int i; > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --FXY2/G8CNsWplMkb Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmo01XsACgkQzQJF27ox 2GddFBAAh4Spa2/OGBie2Ais1croEUOELrAlRCgktu0YAXXX9c/du8xCuFSNlPuO CVW0tWLQ//eHlDRvEci99UnTjxUvBS3ZBFP84fqUfmKSz3chgW0vO981L3b8p2+X +7MzSGvAY/iSCe2TFGrmz/Y+JlLm+nxNedBaCXRTjcttV3bv1wBua3scZ5mRXwgo tKTZGUbhpZu2ZSgt6Zfg7b2doR8u05fq8fVcTXSX6qescbHd196bevFWm67B9y7x HbKhor4RF/T09m1Zt9Ag1VtawnlGLN4NIo7FnW/tKvN6xJbvhNHIx/OtFj6Kqpne EcFVunlEKgWMH1u5yH6hwtdxCBOKsxDlAzisMPOmJmtXdz/0YW0HxkEGC5OeV9v8 GJYzoqAl5qaY8voydYZ/c8iwmXJvetsfScyygbenimgtrzycQUZQOf+5xTNGdGqK YloN1cxBR3KAtB69gZHAiWAuabqko/2IIlZAgmdu8dR1GiNn0OqLyosD+CnlAayw jLU4UGRH+u1QtghkyJ0e9BvJbB7HP66qUIgza/fxd+k83izz8ybpNXcjCdpmdEr7 5bEK/2N84Bh7qQbBCo487Z4iP4CsFNSZywpNSqDIH8sSPSs69Z0R4pwgY9biDnmC xSumfDd3ESYEk3qbpoNbp0FZbo2Sp0fJSbQaStRJkA7DT25xvJU= =Y9zc -----END PGP SIGNATURE----- --FXY2/G8CNsWplMkb--