From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=Ne20qzHy; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 78F755A0265 for ; Sun, 21 Jun 2026 04:42:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782009735; bh=LfwkSsnRubgM+upt7jREuJUhuOOoeYNoYLgIAzT5Nq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ne20qzHyxwh6vSgAn5sJ5pQMQC+NB+9rBrv3fZbq/syUov2BiEVsXNybJByUTrjF+ TCGvhsREx2fowH9dZreKScDTRMCV37Q6lb+HN0pH361cMcIYxmVlUJpKtNgSoY0KRz CvpcVRGCXYa/KTx5rbe/pBQWbyNG1uEnQluK1SnCEacP7/csg1PgD2cq0kFNxFXqwy 8IP21qWd8QMBNmz3tP6Ea43dWoJm7cue0h7yf+OL2y+IHMeV9z2dIwpidqWjyzDRYn jo0CNIgeyj3vN6p76coEQ8/s1MZd/xAw8myOTFQI8UVNw6SqhJnkb1djQ9fZV9nYg6 QrTALyycMftuQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gjbFz5CZsz4wKN; Sun, 21 Jun 2026 12:42:15 +1000 (AEST) Date: Sun, 21 Jun 2026 11:18:25 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH] test/lib: Add --config-net to setup_pasta() Message-ID: References: <20260620200921.1720380-1-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kgouxsXfMTsfjwc3" Content-Disposition: inline In-Reply-To: <20260620200921.1720380-1-jmaloy@redhat.com> Message-ID-Hash: S63TGSVZ4QVZD72BWRJWA26SNCYJWJJL X-Message-ID-Hash: S63TGSVZ4QVZD72BWRJWA26SNCYJWJJL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --kgouxsXfMTsfjwc3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 20, 2026 at 04:09:21PM -0400, Jon Maloy wrote: > Since commit b4dace8 ("fwd: Direct inbound spliced forwards to the > guest's external address"), inbound splice connections target the > guest's external address (addr_seen) rather than loopback. This > requires the namespace tap interface to be configured with that > address. >=20 > setup_pasta() starts pasta without --config-net, so the tap interface > in the namespace is never brought up and has no addresses or routes. > Splice connections to addr_seen fail because the address is > unreachable in the namespace, breaking all pasta TCP and UDP tests. >=20 > Add --config-net to the pasta command line in setup_pasta(), matching > what setup_passt_in_ns() and setup_two_guests() already do. >=20 > Signed-off-by: Jon Maloy No. We use setup_pasta() to test NDP and DHCP behaviour with pasta, so we need it not to preconfigure the network. > --- > test/lib/setup | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/test/lib/setup b/test/lib/setup > index 59945987..dbf8079d 100755 > --- a/test/lib/setup > +++ b/test/lib/setup > @@ -107,7 +107,7 @@ setup_pasta() { > [ ${DEBUG} -eq 1 ] && __opts=3D"${__opts} -d" > [ ${TRACE} -eq 1 ] && __opts=3D"${__opts} --trace" > =20 > - context_run_bg passt "./pasta ${__opts} -f -t 10002 -T 10003 -u 10002 -= U 10003 -P ${STATESETUP}/passt.pid $(${NSTOOL} info -pw ${STATESETUP}/ns.ho= ld)" > + context_run_bg passt "./pasta ${__opts} -f -t 10002 -T 10003 -u 10002 -= U 10003 --config-net -P ${STATESETUP}/passt.pid $(${NSTOOL} info -pw ${STAT= ESETUP}/ns.hold)" > =20 > # pidfile isn't created until pasta is ready > wait_for [ -f "${STATESETUP}/passt.pid" ] > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --kgouxsXfMTsfjwc3 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmo3O9UACgkQzQJF27ox 2Ge+YQ//WZyyy9pANdBNz4bYdWFxoduhyyMHHrF+icJv+5s1jIleRNT7jX6p/oIk S08zlxtObYhWStz6cpdXHCkGO7HN9XSXl2L28PqN7fH5Xbts4L/z9cQT9T2hV45P 84kopttmfgkOvL3IwbJY3fuQzTms2XAQn18ZqSRLlOIoXRWUlOClTDxGMtPWJjCH FlGrVxcOZXK/U0QJ4KT50MSv7/X9vyNkDnSRQea4iJ9GgGY/4Q3IByFfQ9qla2/H oI+vCX7IApZn6JtQgTnFnIje47A7+52ZVVI3XSWBZlK+CU8e4/ynT/OlwSWOBE6i 8Yq9CJ5lSj6tkY+CNf4Z4Uj95y4dSJGEcx9i59OFVo6DNL7d9Xcy2N49efX87tw7 ZqoelbB7azq6rcSORrUUdN1jji8kMosUKC8+vQtO9ppaba8jXFRqVJkYCAyzSuDE GiEtMX5hhfA6B90TKZY1nN6TsohAdjUyaVJFYlZzIEfPAqPtEcwNA4PjWdIHQph9 IUEicm5h62EfuQz6FmlojVxAX9dhfH+u5J81EhYToUQE9Uxk8aRAtsuK7a7wQg5C EVWuFhLogc69vJ1qWwEjbg/cYTRq0pQfFNmUW0mihq0GLzbYYPgyvx4g2/m4UQZt PinTn0jx3wIOTpBEeLoK1jffjbahiy898f47DnyOMlG8QiLZgdk= =GlQu -----END PGP SIGNATURE----- --kgouxsXfMTsfjwc3--