From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=UkDHNc/a; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id F2E2A5A026E for ; Mon, 22 Jun 2026 04:40:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782096000; bh=Wk7ynQWgtrIFQT6ZDY8Wn+w7GuTeIskXfiL9JWz44lE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UkDHNc/aeOzM1ULpLwN6xjKXbP8Fr0qa/4hFldsWDGF6NKmlmgtRHnym3m3UG/wyF e/M8axfyl07G4vcSVs6n0uxWpp0HKeGObLq8vM7vuR6689p/+iQZCHx+Qt81Hk6UZf rTI5slYwMModMCh0TPAeiwEZ+EMZQN1uP1kB4EmucFTa6/sIADPfzD63BJOfyzW6iQ y1ltqjzWj2b8BMYLd73nCix9+F2ZlhnovnevtyN7UDmwiLQDF8d1l5gLPjNfm88N7O QfN+3JzUeOg/CaRCC4HA9pTavHrNwOit6hJXE0mjeZTI/CCxvIpUMCJcnnrPMSpB0s CTS0fo0UKJc+w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gkC8w4T6Lz4wT4; Mon, 22 Jun 2026 12:40:00 +1000 (AEST) Date: Mon, 22 Jun 2026 12:37:28 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 0/6] Improvements to flow specific logging Message-ID: References: <20260619152626.3033033-1-david@gibson.dropbear.id.au> <20260619214351.14f60ee9@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ly0d5BB0FvbVZnIN" Content-Disposition: inline In-Reply-To: <20260619214351.14f60ee9@elisabeth> Message-ID-Hash: YCUKEODKZ3D5UENSGDFDTGXI2XKDZN2I X-Message-ID-Hash: YCUKEODKZ3D5UENSGDFDTGXI2XKDZN2I X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ly0d5BB0FvbVZnIN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 19, 2026 at 09:43:52PM +0200, Stefano Brivio wrote: > On Sat, 20 Jun 2026 01:26:20 +1000 > David Gibson wrote: >=20 > > While working on podman bug 23739, I found some deficiences in how and > > when we report various socket errors related to specific flows. Here > > are some preliminary patches to improve that. > >=20 > > v3: > > * Added a attribute((printf)) for the base flow log function > > * And fixed a couple of bad calls that caught > > * Removed one change from a plain log to a flow-specific log in UDP, > > where it turned out we didn't necessarily have a well defined flow > > * Fixing a cppcheck warning in the process > > * Put an explanatory comment and clang-tidy suppression for the (very > > limited) recursion in flow_log__() >=20 > Applied. That doesn't seem to be the case. Did you forget a push? --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --ly0d5BB0FvbVZnIN Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmo4n+gACgkQzQJF27ox 2GdqeA//TfnXkruNrudQiAHMmHqlii1+2SgbAfvhsfUdim8xM7dCwE/lmeMAFy2M OQcbXEj4BlbLburLlb0BHG37227Ek494fGp+MPJWU4/09jXixa4w3TxIJKEx34yu 9kKBHL4C6eaYEF6ON3kNNVE5rOiHyOBk7my8IVUi02fEL3y/7wHcKuS3F/am30I5 4qFFJXRjYUKz2M5iW/Ng+MbjhRpyz+5GNIxwYyOYwC+rF4hXG6/+4suKgDV0Wd3C lTyrbe9TP/TnASKzV6U4ndrKMpEQWUrHni/Dc2oY5mG7wWa/Q/YyxIk4hrCYcwT3 eanq8Y77gP0nDaOAQloHP/oUIlXqvSS0eVCnEu/KDKkfH3kpVyretUCzhT8ORCqf RhaRnO+Kw3xDMlEBqX2EU3E9EcUhe1clCf9nTgPwG7+mUP3hh1W3cmq4zNvfZVeX Z0wZ6EgqhDu+5wfRM5yIKwdYoJWAzBP82i58ZfvyTnmVXBUroW8J9/ZlqYMUP6JO CDsKhhS8YYWCVfgiLsTDxOkvNwqgjqbBlCw7LFSlLOGXPSUm3t+U/6r8BMmtw/7k nH2zFljxzXJa0J5inbKHXq8wLnwB0OuEpJlDEoGo7h+YYW6FeRsAwOic4l8hYmiT zY8wzAySR5NmurapHppDQ+I7OXP3M/PPZUR5NRUFxAEOmmgii8A= =1KE/ -----END PGP SIGNATURE----- --ly0d5BB0FvbVZnIN--