From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=LjWo/orl; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id D854A5A026D for ; Mon, 22 Jun 2026 05:35:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782099351; bh=GN3E3ojLpE6RHw+o6e1GpHEMiCruUxYD3QZ2YHVfCzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LjWo/orlZWdV5NIUSYrP+9gWtYl5Z1rSOEzjFEnKqtVX2cRywvyoeOwRMLiRxuwHS ZicpaxGhOuJBtSKNwhXwhopFgyEU71R9Lb0ouMrJ3S/+AsmC9HWGqk0vvHNC/wOMJK WmsGgnomXC6784YUd7VQibxnNh+ZOo3VAHNTOob38BlJGesOUlNvViX4eDSA5kwQpx JC4YWDubWWl0alX/MR14QTTe4XRUGZ6hWAg9WJFsCI2hORJAUeqXNRyLcinRJR0u1R V4rNZw/I/Gs4H73Hloc/SJ9MbVLQC9LyA5NRZKEuPH9Ctg0MTEu2dISSR4HiLpRpDx sTV5kdM6gN3XQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gkDPM5mnXz4w9T; Mon, 22 Jun 2026 13:35:51 +1000 (AEST) Date: Mon, 22 Jun 2026 12:43:46 +1000 From: David Gibson To: Anshu Kumari Subject: Re: [PATCH v4 2/4] dhcp: Add option overload Message-ID: References: <20260617132243.1499556-1-anskuma@redhat.com> <20260617132243.1499556-3-anskuma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JAc/a06dFF3ECPNK" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 3FHNF3OY2B5AN7VJBZT4NXREZSVBVKIY X-Message-ID-Hash: 3FHNF3OY2B5AN7VJBZT4NXREZSVBVKIY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, jmaloy@redhat.com, lvivier@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --JAc/a06dFF3ECPNK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 19, 2026 at 01:25:18PM +0530, Anshu Kumari wrote: > On Fri, Jun 19, 2026 at 9:24=E2=80=AFAM David Gibson > wrote: >=20 > > On Wed, Jun 17, 2026 at 06:52:36PM +0530, Anshu Kumari wrote: [snip] > > > @@ -178,17 +243,25 @@ static int fill(struct msg *m) > > > * Put it there explicitly, unless requested via option 55. > > > */ > > > if (opts[55].clen > 0 && !memchr(opts[55].c, 53, opts[55].clen)) > > > - fill_one(m->o, OPT_MAX, 53, &offset); > > > + fill_one(m->o, size, 53, &offset); > > > > > > for (i =3D 0; i < opts[55].clen; i++) { > > > o =3D opts[55].c[i]; > > > if (opts[o].slen !=3D -1) > > > - fill_one(m->o, OPT_MAX, o, &offset); > > > + fill_one(m->o, size, o, &offset); > > > } > > > > > > for (o =3D 0; o < 255; o++) { > > > if (opts[o].slen !=3D -1 && !opts[o].sent) > > > - fill_one(m->o, OPT_MAX, o, &offset); > > > + fill_one(m->o, size, o, &offset); > > > + } > > > + > > > + *overload =3D fill_overflow(m, has_bootfile); > > > > Is there a particular reason to put fill_overflow() in its own > > function, rather than just inline here? > > >=20 > There is no particular reason. I just thought it would be better to > have a separate function for option overload (may be for better > clarity). Ok. I think the overall flow - try to fill this field, then this field, then this field - would be a bit clearer if it were inline. Not a big deal though. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --JAc/a06dFF3ECPNK Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmo4oWEACgkQzQJF27ox 2Gf32w/7BQmrS4I/i0mKfOaXjzqI27RWpdXdpVWX/NwXDincvoMTMIqd9f4Rb0df O48n5RFtVO7MCUPP1jgGVrmSGmpEmalF/q2m9MQHNrgi3Ogt588kVv0N6rhbnUis MZQyENcmg10uJUEfXmF6C8JAtSw2U3mC7ML+naHKGJVosx0s1FhVnE+l/5JJ5JxQ Midz6r8ALx+fEXko52onb7wlR7Ch9utvOmQuK3+MgGmQj5h1GkTdLo4wJSG1I24h 3pnuOpj+VOBTNUM+Yg97AjMHcsTZCI0BoLVQRxgZ/Rupk5Z2jT2R3t6gcOyUpzuv yk+yaatKxnl8BMc4oh5XVSJ7rhi32QIBTf5zQeARNDgVJzSn6fOsI7eGqPaAmtso jxbxsUKX+BukhyvDM+APAWtjxAMldT6OYF6pVjP0qPHibAB9A+RlVEupEoKao3Q5 yuHSdnAdKitKGrTUbemTFGPuSYSX00sYzQs30F4EZ1icViVOlRteMOnRScmRawVJ bwaWAKJfuTszYvslOHfziH4f2ju9TeKwrhPAvtJctOeBXpl4eysKsO9fVVQPKdWR ws56a49XzX5IL0DJmJl+dKP229Cn/yX/N3NfzpeyZOssj36M/hVTEsjD/scZysGX u2Br5mPK3xQR5B7H/hb1D3R2MGFJjtq9sJIRJxrU4ue8NeMSW+Y= =Y8MU -----END PGP SIGNATURE----- --JAc/a06dFF3ECPNK--