On Wed, Jul 08, 2026 at 06:31:57PM -0400, Jon Maloy wrote:
> fd_tap_listen, fd_control_listen, and fd_repair_listen are file
> descriptors and should be initialised to -1 rather than the implicit
> 0, consistent with the other fd fields in passt_ctx.
> 
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/passt.c b/passt.c
> index 65a07d72..4e5b9289 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -65,6 +65,9 @@ char pkt_buf[PKT_BUF_BYTES]	__attribute__ ((aligned(PAGE_SIZE)));
>  struct ctx passt_ctx = {
>  	.pidfile_fd		= -1,
>  	.fd_tap			= -1,
> +	.fd_tap_listen		= -1,
> +	.fd_control_listen	= -1,
> +	.fd_repair_listen	= -1,
>  	.pasta_netns_fd		= -1,
>  	.device_state_fd	= -1,
>  };
> -- 
> 2.52.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson