From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=BDCDHLq4; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 38FF75A0262 for ; Thu, 09 Jul 2026 04:42:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1783564946; bh=YYYJj9BZ95oRKekfsKXnXZhCY/A0cPQuXFfZcri/q1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BDCDHLq48vxdBsmAKtjxvzd4SKcP5R2lJYPZ3NzVsEFCyWCAQfiMNmH1x4bP4zqo5 nKDPDot1yDmSd2Oh8ejadIBP7a3JtCH+Pm2j951WE0i2DsN2yEfffTwQTPYk7HKU5N 5377crbR0iGD3gZzrNhvKqgSu66A9epB7w+OejCqPkC3bmPZ17ecAq9YKMJjRNXFaI Ev493eODpX/JXSgqSK57blZU7syeDL5jXxGymrgZsIFciBE7atWUF4dUXOKf9Q1q6a C4bnp6CxF/YENRWsZJ51I4dMLyZtJtUtDrfpmDA6nSa1Z14QEolF3mE60o8IM92CWV ql9gFigxgD6Dw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gwfPt6gxzz4w8x; Thu, 09 Jul 2026 12:42:26 +1000 (AEST) Date: Thu, 9 Jul 2026 12:09:41 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH 1/7] passt: Initialise listening socket fds to -1 Message-ID: References: <20260708223203.885345-1-jmaloy@redhat.com> <20260708223203.885345-2-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8QK9IzMDHPWjkDe3" Content-Disposition: inline In-Reply-To: <20260708223203.885345-2-jmaloy@redhat.com> Message-ID-Hash: WLVXXVCB44NJU6ZNFC3LI5WZUIXTSRV3 X-Message-ID-Hash: WLVXXVCB44NJU6ZNFC3LI5WZUIXTSRV3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --8QK9IzMDHPWjkDe3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 08, 2026 at 06:31:57PM -0400, Jon Maloy wrote: > fd_tap_listen, fd_control_listen, and fd_repair_listen are file > descriptors and should be initialised to -1 rather than the implicit > 0, consistent with the other fd fields in passt_ctx. >=20 > Signed-off-by: Jon Maloy Reviewed-by: David Gibson > --- > passt.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/passt.c b/passt.c > index 65a07d72..4e5b9289 100644 > --- a/passt.c > +++ b/passt.c > @@ -65,6 +65,9 @@ char pkt_buf[PKT_BUF_BYTES] __attribute__ ((aligned(PAG= E_SIZE))); > struct ctx passt_ctx =3D { > .pidfile_fd =3D -1, > .fd_tap =3D -1, > + .fd_tap_listen =3D -1, > + .fd_control_listen =3D -1, > + .fd_repair_listen =3D -1, > .pasta_netns_fd =3D -1, > .device_state_fd =3D -1, > }; > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --8QK9IzMDHPWjkDe3 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpPAuQACgkQzQJF27ox 2GcHFg//axiIEGEJsEkZ2NSSVn36+KOjWFKijtHFc/G2tLOb3/zap8+yh/DSDmQu UW/5b4sYLeF5y8DUVhwmMvNC8fBPT6c49veZ+a07NgGrveEHbApds22dROiwCo/f geV0FEDrd/MPCvZwonS6mZvLT0pIsQKGS93A+Nw5kOfwJ99BHmmWCQU6CnkC9eEM PjwnpTEqhs/A/Phg/8FnFKbuMZuLGf93sRFrXoQCMsqid0wMiijoMJ+4nio3DCwX ZIzBmqnT29zlr69q0pBoktVpCzdH/MqhTA5piF/fj5LtIbv9Coo+oqhScfX+njDa iwVX6C1efJmfwMYnLs3hBGUo3Ui22m9Qy6gr4bJWNxWTmBupimh3swJKYTRvVFbC A4ukoai2knMfdGlAOYRENazVAQPIudj+yVRHFKJmKLRiKCpEbgKFAho39/HEKSWD qqRF6XQ8RKu7iy090B8kAzLAR/5oRoz20ADdESMwkOCeiZDHX7UDP0A/bFZvcFyZ zr5WnQWrzQQ6mxHZljnS2ihAaK52Z9ZE/62dVAZHktsWGhiX/tesmXGNqUx+3T3s Rkj4gB5DiAzNJEZ6huXN4lpp/u0kkZNepp7YIo64WZBMqnj4iJ9LPwfCRIs9Qvcj MVRZG+rywvyhbEYxpsmWimzgm6aoPg7kKk6zakpWJE3PouH/Csg= =ycSc -----END PGP SIGNATURE----- --8QK9IzMDHPWjkDe3--