From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=D7F7JO4g; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 0FD6C5A0271 for ; Thu, 09 Jul 2026 04:42:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1783564946; bh=w0TLl45xHU9m+mJLYqRTr6UaY4VvvZeWslRCi+ZFSK8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D7F7JO4gpElceQWgPfz6kI09rKOAO1o8YPkDToWzqmjsYeR0+efd1GkfhDIf3dkzs KYMpHjXT84nqdIjurE12aVliI5o8+33sif7mON5jmj18slQTbIb3AsK4Hw9c6P0oTl V+tMz+3hNa/PxDmRi/ip4Ua1K4IXhmNdbIUPKqmSJ4vp6EbySohKthoGsm9Oe2BRpr dxM9hJEA6OKYXcksIHU67+GNiaZnhX5AYI6yC5PwvP9H/gzJgSzMoi1q1kEwpwPlnX nQ/yoW5/7tloEx3pLqvOULaedr7GHdOAYdyEg6DI/J+KFEKFZKDVgPTwOlqn/5x5hE jvrPlrnYfKB5Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gwfPt6T9Jz4w9j; Thu, 09 Jul 2026 12:42:26 +1000 (AEST) Date: Thu, 9 Jul 2026 12:09:11 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH 0/7] Fix issues and false positives in code coverge tool Message-ID: References: <20260708223203.885345-1-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+8lz+9sF3PyxBLmh" Content-Disposition: inline In-Reply-To: <20260708223203.885345-1-jmaloy@redhat.com> Message-ID-Hash: JRUTP7BS3A6DY67BSDWF3RL5HAJTND4G X-Message-ID-Hash: JRUTP7BS3A6DY67BSDWF3RL5HAJTND4G X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+8lz+9sF3PyxBLmh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 08, 2026 at 06:31:56PM -0400, Jon Maloy wrote: > This series fixes minor issues found by code coverage tools in the > main passt code and in documentation examples. Nit: If you're talking about the tool I think you are, it's not really a "code coverage" tool. Static anlaysis, sure, but "coverage" implies it's about measuring the amount of the codebase tested in some way. > The core code changes addresses missing fd initialisations and > explicit invariant checks for unsigned arithmetic. >=20 > We also fix address buffer handling, type mismatches, uninitialised > variables, and resource leaks in the documentation example code. >=20 > Jon Maloy (7): > passt: Initialise listening socket fds to -1 > udp_vu: Assert iov_tail_clone() return before assigning to msg_iovlen > tap: Assert IPv6 tail size before subtracting header length > doc/migration: Use strncpy() for socket path and fix argv access > doc/migration: Fix buffer type mismatch in recv() call > doc/platform-requirements: Initialise va_list before va_start() > doc/platform-requirements: Close leaked sockets in test_close_dup() >=20 > doc/migration/source.c | 2 +- > doc/migration/target.c | 10 ++++------ > doc/platform-requirements/common.h | 2 +- > doc/platform-requirements/udp-close-dup.c | 3 +++ > passt.c | 3 +++ > tap.c | 4 +++- > udp_vu.c | 7 +++++-- > 7 files changed, 20 insertions(+), 11 deletions(-) >=20 > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --+8lz+9sF3PyxBLmh Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpPAr4ACgkQzQJF27ox 2Gf65w/+In76KQ6yGhoObYYGue+Npn/Xozf1ZgS3XXpjeRDo2Ci1+svlAzdO9PuR DhfE3GaEIcMOMa1Eu4zJqzkVUt6VXaaMUFkSgRhm4fyJY8qQvG69C/IYbCmpMmRc P0738W/pW/WdgFvwlWfqrCgjfCZL1I/oZjrKN6toef5XvDJPmWZvFNf6xwbGVW56 wSYR6N5mBXdLn6pj75ApMJVFK4G4lWFRj90/XmER5h3CVS/Le+iUY2CTSuu8Rzzz UE+MnaSqJ94ia0zPHsrYWjje5Rjd9kcp+FzaxSiKA2YniM1TTMQWf935Jm4PGnap Lx9gfVFwDEJhlMy7AN7zu67GTdkZ6kMnc4wedjkWxrukLfpJNsoalph/hx3QGGsv oj+1SyEySiLvye+hrpUTInpVa++zVxa5xYsLLGgqk9V+E6fP2I+0JKZSvo9r8PQt YHi7nlBzK7wnfNjvMrfPGFaC7ZG4IvuTpA3kdFvSCfICC7jXZeOrUizml7PYyXm0 Dv564hsbBdxnc/c5rrO/kdZ3XNe2fnrAqfeEn3Om0OFjRVxpIsijHbawa75uEmd6 PzG8uIAdpkRZuL3ZmJ51Sj0wufaAGGiYrxzhGrFj0PTxVa+MiTYZAPl83v6pDtyI 0X2u45fzJcyV3rJmADx3sBEqSsRSZSwAnw3NJywnqzlyxSBtI7g= =oV8c -----END PGP SIGNATURE----- --+8lz+9sF3PyxBLmh--