From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=lfVlT2rb; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5172E5A026D for ; Wed, 01 Jul 2026 05:03:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1782875034; bh=IutAyoHl5124hnlPm20vmu0e4d6rARZ0uNBAdGzF4lE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lfVlT2rbKcrMdYHd2NQQIXaymKxG0y7M38Wb0Hh8EpmgSx41lgAtXn4qEpF51fWGY 7LBdsiIwZdvgC12E1ORlUVp0aEg9rg5TTvWcrqQ7a7kEFV8l19WgX+XlW4oXKNF8jN tDxX1tE4JZ6Ua1MDEtCIbxAciPTRJOWsYp3UKIN3gCmSozd4zzqLdM8EwLbOrrHLsE ApbFBizzb6c6wcqZUZKXddVvqIhhlJvrQGf+CqYzsE+zrTVdR9rDynaEzOmYUMZ1QR q0I6N6GeqdBUT9ZGsEzZ1OZDkyaHazcH6kylSptaI9nOhiCWk5c6avqDtsQCSs0I6/ 7DpvVqskfEOPQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4gqlGL3B5Tz4wTc; Wed, 01 Jul 2026 13:03:54 +1000 (AEST) Date: Wed, 1 Jul 2026 11:23:26 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 01/12] Makefile: Add missing PESTO_HEADERS variable Message-ID: References: <20260626071003.3472194-1-david@gibson.dropbear.id.au> <20260626071003.3472194-2-david@gibson.dropbear.id.au> <20260701020700.392d6ac6@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lx7wanjqfLH4cDQy" Content-Disposition: inline In-Reply-To: <20260701020700.392d6ac6@elisabeth> Message-ID-Hash: HQZW5QF6GIEYSRDNYCQUY5NMEDSBFNE4 X-Message-ID-Hash: HQZW5QF6GIEYSRDNYCQUY5NMEDSBFNE4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --lx7wanjqfLH4cDQy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2026 at 02:07:01AM +0200, Stefano Brivio wrote: > On Fri, 26 Jun 2026 17:09:52 +1000 > David Gibson wrote: >=20 > > In several places we use a PESTO_HEADERS variable, with all the headers > > that we need to build the pesto binary. However, we never define it. > > This looks like an error introduced by a bad rebase of the series > > introducing pesto before it was merged. >=20 > Oops, yes, I just found that in a patch reject file. And I just > discovered that a Makefile variable that's not defined happily expands > to nothing, I wasn't aware of that. Yeah :/. Classic gotcha. > > It turns out the fact we didn't list the headers was the only reason we > > weren't getting unusedStructMember cppcheck warnings for pesto as we > > already do for passt and passt-repair. So, reinstate that suppression = for > > pesto as well. > >=20 > > Fixes: 02236db32625 ("pesto: Introduce stub configuration tool") > > Signed-off-by: David Gibson > > --- > > Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/Makefile b/Makefile > > index e8170e90..5ed0f702 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -55,6 +55,7 @@ PASST_HEADERS =3D arch.h arp.h bitmap.h checksum.h co= nf.h dhcp.h dhcpv6.h \ > > virtio.h vu_common.h > > QRAP_HEADERS =3D arp.h ip.h passt.h util.h > > PASST_REPAIR_HEADERS =3D linux_dep.h > > +PESTO_HEADERS =3D bitmap.h common.h fwd_rule.h inany.h ip.h log.h pest= o.h serialise.h > > =20 > > C :=3D \#include \nint main(){int a=3Dgetrandom(0, 0, 0)= ;} > > ifeq ($(shell printf "$(C)" | $(CC) -S -xc - -o - >/dev/null 2>&1; ech= o $$?),0) > > @@ -203,7 +204,8 @@ CPPCHECK_FLAGS =3D --std=3Dc11 --error-exitcode=3D1= --enable=3Dall --force \ > > else \ > > echo ""; \ > > fi) \ > > - --suppress=3DmissingIncludeSystem > > + --suppress=3DmissingIncludeSystem \ > > + --suppress=3DunusedStructMember > > =20 > > cppcheck: passt.cppcheck passt-repair.cppcheck pesto.cppcheck > > =20 > > @@ -212,10 +214,8 @@ cppcheck: passt.cppcheck passt-repair.cppcheck pes= to.cppcheck > > $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^ > > =20 > > passt.cppcheck: BASE_CPPFLAGS +=3D -UPESTO > > -passt.cppcheck: CPPCHECK_FLAGS +=3D --suppress=3DunusedStructMember > > passt.cppcheck: $(PASST_SRCS) $(PASST_HEADERS) seccomp.h > > =20 > > -passt-repair.cppcheck: CPPCHECK_FLAGS +=3D --suppress=3DunusedStructMe= mber > > passt-repair.cppcheck: $(PASST_REPAIR_SRCS) $(PASST_REPAIR_HEADERS) se= ccomp_repair.h > > =20 > > pesto.cppcheck: BASE_CPPFLAGS +=3D -DPESTO >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --lx7wanjqfLH4cDQy Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpEbAQACgkQzQJF27ox 2GdgYg/7B7SmW6Fjl7lKQs0FrQ2ltuoV72cPd1OQLuoW+mZ3OaSQ5NsG799ETbAq +ddrCU8rUNk0zbMa8gBp4zBmgXBPa4EQUAa9EdU0Pk69nmYgVHRu0uzFGIp4sDIL 4MwKd1w2z0p61a1yPSIdyIpVJ+juzm3W5hsgziCdER49mBihiwXOhS8Hw0gRteLY 5tPtGQyCh0qVI2p4adeJ9pbSyMVdgVsWtPvgzxmhnyQD0iVQGrdMNzKhP2X4wPnx qlUISrDmnYVpAxEcUKasrLBjaYw+/RWzrGDFfA4ojMnU+BwMBPojDD64ZNgPOA1t EOBth4BqSdfIXlSfxhgqceRedMAyp78SEWGyK31zfTrxsoe0YkBQ/xmbI96OeuLc 8AejsBVFiswV9UDlAwAZRfFh4qzmqPHXQvBixugvhmRm1oq/No8/gsl+DgJ8L5bq v/i006f7E55gpTcPB305IWRcuHfYeJ+qQOsahhWXIJZMkGd+v+/s7NKr39qzQRq/ d+zOUpdStTkEk8D/tWB9QfriPWZ1s7b3E44kQ+Wv767IdeBw2wyPUFBJ2LKEum53 6TjU8L6s4wZqxrXkuol9Nn4WcvbRrg8sdvcp5Hp6jZiE/EplsCaiW9M5oUIgbEy7 Bm17ysaqBN340xHGI0ZY0QCd+pNbgT1nocnqO5QQLPNgbkko44E= =QW0H -----END PGP SIGNATURE----- --lx7wanjqfLH4cDQy--