From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202606 header.b=ZAQq788K; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1370B5A0274 for ; Wed, 22 Jul 2026 07:16:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202606; t=1784697407; bh=LlH0xg6uEjGJPNOwGlf2UkV8jvR8t0S7TE4oRHqOLlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZAQq788KzNqOSL8RpPK1PToNvyZB3PcHB2/S0tlGbyxG+v114F5qnrLMm2oo/KuVi Y3MUDKPU4/DbDY+eFvvIn+LhoYkI/xupxuv/xbpUBm39Kn/3VWmyouFgD50gOBBwr8 6rPvbK2GKs3SJ5ypay6L1vh2NX5Xs3OPHz6Bnm+njQGN27f37uqq7+Vu69uHXe+VaC fYbReHmmeLIKOeIHxkEFUS1DyWAFRyHQxDvwPdfhtwc9X/78RZ52WlJXvLaN6sDJQm 8flZIuESr9cCI1yq9gfwr2K4qowln6WZurMEDlqyRwMQcRH7LYh2CsmnnFTTKROwiR mvOgExdVgraBw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4h4jCz37qwz4w1b; Wed, 22 Jul 2026 15:16:47 +1000 (AEST) Date: Wed, 22 Jul 2026 14:18:12 +1000 From: David Gibson To: "Dwayne B. Bent" Subject: Re: [PATCH 1/2] pasta: Regression test for bug 216 Message-ID: References: <20260721153727.2173831-1-dbb@dbb.dev> <20260721153727.2173831-2-dbb@dbb.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GWbLQ0Jq19B6Mbv8" Content-Disposition: inline In-Reply-To: <20260721153727.2173831-2-dbb@dbb.dev> Message-ID-Hash: AGYELM5O26KJLGXNTGDZFPCYBI5HLSLU X-Message-ID-Hash: AGYELM5O26KJLGXNTGDZFPCYBI5HLSLU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GWbLQ0Jq19B6Mbv8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 21, 2026 at 11:37:26AM -0400, Dwayne B. Bent wrote: > Adds a test that asserts that when pasta is invoked via `unshare -r` in > standalone mode with `--netns-only` it does not print any warnings, and > the command executes successfully. >=20 > Assisted-by: Codex:gpt-5.6-sol > Signed-off-by: Dwayne B. Bent Content LGTM, however there's a detail in the packaging: Although having the test before the fix is obviously the right order while developing and testing it, for final merge we want the test either after the fix, or folded into the same patch: that way we don't risk breaking future bisects. > --- > test/pasta_options/netns_only | 19 +++++++++++++++++++ > test/run | 1 + > 2 files changed, 20 insertions(+) > create mode 100644 test/pasta_options/netns_only >=20 > diff --git a/test/pasta_options/netns_only b/test/pasta_options/netns_only > new file mode 100644 > index 0000000..197ed44 > --- /dev/null > +++ b/test/pasta_options/netns_only > @@ -0,0 +1,19 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > +# > +# PASST - Plug A Simple Socket Transport > +# for qemu/UNIX domain socket mode > +# > +# PASTA - Pack A Subtle Tap Abstraction > +# for network namespace/tap device mode > +# > +# test/pasta_options/netns_only - Check --netns-only handling > + > +htools unshare grep > + > +test --netns-only skips id mapping configuration > +set OUT __STATEDIR__/netns-only.out > +set ERR __STATEDIR__/netns-only.err > + > +passt unshare -r -- ./pasta -q --netns-only -- echo TEST > __OUT__ 2> __= ERR__ > +check grep -qx TEST __OUT__ > +check [ ! -s __ERR__ ] > diff --git a/test/run b/test/run > index f858e55..c4073cc 100755 > --- a/test/run > +++ b/test/run > @@ -85,6 +85,7 @@ run() { > =20 > setup pasta_options > test pasta_options/log_to_file > + test pasta_options/netns_only > teardown pasta_options > =20 > setup build > --=20 > 2.55.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --GWbLQ0Jq19B6Mbv8 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpgRH0ACgkQzQJF27ox 2GcVzxAAlvdwFWWd+H+LolZfJ01Es9VTQ+iZwSy/b35Olrx5ZwRpbYtw7X0Ie1/S 3MRhzTTOxV8o+L6Hf0FDApEWaKXtghzVa997Vx2TnVXLy3r8uK1a6Tu6fSzBJi8k 2QY2NgfZurn/na2F0KaFNnrO11SU67AFxrf8vETmBSkPWBoQAQNUw4pT1k1xAQAQ QwiYNcAeezShUz6noFWizViMd/mSznqOD/7SU4rOoyl2mRIwaXUeJp0JTCEV0CiQ FHow6kzyZbHuIVF9KmzjE3yDT+G7V+O+DPF0WqR0Lxhj33bhLr8/FR9NtjYsq6Sz E+CpBpgAhjZMIH/R2gmiDthXBD2GLLL/rf+MHKBAV276eSBAwjOppn1EYVmDUSpR gDR6hdKBQCXCVvi5S91ZO/EhmbSX5wZKZmtxk4fGWUpit5RmuVq5a+7FJ1ighZuU zZ69lLJ98hGng2aogEBejthE6VhV+yEc3sMqWIca6nhqwXnEj7ircMSxFg6haQbT AOiL4yoLUETdkXFh47P+zbBP1yMTsHTTY6a+KW11n7IeIfpK/lzTK6dEva0UlR7H P7liTAishe11B+aDuoYjhdnwksFKCS6TbN2OHkali/G4znxJPpTsKNWLWUrcogmz n7VFjYuIC74uaODC/31I2eYvk7gVn905srbegDLpgy1nZ+4pyeA= =+60f -----END PGP SIGNATURE----- --GWbLQ0Jq19B6Mbv8--