From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202608 header.b=ilRwlVya; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id B0AB65A026D for ; Mon, 03 Aug 2026 05:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1785728795; bh=47s6R8huNbUywDjy2vu73DKKVrqiFR+vq/uLzLLx+Sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ilRwlVyaDXnStrskAdZRdWZv0j9/mE6oVxQOPf1W8bOwx/V2lACEA47RWl52/CsJ+ kPAU4U/W+AmkukF+G5JgFYht8PgYDbwFrW3quAMamfIo8Hs9bOEg4bfJqoSEq0fKzH qT/zU1Rv+2rWrpy3a04AJntc82rJ7KLGREevIAsZl7u1vqj1LuB3Z+9G6P6geY59dp HInz52Zl9FdfsoHQubFPv+tGSh5xkjSmhBHBM1awFaWnYsw/rmPjvi9KKL3O+m8OBd acivHZkQIKpRIzGu+jDC6/bAJwtWX0QC0MM/jqz+RzCI/HA5ugW/H/xPQqtl4HOKsK 7ifkOB/TCP2mw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hD2fM1Cfcz4wCB; Mon, 03 Aug 2026 13:46:35 +1000 (AEST) Date: Mon, 3 Aug 2026 13:10:14 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v6 04/12] tap: Thread queue pair through all remaining tap paths Message-ID: References: <20260731161617.3550626-1-lvivier@redhat.com> <20260731161617.3550626-5-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aJvyPDcGpzl3Fm2e" Content-Disposition: inline In-Reply-To: <20260731161617.3550626-5-lvivier@redhat.com> Message-ID-Hash: XYHI2NVGGUP5CQR34STCL4YN2LJBDWEQ X-Message-ID-Hash: XYHI2NVGGUP5CQR34STCL4YN2LJBDWEQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --aJvyPDcGpzl3Fm2e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 31, 2026 at 06:16:09PM +0200, Laurent Vivier wrote: > The previous commit threaded queue pair through vu_send_single(). > Extend this to every other tap entry point: tap_send_single(), receive > handlers (tap_add_packet, tap_handler, tap4/6_handler), and send > helpers (tap_udp4/6_send, tap_icmp4/6_send). >=20 > All callers pass QPAIR_DEFAULT except vu_handle_tx(), which derives > the queue pair from the virtqueue index with QPAIR_FROM_QUEUE(). >=20 > The parameter is plumbed but not yet consumed. Subsequent patches will > use it to direct traffic to the correct queue pair. >=20 > No functional change. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > arp.c | 6 ++--- > dhcp.c | 3 ++- > dhcpv6.c | 6 +++-- > icmp.c | 6 +++-- > ndp.c | 2 +- > tap.c | 65 +++++++++++++++++++++++++++++++++-------------------- > tap.h | 19 ++++++++-------- > tcp.c | 2 +- > udp.c | 4 ++-- > vu_common.c | 7 +++--- > 10 files changed, 72 insertions(+), 48 deletions(-) >=20 > diff --git a/arp.c b/arp.c > index bb042e9585a3..e97c4de86a99 100644 > --- a/arp.c > +++ b/arp.c > @@ -112,7 +112,7 @@ int arp(const struct ctx *c, struct iov_tail *data) > memcpy(resp.am.tha, am->sha, sizeof(resp.am.tha)); > memcpy(resp.am.tip, am->sip, sizeof(resp.am.tip)); > =20 > - tap_send_single(c, &resp, sizeof(resp)); > + tap_send_single(c, QPAIR_DEFAULT, &resp, sizeof(resp)); > =20 > return 1; > } > @@ -148,7 +148,7 @@ void arp_send_init_req(const struct ctx *c) > memcpy(req.am.tip, &c->ip4.addr, sizeof(req.am.tip)); > =20 > debug("Sending initial ARP request for guest MAC address"); > - tap_send_single(c, &req, sizeof(req)); > + tap_send_single(c, QPAIR_DEFAULT, &req, sizeof(req)); > } > =20 > /** > @@ -202,5 +202,5 @@ void arp_announce(const struct ctx *c, struct in_addr= *ip, > eth_ntop(mac, mac_str, sizeof(mac_str)); > debug("ARP announcement for %s / %s", ip_str, mac_str); > =20 > - tap_send_single(c, &msg, sizeof(msg)); > + tap_send_single(c, QPAIR_DEFAULT, &msg, sizeof(msg)); > } > diff --git a/dhcp.c b/dhcp.c > index c3c742245ccf..1bd68ed5b87b 100644 > --- a/dhcp.c > +++ b/dhcp.c > @@ -477,7 +477,8 @@ int dhcp(const struct ctx *c, struct iov_tail *data) > else > dst =3D c->ip4.addr; > =20 > - tap_udp4_send(c, c->ip4.our_tap_addr, 67, dst, 68, &reply, dlen); > + tap_udp4_send(c, QPAIR_DEFAULT, c->ip4.our_tap_addr, 67, dst, 68, > + &reply, dlen); > =20 > return 1; > } > diff --git a/dhcpv6.c b/dhcpv6.c > index 29c7e320be8f..0986d6149515 100644 > --- a/dhcpv6.c > +++ b/dhcpv6.c > @@ -407,7 +407,8 @@ static void dhcpv6_send_ia_notonlink(struct ctx *c, > =20 > resp_not_on_link.hdr.xid =3D xid; > =20 > - tap_udp6_send(c, src, 547, caddr, 546, xid, &resp_not_on_link, n); > + tap_udp6_send(c, QPAIR_DEFAULT, src, 547, caddr, 546, xid, > + &resp_not_on_link, n); > } > =20 > /** > @@ -681,7 +682,8 @@ int dhcpv6(struct ctx *c, struct iov_tail *data, > =20 > resp.hdr.xid =3D mh->xid; > =20 > - tap_udp6_send(c, src, 547, saddr, 546, mh->xid, &resp, n); > + tap_udp6_send(c, QPAIR_DEFAULT, src, 547, saddr, 546, mh->xid, &resp, > + n); > c->ip6.addr_seen =3D c->ip6.addr; > =20 > return 1; > diff --git a/icmp.c b/icmp.c > index 0fe23667f517..a1015fe9f5c2 100644 > --- a/icmp.c > +++ b/icmp.c > @@ -134,12 +134,14 @@ void icmp_sock_handler(const struct ctx *c, union e= poll_ref ref, > const struct in_addr *daddr =3D inany_v4(&ini->eaddr); > =20 > assert(saddr && daddr); /* Must have IPv4 addresses */ > - tap_icmp4_send(c, *saddr, *daddr, buf, pingf->f.tap_omac, n); > + tap_icmp4_send(c, QPAIR_DEFAULT, *saddr, *daddr, buf, > + pingf->f.tap_omac, n); > } else if (pingf->f.type =3D=3D FLOW_PING6) { > const struct in6_addr *saddr =3D &ini->oaddr.a6; > const struct in6_addr *daddr =3D &ini->eaddr.a6; > =20 > - tap_icmp6_send(c, saddr, daddr, buf, pingf->f.tap_omac, n); > + tap_icmp6_send(c, QPAIR_DEFAULT, saddr, daddr, buf, > + pingf->f.tap_omac, n); > } > return; > =20 > diff --git a/ndp.c b/ndp.c > index 1f2bcb0cc7ea..6269cb38d93f 100644 > --- a/ndp.c > +++ b/ndp.c > @@ -184,7 +184,7 @@ static void ndp_send(const struct ctx *c, const struc= t in6_addr *dst, > { > const struct in6_addr *src =3D &c->ip6.our_tap_ll; > =20 > - tap_icmp6_send(c, src, dst, buf, c->our_tap_mac, l4len); > + tap_icmp6_send(c, QPAIR_DEFAULT, src, dst, buf, c->our_tap_mac, l4len); > } > =20 > /** > diff --git a/tap.c b/tap.c > index 4956e4dc2589..206a1c36b779 100644 > --- a/tap.c > +++ b/tap.c > @@ -124,10 +124,12 @@ unsigned long tap_l2_max_len(const struct ctx *c) > /** > * tap_send_single() - Send a single frame > * @c: Execution context > + * @qpair: Queue pair on which to send the frame > * @data: Packet buffer > * @l2len: Total L2 packet length > */ > -void tap_send_single(const struct ctx *c, const void *data, size_t l2len) > +void tap_send_single(const struct ctx *c, unsigned int qpair, const void= *data, > + size_t l2len) > { > uint8_t padded[ETH_ZLEN] =3D { 0 }; > struct iovec iov[2]; > @@ -155,7 +157,7 @@ void tap_send_single(const struct ctx *c, const void = *data, size_t l2len) > tap_send_frames(c, iov, iovcnt, 1); > break; > case MODE_VU: > - vu_send_single(c, QPAIR_DEFAULT, data, l2len); > + vu_send_single(c, qpair, data, l2len); > break; > } > } > @@ -243,6 +245,7 @@ void *tap_push_uh4(struct udphdr *uh, struct in_addr = src, in_port_t sport, > /** > * tap_udp4_send() - Send UDP over IPv4 packet > * @c: Execution context > + * @qpair: Queue pair on which to send packet > * @src: IPv4 source address > * @sport: UDP source port > * @dst: IPv4 destination address > @@ -250,8 +253,8 @@ void *tap_push_uh4(struct udphdr *uh, struct in_addr = src, in_port_t sport, > * @in: UDP payload contents (not including UDP header) > * @dlen: UDP payload length (not including UDP header) > */ > -void tap_udp4_send(const struct ctx *c, struct in_addr src, in_port_t sp= ort, > - struct in_addr dst, in_port_t dport, > +void tap_udp4_send(const struct ctx *c, unsigned int qpair, struct in_ad= dr src, > + in_port_t sport, struct in_addr dst, in_port_t dport, > const void *in, size_t dlen) > { > size_t l4len =3D dlen + sizeof(struct udphdr); > @@ -261,20 +264,22 @@ void tap_udp4_send(const struct ctx *c, struct in_a= ddr src, in_port_t sport, > char *data =3D tap_push_uh4(uh, src, sport, dst, dport, in, dlen); > =20 > memcpy(data, in, dlen); > - tap_send_single(c, buf, dlen + (data - buf)); > + tap_send_single(c, qpair, buf, dlen + (data - buf)); > } > =20 > /** > * tap_icmp4_send() - Send ICMPv4 packet > * @c: Execution context > + * @qpair: Queue pair on which to send packet > * @src: IPv4 source address > * @dst: IPv4 destination address > * @in: ICMP packet, including ICMP header > * @src_mac: MAC address to be used as source for message > * @l4len: ICMP packet length, including ICMP header > */ > -void tap_icmp4_send(const struct ctx *c, struct in_addr src, struct in_a= ddr dst, > - const void *in, const void *src_mac, size_t l4len) > +void tap_icmp4_send(const struct ctx *c, unsigned int qpair, struct in_a= ddr src, > + struct in_addr dst, const void *in, const void *src_mac, > + size_t l4len) > { > char buf[USHRT_MAX]; > struct iphdr *ip4h =3D tap_push_l2h(c, buf, src_mac, ETH_P_IP); > @@ -284,7 +289,7 @@ void tap_icmp4_send(const struct ctx *c, struct in_ad= dr src, struct in_addr dst, > memcpy(icmp4h, in, l4len); > csum_icmp4(icmp4h, icmp4h + 1, l4len - sizeof(*icmp4h)); > =20 > - tap_send_single(c, buf, l4len + ((char *)icmp4h - buf)); > + tap_send_single(c, qpair, buf, l4len + ((char *)icmp4h - buf)); > } > =20 > /** > @@ -348,6 +353,7 @@ void *tap_push_uh6(struct udphdr *uh, > /** > * tap_udp6_send() - Send UDP over IPv6 packet > * @c: Execution context > + * @qpair: Queue pair on which to send packet > * @src: IPv6 source address > * @sport: UDP source port > * @dst: IPv6 destination address > @@ -356,7 +362,7 @@ void *tap_push_uh6(struct udphdr *uh, > * @in: UDP payload contents (not including UDP header) > * @dlen: UDP payload length (not including UDP header) > */ > -void tap_udp6_send(const struct ctx *c, > +void tap_udp6_send(const struct ctx *c, unsigned int qpair, > const struct in6_addr *src, in_port_t sport, > const struct in6_addr *dst, in_port_t dport, > uint32_t flow, void *in, size_t dlen) > @@ -369,19 +375,20 @@ void tap_udp6_send(const struct ctx *c, > char *data =3D tap_push_uh6(uh, src, sport, dst, dport, in, dlen); > =20 > memcpy(data, in, dlen); > - tap_send_single(c, buf, dlen + (data - buf)); > + tap_send_single(c, qpair, buf, dlen + (data - buf)); > } > =20 > /** > * tap_icmp6_send() - Send ICMPv6 packet > * @c: Execution context > + * @qpair: Queue pair on which to send packet > * @src: IPv6 source address > * @dst: IPv6 destination address > * @in: ICMP packet, including ICMP header > * @src_mac: MAC address to be used as source for message > * @l4len: ICMP packet length, including ICMP header > */ > -void tap_icmp6_send(const struct ctx *c, > +void tap_icmp6_send(const struct ctx *c, unsigned int qpair, > const struct in6_addr *src, const struct in6_addr *dst, > const void *in, const void *src_mac, size_t l4len) > { > @@ -393,7 +400,7 @@ void tap_icmp6_send(const struct ctx *c, > memcpy(icmp6h, in, l4len); > csum_icmp6(icmp6h, src, dst, icmp6h + 1, l4len - sizeof(*icmp6h)); > =20 > - tap_send_single(c, buf, l4len + ((char *)icmp6h - buf)); > + tap_send_single(c, qpair, buf, l4len + ((char *)icmp6h - buf)); > } > =20 > /** > @@ -684,15 +691,19 @@ static bool tap4_is_fragment(const struct iphdr *ip= h, > /** > * tap4_handler() - IPv4 and ARP packet handler for tap file descriptor > * @c: Execution context > + * @qpair: Queue pair on which to send packets > * @now: Current timestamp > * > * Return: count of packets consumed by handlers > */ > -static int tap4_handler(struct ctx *c, const struct timespec *now) > +static int tap4_handler(struct ctx *c, unsigned int qpair, > + const struct timespec *now) > { > unsigned int i, j, seq_count; > struct tap4_l4_t *seq; > =20 > + (void)qpair; > + > if (!c->ifi4 || !pool_tap4->count) > return pool_tap4->count; > =20 > @@ -930,15 +941,19 @@ found: > /** > * tap6_handler() - IPv6 packet handler for tap file descriptor > * @c: Execution context > + * @qpair: Queue pair on which to send packets > * @now: Current timestamp > * > * Return: count of packets consumed by handlers > */ > -static int tap6_handler(struct ctx *c, const struct timespec *now) > +static int tap6_handler(struct ctx *c, unsigned int qpair, > + const struct timespec *now) > { > unsigned int i, j, seq_count =3D 0; > struct tap6_l4_t *seq; > =20 > + (void)qpair; > + > if (!c->ifi6 || !pool_tap6->count) > return pool_tap6->count; > =20 > @@ -1136,21 +1151,23 @@ void tap_flush_pools(void) > /** > * tap_handler() - IPv4/IPv6 and ARP packet handler for tap file descrip= tor > * @c: Execution context > + * @qpair: Queue pair on which to send packets > * @now: Current timestamp > */ > -void tap_handler(struct ctx *c, const struct timespec *now) > +void tap_handler(struct ctx *c, unsigned int qpair, const struct timespe= c *now) > { > - tap4_handler(c, now); > - tap6_handler(c, now); > + tap4_handler(c, qpair, now); > + tap6_handler(c, qpair, now); > } > =20 > /** > * tap_add_packet() - Queue/capture packet, update notion of guest MAC a= ddress > * @c: Execution context > + * @qpair: Queue pair associated with the packet > * @data: Packet to add to the pool > * @now: Current timestamp > */ > -void tap_add_packet(struct ctx *c, struct iov_tail *data, > +void tap_add_packet(struct ctx *c, unsigned int qpair, struct iov_tail *= data, > const struct timespec *now) > { > size_t l2len =3D iov_tail_size(data); > @@ -1177,14 +1194,14 @@ void tap_add_packet(struct ctx *c, struct iov_tai= l *data, > case ETH_P_ARP: > case ETH_P_IP: > if (!pool_can_fit(pool_tap4, data)) { > - tap4_handler(c, now); > + tap4_handler(c, qpair, now); > pool_flush(pool_tap4); > } > packet_add(pool_tap4, data); > break; > case ETH_P_IPV6: > if (!pool_can_fit(pool_tap6, data)) { > - tap6_handler(c, now); > + tap6_handler(c, qpair, now); > pool_flush(pool_tap6); > } > packet_add(pool_tap6, data); > @@ -1269,7 +1286,7 @@ static void tap_passt_input(struct ctx *c, const st= ruct timespec *now) > n -=3D sizeof(uint32_t); > =20 > data =3D IOV_TAIL_FROM_BUF(p, l2len, 0); > - tap_add_packet(c, &data, now); > + tap_add_packet(c, QPAIR_DEFAULT, &data, now); > =20 > p +=3D l2len; > n -=3D l2len; > @@ -1278,7 +1295,7 @@ static void tap_passt_input(struct ctx *c, const st= ruct timespec *now) > partial_len =3D n; > partial_frame =3D p; > =20 > - tap_handler(c, now); > + tap_handler(c, QPAIR_DEFAULT, now); > } > =20 > /** > @@ -1337,10 +1354,10 @@ static void tap_pasta_input(struct ctx *c, const = struct timespec *now) > continue; > =20 > data =3D IOV_TAIL_FROM_BUF(pkt_buf + n, len, 0); > - tap_add_packet(c, &data, now); > + tap_add_packet(c, QPAIR_DEFAULT, &data, now); > } > =20 > - tap_handler(c, now); > + tap_handler(c, QPAIR_DEFAULT, now); > } > =20 > /** > diff --git a/tap.h b/tap.h > index b335933fdbc9..0f8e98fc5f84 100644 > --- a/tap.h > +++ b/tap.h > @@ -91,22 +91,23 @@ void *tap_push_ip6h(struct ipv6hdr *ip6h, > const struct in6_addr *src, > const struct in6_addr *dst, > size_t l4len, uint8_t proto, uint32_t flow); > -void tap_udp4_send(const struct ctx *c, struct in_addr src, in_port_t sp= ort, > - struct in_addr dst, in_port_t dport, > +void tap_udp4_send(const struct ctx *c, unsigned int qpair, struct in_ad= dr src, > + in_port_t sport, struct in_addr dst, in_port_t dport, > const void *in, size_t dlen); > -void tap_icmp4_send(const struct ctx *c, struct in_addr src, struct in_a= ddr dst, > - const void *in, const void *src_mac, size_t l4len); > +void tap_icmp4_send(const struct ctx *c, unsigned int qpair, struct in_a= ddr src, > + struct in_addr dst, const void *in, const void *src_mac, > + size_t l4len); > void *tap_push_ip6h(struct ipv6hdr *ip6h, > const struct in6_addr *src, const struct in6_addr *dst, > size_t l4len, uint8_t proto, uint32_t flow); > -void tap_udp6_send(const struct ctx *c, > +void tap_udp6_send(const struct ctx *c, unsigned int qpair, > const struct in6_addr *src, in_port_t sport, > const struct in6_addr *dst, in_port_t dport, > uint32_t flow, void *in, size_t dlen); > -void tap_icmp6_send(const struct ctx *c, > +void tap_icmp6_send(const struct ctx *c, unsigned int qpair, > const struct in6_addr *src, const struct in6_addr *dst, > const void *in, const void *src_mac, size_t l4len); > -void tap_send_single(const struct ctx *c, const void *data, size_t l2len= ); > +void tap_send_single(const struct ctx *c, unsigned int qpair, const void= *data, size_t l2len); > size_t tap_send_frames(const struct ctx *c, const struct iovec *iov, > size_t bufs_per_frame, size_t nframes); > void eth_update_mac(struct ethhdr *eh, > @@ -121,7 +122,7 @@ int tap_sock_unix_open(char *sock_path); > void tap_sock_reset(struct ctx *c); > void tap_backend_init(struct ctx *c); > void tap_flush_pools(void); > -void tap_handler(struct ctx *c, const struct timespec *now); > -void tap_add_packet(struct ctx *c, struct iov_tail *data, > +void tap_handler(struct ctx *c, unsigned int qpair, const struct timespe= c *now); > +void tap_add_packet(struct ctx *c, unsigned int qpair, struct iov_tail *= data, > const struct timespec *now); > #endif /* TAP_H */ > diff --git a/tcp.c b/tcp.c > index 3b78d2edd03e..6b7612c27abf 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -2285,7 +2285,7 @@ static void tcp_rst_no_conn(const struct ctx *c, in= t af, > =20 > tcp_update_csum(psum, rsth, &payload, 0); > rst_l2len =3D ((char *)rsth - buf) + sizeof(*rsth); > - tap_send_single(c, buf, rst_l2len); > + tap_send_single(c, QPAIR_DEFAULT, buf, rst_l2len); > } > =20 > /** > diff --git a/udp.c b/udp.c > index 505e55407fb4..589d48a17613 100644 > --- a/udp.c > +++ b/udp.c > @@ -445,7 +445,7 @@ static void udp_send_tap_icmp4(const struct ctx *c, > /* Try to obtain the MAC address of the generating node */ > saddr_any =3D inany_from_v4(saddr); > fwd_neigh_mac_get(c, &saddr_any, tap_omac); > - tap_icmp4_send(c, saddr, eaddr, &msg, tap_omac, msglen); > + tap_icmp4_send(c, QPAIR_DEFAULT, saddr, eaddr, &msg, tap_omac, msglen); > } > =20 > =20 > @@ -493,7 +493,7 @@ static void udp_send_tap_icmp6(const struct ctx *c, > =20 > /* Try to obtain the MAC address of the generating node */ > fwd_neigh_mac_get(c, (union inany_addr *) saddr, tap_omac); > - tap_icmp6_send(c, saddr, eaddr, &msg, tap_omac, msglen); > + tap_icmp6_send(c, QPAIR_DEFAULT, saddr, eaddr, &msg, tap_omac, msglen); > } > =20 > /** > diff --git a/vu_common.c b/vu_common.c > index 8adcf42b954b..7239cb42f38b 100644 > --- a/vu_common.c > +++ b/vu_common.c > @@ -198,12 +198,13 @@ static void vu_handle_tx(struct vu_dev *vdev, int i= ndex, > } > =20 > data =3D IOV_TAIL(elem[count].out_sg, elem[count].out_num, 0); > - if (IOV_DROP_HEADER(&data, struct virtio_net_hdr_mrg_rxbuf)) > - tap_add_packet(vdev->context, &data, now); > + if (IOV_DROP_HEADER(&data, struct virtio_net_hdr_mrg_rxbuf)) { > + tap_add_packet(vdev->context, QPAIR_DEFAULT, &data, now); > + } > =20 > count++; > } > - tap_handler(vdev->context, now); > + tap_handler(vdev->context, QPAIR_DEFAULT, now); > =20 > if (count) { > int i; > --=20 > 2.54.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --aJvyPDcGpzl3Fm2e Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpwBpIACgkQzQJF27ox 2Gf3XBAAqDPx2ZNGHXVwhn4Xi6z+FICJN1MwRTMU1XVAI3p8SCdQBQh5o22IN3aQ fZDkhf7EnhjdDTTCOMKsOwPa7WRQdQdzSC/RP/SdoCjp0pnHhKSv6UCcte862W/2 cTAbLzy8Z3fcPHDHUt/7yXZv/A+KI78VfIX4UvTjCQMokpM1FHSC2++7D7wSejcW 28u5wcuv0rWQYjeD0lURDJvEk7wLVMpSbPgzN55VQ07Btd+HzTRxsrksmZRzu6CN Z6hZW7RJ54OMXk6rZaq3XhJ/EaU21mICYQKVVkz+4mOHBHE/jTygsXOmFf3hF+7e Zt5uTEeZGN+BpCKIW6JekQ8fbdsj6FPjSjUuM0B8U1cej5h7xIn1uQcHtAY7bxJl 3sNRyYrAIr13DLCEIUTsWq5cpH/BzlC087mFETqW3ajUZ5+YiJQP/WFhW+Xg3meQ Czhy9JFbniB+EBYbtRaz18sTBS1Dk9mO8c8W/reGm0NAoW9wQZ5rGN4j04zhcB+e XkD9wIPZGI9xSs8tJ9pVLtdKmy3rfxHA3vcmB/moB8rZ3SWCZt6EMMC34VJ+hrFQ 36oUPdH9SVQxHnHZlSBAAlJ55+VDqOLb0SJ1gVF+Td22Yciw8hx/ObRK+nX7NvF0 dNgAHHWJJhBz5Af+N8Rkj2ZfUHfOKjQ2sSZIi2zEeacPKv3ofYA= =JCIy -----END PGP SIGNATURE----- --aJvyPDcGpzl3Fm2e--