From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202608 header.b=RuF0QGXS; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 679555A0625 for ; Mon, 03 Aug 2026 05:46:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1785728795; bh=9VmcKcU5AIelvRMpWL58zcFcUCmw7JoqqwPwOPuJOO0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuF0QGXSd56VzJjjNzk5+IjAaCQcL+68uovFTDODsZ8JFoGcnS+wIAdsxQVvIX6l9 XYX9K0XolUmLMUOViQNL6oIO46ylymawsVewPxlrLa+DeONWDGAgJFGTFWb7Ter82L fRSmTEXHH5TDfc1vlrTy9lVZOz5HAbV9q3vvR6TxT4UCPm26un9tKyMTeQ65tmNrEt rnbwYofi3s4QUQzXni6MT9A/mwn4PqNAs7IPh8przMSiIUskfEPq14IntAASQN/EU6 JZEt22q+JXOyd7K/eKEMfJgvZdZGDEDrFub16QMgglxnajyukn0CEBKp6c1oJnPh4s Bx69jIpqbLKqw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hD2fM1z4gz4wG8; Mon, 03 Aug 2026 13:46:35 +1000 (AEST) Date: Mon, 3 Aug 2026 13:26:25 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v6 09/12] icmp: Pass queue pair explicitly through ICMP send path Message-ID: References: <20260731161617.3550626-1-lvivier@redhat.com> <20260731161617.3550626-10-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RKlhlgDPzwLTnDAb" Content-Disposition: inline In-Reply-To: <20260731161617.3550626-10-lvivier@redhat.com> Message-ID-Hash: FZ4K3THRP74DGKZO5M34OQRBMYMLM4J6 X-Message-ID-Hash: FZ4K3THRP74DGKZO5M34OQRBMYMLM4J6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --RKlhlgDPzwLTnDAb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 31, 2026 at 06:16:14PM +0200, Laurent Vivier wrote: > icmp_sock_handler() uses QPAIR_DEFAULT when calling tap_icmp4_send() > and tap_icmp6_send(). Thread a qpair parameter from the caller in > passt_worker() so the queue pair is selected at the entry point rather > than hard-coded inside the handler. >=20 > passt_worker() currently passes QPAIR_DEFAULT, preserving existing > single-queue behavior. This is a preparatory step for per-queue > worker threads in vhost-user mode. >=20 > No functional change. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > @@ -67,9 +67,10 @@ static struct icmp_ping_flow *ping_at_sidx(flow_sidx_t= sidx) > * @c: Execution context > * @ref: epoll reference > * @now: Current timestamp > + * @qpair: Queue pair to process As with TCP and UDP, some more precision in this description would help. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --RKlhlgDPzwLTnDAb Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmpwClMACgkQzQJF27ox 2GfSzxAAiXz7fRsdBeukCeruBe3wcFYSqy89g7R5jBCC7C1qi76pHzYeO6pz8x50 d1K3m71cjeRodXWvvihSJplvibOZEQugy9SY/37NLb8pcekT5spvMHZIgopJHr09 jv7JqthSlqm12s3tU0vWJxPL7e72mJ+EEbv25VfGtlO666uI8VewCNL1YvO/q0ki 2RnPAHdJ1iyq0oHVCPmF/wb7v9hMdEbn91TNyQ56eamMmti5sRxS8NMZzd7cY90R gLje2Sx9BYAnJEtsdjxusOS3dTOss+PU+38MTu4jgVF29fpCnduwYaHiuXpJ/Unr V4GTYFr0jhTfwxIob7Gb3wSnAoua1JNWivdkhFEjPGS0FrGX4XEKnWQVIJ6snKDG xGKqjwxjhMtlhUzu1FGa96tfXWCfjShxLB44HgSOOBY7auqA2q4dyxpMU+JsLmcx GoktAeNhndptRA0Dy9HZfP0po5wfbXdLRT9m/shu2hdLQg1AjM957J82O0H+Y0WL oVHzbvWoD3GVEgkL1xjWSjHRK+jMP+0qt5/zT2V1xrEXOo7T1+xqvFP5BRzvdZr5 7m2FMhMaoBE50JHUNb4dBgnaQ0jBzFhh7SQ7uylFr7oXVEpmZqz/88QS4QiylsAE kLNYyrdOHvvZIVXcV/YW7c2PURrEcjKdVNcq9FAMpFVj3mpcF/0= =umbf -----END PGP SIGNATURE----- --RKlhlgDPzwLTnDAb--