From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202608 header.b=HeuGnp9H; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 78DBC5A0265 for ; Fri, 07 Aug 2026 04:30:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1786069837; bh=2Pf2HN8IH4Fzr4Ai6LK4T6EQ0inRQq9oAtTa9fyGVVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HeuGnp9HJPh+f92geBH37PeTUbF9V57P/JxKpfCZb1T90pQ5gW5WWMTbbPoFtDS4g YtfdF8EGkiiMvVkp75m6z3Y7Ga57wKXBTSaANGOgJjLczo/5ZE2LVkSbNalmqraJUZ j770MLnM5gOYys0An4xyd1QogtnU6ygJanBK32c5KCwdU3SZy3Tu2080PWIC6s64Bu UVQwKXjkqNWVBp7nkoNl9BCI2wPn3QE4ehGITZ/BeMYEIUkBj9WaYlEVzUvzHJctxF sYRIhEw3x8XfgPX/pG2a/Mtsb8ypTNW+PQRt/NjNXJYjawJ2knHmHVFB7y/D9W3peI Ib6ewm2Exhyyg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hGSms15GZz4wFP; Fri, 07 Aug 2026 12:30:37 +1000 (AEST) Date: Fri, 7 Aug 2026 11:09:52 +1000 From: David Gibson To: Stefano Brivio Subject: Re: Patch for the close_range() musl build failure Message-ID: References: <878q6jjvww.wl-rne.kou@icloud.com> <20260806235419.722b0a71@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2m+kZDzFu/DvyLh7" Content-Disposition: inline In-Reply-To: <20260806235419.722b0a71@elisabeth> Message-ID-Hash: OX6IYDLIFUGRNQCRKTO5TWWXJB4J7R5V X-Message-ID-Hash: OX6IYDLIFUGRNQCRKTO5TWWXJB4J7R5V X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Huang Jing , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --2m+kZDzFu/DvyLh7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 06, 2026 at 11:54:20PM +0200, Stefano Brivio wrote: > Hi Huang Jing, >=20 > Thanks for investigating and fixing this! A few notes, inline, below. >=20 > They are all formal and trivial so I can fix up all of them on merge if > you agree (but you can also choose to re-send as v2 with those fixed, > let me know, in case). >=20 > I'm pointing those out especially for the future, should you happen to > contribute again to this project or projects following a similar workflow. >=20 > On Thu, 06 Aug 2026 20:06:07 +0800 > Huang Jing wrote: >=20 > > >From 25831e518c9227a31b75f2c1eb2e620fd4c5d049 Mon Sep 17 00:00:00 2001 >=20 > We follow essentially the same contribution process as the Linux kernel, > see also CONTRIBUTING.md and: >=20 > https://www.kernel.org/doc/html/next/process/submitting-patches.html >=20 > ...so we don't send them patches as attachments, they're simply in the > email body, just like git send-email sends them. >=20 > > From: RadioNoiseE > > Date: Thu, 6 Aug 2026 19:58:45 +0800 > > Subject: [PATCH] isolation: Include linux_dep.h for close_range() > >=20 > > Now that close_open_files() has been moved, linux_dep.h can be safely >=20 > Stated like this, it looks like a more detailed description of the > patch, compared to the title. >=20 > It's something you're adding to it instead. To avoid confusion about > what the patch does (most importantly, what's in the title), I'd > suggest to phrase it like: >=20 > ...and now that close_open_files() ... >=20 > > removed from util.c. > >=20 >=20 > Here we need a couple of tags to provide some context (which might be > important when looking at this later), that is: >=20 > Link: https://github.com/gentoo/gentoo/pull/46644 > Fixes: 0a510066e916 ("isolation: Move close_open_files() to isolate_fds()= ") >=20 > and, while at it, it's a good practice to Cc: the author of the change > that's being fixed up (I just did). I second the minor procedural nits, but the patch looks good to me too, so, Reviewed-by: David Gibson --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --2m+kZDzFu/DvyLh7 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmp1MFMACgkQzQJF27ox 2GdXWA//bk34w0Z127wQKdol8Duv4K3N/FWPPdJJ4ZwX81BK2TBzq8Vbw4kBxjgN g7kQ8qnRR3kartGc9QdQB3AoU+BQyk/vutF9UR4LW9qwqmAcxirgYoSC94+3GJLl 2SelvjVY45LJxrhV1dSZIta1tSHWPYujdn9pWnVETRYaG1wA0toMzkxddPNoT/Z5 oWqXDXkAxX7T13zGxRXBX7+hPwrc/sncQ3o3JLCmFHp0YsiwHCrBOod/XdB9Ers4 Ra5OlryXxrr6+i62WLb+zDl/um71Wnpv9tt1uvOxeB6NX0L+/kphGHZc+vEIfd8k LZnj+Rd4WW2BJ9UF3wWD45464KvJgRpuHj9a9aXewWAEL773X0gvqlMGF3Ysp0Fe lVHNs0siun+H6ip7mShmEiQLFthEaeciB0k6LtV29iJgAyoiduGBrKhbAHv9Tc1K XBxZLL3g9wbF7FMMm1oMWGFki8qqa3Fg4mS3K59IRHDWS5T0j+iB/qobx7EIX1iP 4TXlobJv2ZEsjn2DFcjmVjd5NvuCbc2uo13oY3lxc0kN3JZm4muFJzy5W2QVC0l1 NLMDw/zYy5AH1m438DEA8tKX08vW5rnqN6yKhCi8waNDBJpWUYJvpYDlGmVDl8at gnSgBLHwrLgZMKf0l/GAOGXcZXYB4VPdr5EocEvE9m5PbOaDQGM= =OZJh -----END PGP SIGNATURE----- --2m+kZDzFu/DvyLh7--