From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202608 header.b=QFfxImYS; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 9311B5A0262 for ; Fri, 07 Aug 2026 12:02:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1786096958; bh=33bzIe4FFmr7MCyaxiobGQTHShoksbte2Uw1m/WRv2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QFfxImYSorGPFRT3SmcNgpgxdfL3I8GQDkWDIIj+z9btlAMRY9NrVxkX+VCMypHTj N/soDtkQA24287pWTjkJ1vD0ELJwOYj/4K16+oMmtt2+BhMCixpsSqAkz5oOuhdCuk SEnPOGq69jbRTftYub2SR1tDIogyzJ8B9RVK1Afor+LMVzjjw4XcALeHebSfbe/sEb EHl7uSMI2OMWlrKzsk71056hZDl9KzUItyTcqSgOLrl1uNWggklV8j4AcSeEWjuN1V CRW+pgaSGoR3AKFU7rUV1HN6K/gKfC4peu2ujR/OMESo9UTVhJ/y/G0/VXz6VSwZob ijanD8BQ01seA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hGfpQ6GTGz4wGF; Fri, 07 Aug 2026 20:02:38 +1000 (AEST) Date: Fri, 7 Aug 2026 15:40:02 +1000 From: David Gibson To: Ammar Yasser Subject: Re: [RFC v3 1/8] tap: Move the tap_hdr file to a separate file Message-ID: References: <20260802132155.870796-1-aerosound161@gmail.com> <20260802132155.870796-2-aerosound161@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bud/XEAJ3mMdVESG" Content-Disposition: inline In-Reply-To: <20260802132155.870796-2-aerosound161@gmail.com> Message-ID-Hash: VK2RLVSVQXEKIBL6QHLBPGWI7WOBG7SF X-Message-ID-Hash: VK2RLVSVQXEKIBL6QHLBPGWI7WOBG7SF X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, eperezma@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --bud/XEAJ3mMdVESG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 02, 2026 at 01:21:48PM +0000, Ammar Yasser wrote: > It was defined in tap.h, put it on its own so that future callers won't > need to depend on all definitions in tap.h >=20 > Signed-off-by: Ammar Yasser Reviewed-by: David Gibson > --- > tap.h | 9 +-------- > tap_hdr.h | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+), 8 deletions(-) > create mode 100644 tap_hdr.h >=20 > diff --git a/tap.h b/tap.h > index b335933..1625975 100644 > --- a/tap.h > +++ b/tap.h > @@ -10,6 +10,7 @@ > #include > =20 > #include "passt.h" > +#include "tap_hdr.h" > =20 > /** L2_MAX_LEN_PASTA - Maximum frame length for pasta mode (with L2 head= er) > * > @@ -38,14 +39,6 @@ > =20 > struct udphdr; > =20 > -/** > - * struct tap_hdr - tap backend specific headers > - * @vnet_len: Frame length (for qemu socket transport) > - */ > -struct tap_hdr { > - uint32_t vnet_len; > -} __attribute__((packed)); > - > /** > * tap_hdr_iov() - struct iovec for a tap header > * @c: Execution context > diff --git a/tap_hdr.h b/tap_hdr.h > new file mode 100644 > index 0000000..15bdb5b > --- /dev/null > +++ b/tap_hdr.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later > + * Copyright (c) 2021 Red Hat GmbH > + * Author: Stefano Brivio > + */ > + > +#ifndef TAP_HDR_H > +#define TAP_HDR_H > + > +#include > + > +/** > + * struct tap_hdr - tap backend specific headers > + * @vnet_len: Frame length (for qemu socket transport) > + */ > +struct tap_hdr { > + uint32_t vnet_len; > +} __attribute__((packed)); > + > +#endif /* TAP_HDR_H */ > --=20 > 2.34.1 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --bud/XEAJ3mMdVESG Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmp1b64ACgkQzQJF27ox 2Gc5hxAAiwgcf+XBm2uXAJizATnfuyZYS2oFopZMxhgUFtN1bdSze0OHR4j/TXyn SgqEGjtts4WDfHirwwb5QkzJJtTZPUGP0RE9CCmJOA7wPrAcBlbIq2o0xT2Z80BV 5ffXwgMFezTtwslxQKqqRQ8MmsoPCA8Z0ChyxSSNY5EHVz4FEb34ZqZwBFkOrrW+ lM4Raq6u6ui44P++iO3mhHZDSPJVkeq5DhE+YshWQ8SOT9xf6ZKWJ3iKTZB7AdoZ Q8ADhTu0ZdD6VhfKy4lEgyCUl6qgKjWM3BmchygfwNSPcZ1v71ZMh9GFEWehMBg7 ho6h+AWEkYZlqfI+ANj0YgPBng4BjFwN4ntNMSMBkjlmqmegVPCN7JuRWVSkLZqs 7XUhkr66dNamp2FJKWc+zVoUPHF/vBi/TbihTy/1QVbvmwMdHfBv/tPWvzaxBv0b gG+RxLbFrm9IbDjrBYdCLsKRN5RSAOaaJ5+KKkgLbd5wjoTRwOiRI5tdYIYIw5GW fkWTAfzEczZhP2SiYLpQ7ntbREI8hFIRNSBwcc3NaYvgxhNOJrYzm+l3EPm6L0Pc xz21kG0NKi9gRmZ8Zmzi4XeGxG2gl6VhXtz18VNN8AHN/+rdczVbxjR7tjWhyPLy QWeDa9iI+QIRWS1D2pJVVF1fL8PR2cGTlEW/D0t4qf6opg0bYfM= =K/F8 -----END PGP SIGNATURE----- --bud/XEAJ3mMdVESG--