From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202608 header.b=RSIU6Ec+; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 16B4D5A0269 for ; Wed, 09 Sep 2026 11:10:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202608; t=1788945027; bh=lOsvKHOyt0DL90xBFNchbKucsh56Zraostc7YPoWJ3Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RSIU6Ec+znkxKoWWH9YETDNTRKbXcVgLOHKu1zRn+sgv8yiA/9wWTfRAZ1VhfklAQ gE1HiQZ6IdiIfDL0V5c/tljHJGeW32neeeVhtiEfGbF/BhfPl7DQDuhtLb7hHWTLgq lqnj+WA5fPk7ceYr+U5JVZBp0JnB+PD2IZMhPMGiy540GsZZ3ed/rUePp9W73KJu68 Gf91A6qnNlPHmcK/0ijSZGvemee6Ac4JHCVAORXqYWuwaJXoqFqyZgfQOqOdc1hsiM xlLcur8pG+PWhwHs62fQqCtbjSPo+55/d0Ns6yc3qhYVCu2sDCLBPwCjpNo10GSgNo st1FcywSfRMEg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4hfw4z3bk8z4wSg; Wed, 09 Sep 2026 19:10:27 +1000 (AEST) Date: Wed, 9 Sep 2026 19:10:31 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 1/7] tap: Move the tap_hdr file to a separate file Message-ID: References: <20260904212826.41027-1-aerosound161@gmail.com> <20260904212826.41027-2-aerosound161@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KOs9+gYtkjYBL/Vy" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 3QZZJ56C5E4UTTVML52HXI4KH3NQLYV6 X-Message-ID-Hash: 3QZZJ56C5E4UTTVML52HXI4KH3NQLYV6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: aerosouund , passt-dev@passt.top, eperezma@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --KOs9+gYtkjYBL/Vy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 09, 2026 at 10:47:25AM +0200, Laurent Vivier wrote: > Subject: s/tap_hdr file/tap_hdr structure/ >=20 >=20 > On 9/4/26 23:28, aerosouund wrote: > > From: Ammar Yasser > >=20 > > It was defined in tap.h, put it on its own so that future callers won't > > need to depend on all definitions in tap.h. > > Also turn it into a union of a vnet_len and virtio_net_mrg_rxbuf > > because for vhost acceleration the frames will have this virtio net > > header prepended to them. > >=20 > > Signed-off-by: Eugenio P=E9rez >=20 > If Eugenio is the author, you should set it as the author, otherwise you > should remove his Signed-off-by I don't think that's necessarily correct. If the patch has been changed substantially enough from the original, it makes sense to change the author. However, the S-o-b should remain if some fragments of the original remain, so as to still record the chain of hands through which it has passed for the DCO. >=20 > > Signed-off-by: Ammar Yasser > > --- > > tap.h | 9 +-------- > > tap_hdr.h | 23 +++++++++++++++++++++++ > > 2 files changed, 24 insertions(+), 8 deletions(-) > > create mode 100644 tap_hdr.h > >=20 > > diff --git a/tap.h b/tap.h > > index b335933..1625975 100644 > > --- a/tap.h > > +++ b/tap.h > > @@ -10,6 +10,7 @@ > > #include > > #include "passt.h" > > +#include "tap_hdr.h" > > /** L2_MAX_LEN_PASTA - Maximum frame length for pasta mode (with L2 h= eader) > > * > > @@ -38,14 +39,6 @@ > > struct udphdr; > > -/** > > - * struct tap_hdr - tap backend specific headers > > - * @vnet_len: Frame length (for qemu socket transport) > > - */ > > -struct tap_hdr { > > - uint32_t vnet_len; > > -} __attribute__((packed)); > > - > > /** > > * tap_hdr_iov() - struct iovec for a tap header > > * @c: Execution context > > diff --git a/tap_hdr.h b/tap_hdr.h > > new file mode 100644 > > index 0000000..aa270b7 > > --- /dev/null > > +++ b/tap_hdr.h > > @@ -0,0 +1,23 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later > > + * Copyright (c) 2021 Red Hat GmbH > > + * Author: Stefano Brivio > > + */ > > + > > +#ifndef TAP_HDR_H > > +#define TAP_HDR_H > > + > > +#include > > +#include > > + > > +/** > > + * struct tap_hdr - tap backend specific headers > > + * @vnet_len: Frame length (for qemu socket transport) >=20 > missing @hdr description >=20 > > + */ > > +struct tap_hdr { > > + union { > > + uint32_t vnet_len; > > + struct virtio_net_hdr_mrg_rxbuf hdr; > > + }; > > +}; >=20 > This will break passt. >=20 > In tap.h, we have: > static inline struct iovec tap_hdr_iov(const struct ctx *c, > struct tap_hdr *thdr) > { > return (struct iovec){ > .iov_base =3D thdr, > .iov_len =3D c->mode =3D=3D MODE_PASST ? sizeof(*thdr) : = 0, > }; > } >=20 > before this patch sizeof(*thdr) is 4, now it's 12. >=20 > > + > > +#endif /* TAP_HDR_H */ >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --KOs9+gYtkjYBL/Vy Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmqhInYACgkQzQJF27ox 2Gecsw//RQHCIwZeX3TpSZYd8+OsFxeipJR+A7J3gl7A+S8hnEWAjzcEOtCgiAyk aM+FcWeGBdTPLiGlLmCV2lyunkm2wME2lCL2Nl+Pfqt87uaHkwgpSoF38nMqA0p9 hU/275kQgaj/MPPfKmtvkczpta6dzYIiObJ7ON01kNk9mTp7K1g5fGuU4MUm4/On 71V6QO5LjBeMEfJj6PD456s2TNT1r/UmoPr3tu3pxuiQPrP6+74gcgxFFVXs8jY9 yRNZ+Op8hAndGoC/q0cwBXBzwNdkatlItX7Jf2HEMi4Mfz4kFNSa/+9JUFPLke0d l34u6CModnadnNrCZ60PgklgOw4kroZ7YQmUPm4TmTIhV77OM0F9mTluZgwY7cbQ rBDAKa36mY3kEiASDwLl3NMx1oRlxqN7z3cp8JG5/HjUf6iwpI/QVM8uh/yMm67I 1mofnCPqxJmsoDbHKgDAskXSaPc14fL47tUYDmLZVbAFwMRxZVQG3MONtEZDmZ2m K1hhOolOgiZCaM+o9XjDDSeuxXHbh7fnm3EZau7VhyVe+OnieTB+MWEK3liEHjpf JMJIPYKTtJrFxBPweHi8A/4x9cpENLFxisEjJYymy8JZhjnbJ3lkiROpg0L2zL8I /eKLtMhu4Kg/sgSdlgmcv2mc2cE38JAHz5R5eUDpNdefDp8MfJE= =LI/X -----END PGP SIGNATURE----- --KOs9+gYtkjYBL/Vy--