From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 6BAFA5A0265 for ; Wed, 18 Nov 2026 14:11:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202610; t=1795007492; bh=W1HI1eMXcttTXUjDUsgNh2GdQphJHMVvlpWB/tRp8QE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=arp61mdELnP1u3D3jrxiaHG8CVWfzW3zoC3U/lblfY8mtVeCBsqFGW4k28DmpkwEB PqmNGDoSC2xzFyCHEywANwTCPSK/+pcwN2i63xB6hCKlb70Aoh8nna0+7blmngWxUz XUyyq3qVewUge8mFyd4E5mNFhx6HemQ3ftLqblueSYQcaVtWUKPtqXA0J5DRtKpBct K+DtjPzIh/b3ZlMYoThS153aPuzBnc03nB7UKMCdoJKph6Zdq8pfSZPw40c4d5wc+c +AiPSWSvWEvyP5vnhY1bWqy5+97z+l/FqS3B4YW7GVmQWnrwy19T9ZtuKPu5fYgCg4 y3m9D98A6DTOg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4jV26r1r2Vz4wJj; Thu, 19 Nov 2026 00:11:32 +1100 (AEDT) Date: Wed, 18 Nov 2026 12:16:05 +1100 From: David Gibson To: Stefano Brivio Subject: Re: tcp: peer stuck in low_rtt_dst table loses window clamping, every new connection stalls on RTOs Message-ID: References: <20261104145322.2dc73741@elisabeth> <20261117120427.776ab215@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BwANpvP7+shT8XKQ" Content-Disposition: inline In-Reply-To: <20261117120427.776ab215@elisabeth> Message-ID-Hash: 3HOGATYEAGVSMCBKOBHK6J4K4IIJB4XD X-Message-ID-Hash: 3HOGATYEAGVSMCBKOBHK6J4K4IIJB4XD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lynxes Exe , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --BwANpvP7+shT8XKQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 17, 2026 at 12:04:28PM +0100, Stefano Brivio wrote: > On Thu, 12 Nov 2026 17:09:20 +0100 > Lynxes Exe wrote: >=20 > > Hi Stefano, > >=20 > > I apologize for the long wait. The issue took a while to represent itse= lf. >=20 > No worries, it wasn't that long, thanks for following up. >=20 > > [...] > > > > 3. Patches > >=20 > > Attached, against current master (7380393): > >=20 > > 0001 tcp: Don't add peers to low RTT table before RTT is measured > > 0002 tcp: Log additions to low RTT table > >=20 > > 0001 is your condition as you wrote it. 0002 logs only additions, with > > flow_dbg(): the skip itself happens on every tcp_prepare_flags() call > > until the first sample, which was 28 times for one connection in the > > test above, so logging it would be noisy. Each patch builds without > > warnings; I haven't run the test suite. >=20 > Thanks for the patches, and welcome to the git log! >=20 > I was about to merge both, but there's an issue with the first one, so > I could just merge 2/2 for the moment. I'm fairly confident that 1/2 > is actually correct, but it makes the migrate/rampstream_out test fail. >=20 > The migration functionality gives a hypervisor (currently this is only > supported with QEMU) a way to "move" all our context, including TCP > connections (!), between a source guest and a target guest, so that > virtual machines can be moved to another host as they are, with a short > interruption. The stages_v2[] array in migrate.c gives an overview of > what data can move to another instance of passt, and how. >=20 > That test checks that an outbound stream sent by a guest remains > consistent as it's moved from a source instance to a target instance of > passt. With 1/2, the flow appears to stop mid way, or to not restart > on the destination. >=20 > We don't copy the "low RTT" table during migration. I didn't think it > was needed, because, I thought, eventually the destination instance of > passt should figure things out. But it looks like it doesn't, and that > bug with the initial ~0U value hid the issue until now, that is, > (some?) migrated connections are _probably_ inserted by default in the > table. This is just a wild guess for the moment. Seems like there's a real bug here, but just migrating the low RTT table doesn't seem correct either: whether things are "local" or not could change because of the migration. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --BwANpvP7+shT8XKQ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmr8/EcACgkQzQJF27ox 2GeUDA//QHP03UNrpaNI5ZUrDQS13UO+sjQrFeb84kRZBn7wvJZw1vOh6oU2ycw4 iid6bzQ97fQ569mtUvfnRLlHm+fHvYokFuZu1GfTr7uy+TcFr6hV7TLEaP4bIvoN wAltas+PXbg5esD+J88Xpbkv8d7EUdWIZRmXx+QcerJ6bJydd5qEjLP6Suj6HsGD P79OGYMyqo16RaGWePYJYKDqw6bh3HAuSOjtk0NnfltsQoNF34dzyJt4+zM3cUEh 2Aa6qh2WbkAv8a/WMV+mBzF65buw5aEiIBO2T9C5aUk2sCH1U8Nz/rnHlie8a2HU odF1wbbCDMync2M8KvvC3O2+qsAEYH0dhT38WHUGB20kz+lX+turr6Q7Ba6TGPjd chEN8EyPaqh0GkDNjPTtBdjz/PlIDGPrDIeOrNVDo5yMiauK2UrOibqORGNoZu8b fQvucfwjR4wQ/5ivoKReohpaK3u1Qsb8ipJVzq8ZcPEpDEPkIPEINyXNggVUcir0 MvhEbaQypfGAydsjk27vaTyK/Z7Mz8jL2CmkWb+R+1WIDg+PM5hGycjKc6KsHhSi uEAxnzqjGZuFUzIV4Di8U9WU9TqiMkJ9L9Q+mdrqqz8NM10JrBjlsHmNmGlFaj9D oaPjoYlx1fjwBXZtRwWCW8dteeWWNHIC2M+osgGu30nWaAXNKP4= =bKal -----END PGP SIGNATURE----- --BwANpvP7+shT8XKQ--