From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YcRxqfbe; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 406665A0277 for ; Mon, 12 May 2025 10:54:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747040039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VJZS7WPpsqZqWfgeeuWPv5/vfd1zOOMsnWWW5kBQjSM=; b=YcRxqfbe2jbcXMxDC73RfnvA7+7Mj5QDNlcm9p0vRJH8xV5r7Oim6Y39H6Q0CNlT4KPmi2 2mBdxJGxCUxwBJsc+pQ4/+decklwO0AL/D/12vWomHy+0qFlnBZfJ25hImkH6tGRAG8FSX Mw26vu4hetFF29Q0ewxjPFNBydnxhdY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-56f8yuHzOEaOROR_ls5dcQ-1; Mon, 12 May 2025 04:53:57 -0400 X-MC-Unique: 56f8yuHzOEaOROR_ls5dcQ-1 X-Mimecast-MFC-AGG-ID: 56f8yuHzOEaOROR_ls5dcQ_1747040036 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cec217977so19852185e9.0 for ; Mon, 12 May 2025 01:53:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747040036; x=1747644836; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJZS7WPpsqZqWfgeeuWPv5/vfd1zOOMsnWWW5kBQjSM=; b=F6+1wQYztLtoQ6vKoR514jz7mI+us8FNaxd48N8aF/f0DgPgjT2nWZDemFOgkFwFVu Lto91Eu8jOArX18lHmVS9xa3Rs5Tjtn+TwwKrV31Ys5AvqBBqqTDm1PPOPsoxnss4R37 VZake+VtF4aIZRnec7yGj/rsWgL6AHusAyDYBTCMZZDR49mwIf7eUJoAQr+rXl1iyqC5 Gfl08saqHGe8/NgjjaFnNZyWrVgDhB3xfFXBVQGxq0N/eAbCg2YEJE2WKY1gjBieAH9J UkCZrL0S6u++tvjCgmJbdC8urE7smFgpRLbxljeUNb38NDBeCCHveDKQlvtNF/9SEccw IiYg== X-Gm-Message-State: AOJu0YybnAJFDTfd4SdtpHTMK3gBLlPI16OJvdSm+Q/l4B4ITjx+tuX1 0uHZLl0RjjwmsoUV8rj/T4kjJAtQZfVvUHyQUgxq8VX73iPg7Rj7BaTjBYcY2dbXkx5ARH+qwmN g4N5xY+vbOERstO51fSBhpA8dufzrr3WH0WoajOfztH+lpv4RytvQ8lRRJeKCYv14jAmqaLfHLP x7J4c2ptC6YoEtyYcNOF6dO0HS0oDw7s16 X-Gm-Gg: ASbGncvPPvSoLHXhuruezmwdFZGXQaZa6YJC3aGHIQe0qnVvUMALDiT0qpbOqnfz34R gNpu8rhJHNjgNv9JWg/NexjyEXQBZnyVfwadsG89baGATEEHsYBLRVHSrKlLHzXImNRlmmwxcYw 6mpUCAsFszAj4YSzqrpOqPdgYKHTe0sUsJMZ70oI9+TIv5mtttrmVQlIGvs2GYlAvGINwO/9Vrq 7/+rg+aZyrY7eHjwFJJBrxBnrqy+fMvf9G0w4Y0FAP9VQEMT/gI3yZXlzNJkGvzC19162hYd/OP WUBiMNIcosoG9qDPq6UG6Y68CRBRlpq6XjEbVhGFavxgmByV6w== X-Received: by 2002:a05:600c:b91:b0:441:b3eb:5720 with SMTP id 5b1f17b1804b1-442d6ddeb79mr93603805e9.29.1747040035961; Mon, 12 May 2025 01:53:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGXeFADAjoiUKpy7ITZKxrqffsmZlTbPbOnybnjpdP6A1BGhnp3A4WPzYtoqqLe9PX8nnUG/A== X-Received: by 2002:a05:600c:b91:b0:441:b3eb:5720 with SMTP id 5b1f17b1804b1-442d6ddeb79mr93603555e9.29.1747040035435; Mon, 12 May 2025 01:53:55 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442e3166b1csm57655125e9.0.2025.05.12.01.53.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 01:53:55 -0700 (PDT) Message-ID: Date: Mon, 12 May 2025 10:53:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] flow: fix podman issue #26073 To: passt-dev@passt.top References: <20250507123634.673320-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20250507123634.673320-1-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vH3JNGU6lkuqRxB9dhNiierP5Bi3TeRVpH7LNLarc2g_1747040036 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: JGG5QDGCZLP5H6ANYHF22DKFT3O6STQW X-Message-ID-Hash: JGG5QDGCZLP5H6ANYHF22DKFT3O6STQW X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 07/05/2025 14:36, Laurent Vivier wrote: > While running pasta, we trigger the following assert: > > ASSERTION FAILED in udp_at_sidx (udp_flow.c:35): flow->f.type == FLOW_UDP > > in udp_at_sidx() in the following path: > > 902 void udp_sock_handler(const struct ctx *c, union epoll_ref ref, > 903 uint32_t events, const struct timespec *now) > 904 { > 905 struct udp_flow *uflow = udp_at_sidx(ref.flowside); > > The invalid sidx is comming from the epoll_ref provided by epoll_wait(). > > This assert follows the following error: > > Couldn't connect flow socket: Permission denied > > It appears that an error happens in udp_flow_sock() and the recently > created fd is not removed from the epoll_ctl() pool: > > 71 static int udp_flow_sock(const struct ctx *c, > 72 struct udp_flow *uflow, unsigned sidei) > 73 { > ... > 82 s = flowside_sock_l4(c, EPOLL_TYPE_UDP, pif, side, fref.data); > 83 if (s < 0) { > 84 flow_dbg_perror(uflow, "Couldn't open flow specific socket"); > 85 return s; > 86 } > 87 > 88 if (flowside_connect(c, s, pif, side) < 0) { > 89 int rc = -errno; > 90 flow_dbg_perror(uflow, "Couldn't connect flow socket"); > 91 return rc; > 92 } > ... > > flowside_sock_l4() calls sock_l4_sa() that adds 's' to the epoll_ctl() > pool. > > So to cleanly manage the error of flowside_connect() we need to remove > 's' from the epoll_ctl() pool using epoll_del(). > > Link: https://github.com/containers/podman/issues/26073 > Signed-off-by: Laurent Vivier > --- > udp_flow.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/udp_flow.c b/udp_flow.c > index fea1cf3c7a41..b3a13b7993d5 100644 > --- a/udp_flow.c > +++ b/udp_flow.c > @@ -87,6 +87,10 @@ static int udp_flow_sock(const struct ctx *c, > > if (flowside_connect(c, s, pif, side) < 0) { > int rc = -errno; > + > + if (pif == PIF_HOST) > + epoll_del(c, s); > + > flow_dbg_perror(uflow, "Couldn't connect flow socket"); > return rc; > } After re-reading the code, I think we need also a "close(s)" and not the "(pif == PIF_HOST)" as flowside_sock_l4() also calls flowside_sock_splice() which call sock_l4_sa() too (but in a namespace). Laurent