public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] style: Fix 'Return' comment style
Date: Fri, 20 Jun 2025 11:37:04 +0200	[thread overview]
Message-ID: <b136f42f-5ec6-4772-bda2-e3b7e597c01d@redhat.com> (raw)
In-Reply-To: <20250620112411.0d7e5be1@elisabeth>

On 20/06/2025 11:24, Stefano Brivio wrote:
> On Thu, 19 Jun 2025 13:37:28 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
>> We always use imperative (no 'Returns:'), no tab after the ':' and
>> only one space, the first character is always lowercase.
>>
>> [...]
>>
>> @@ -129,7 +129,7 @@ static int udp_vu_sock_recv(const struct ctx *c, int s, bool v6, ssize_t *dlen)
>>    * @toside:	Address information for one side of the flow
>>    * @dlen:	Packet data length
>>    *
>> - * Return: Layer-4 length
>> + * Return: layer-4 length
> 
> ...unless it's a proper noun (Layer-4, Layer 4, L4...). I can fix this
> up on merge, but feel free to re-post. :)
> 

Done

Thanks,
Laurent


      reply	other threads:[~2025-06-20  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 11:37 [PATCH] style: Fix 'Return' comment style Laurent Vivier
2025-06-20  9:24 ` Stefano Brivio
2025-06-20  9:37   ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b136f42f-5ec6-4772-bda2-e3b7e597c01d@redhat.com \
    --to=lvivier@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).